From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC14DC433E6 for ; Wed, 10 Feb 2021 14:25:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C8F864E79 for ; Wed, 10 Feb 2021 14:25:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C8F864E79 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-Reply-To:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QpitctsWhVJ6W9DTnuPMsc9pWSbjT6W7uCmQ8WnJuAM=; b=DgwfyPyTvWYV3prLhey7YNVsS tu8r/kgDUJ51X63sSiD3mgv3JijPJ4DCyVgjhzw07IiMvFwR95LE6q/4QpDjAsQIKqI8bKvFHNEvL RFpRg12JO/4hul39TLLb+zuyYi+hZPhmCOPch/8LK1/x4kpMGfNeueHrgt0E8wl93dMsJooyZ+5/f 3efjYMA7olBPwk1Uzb1WhesA2EL8k/ARLS+jXd9iYqA+wPqf5ryMe9ApbGl9P4ZKr6Y0zglj66JSD 53tsIMRYL9025/Z0hQP/RRiCV61dB51igT1nPQCp/qyuD4Midt8zDJj5A4qtf7dw62jjptWUrxefW jptwGg00A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qQ3-0002pI-W6; Wed, 10 Feb 2021 14:24:40 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l9qPy-0002om-S6 for linux-arm-kernel@lists.infradead.org; Wed, 10 Feb 2021 14:24:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1612967075; x=1644503075; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=F7Pd2b9DeG2r46oRjSvo1Jq81YxiehO3b+tnE31zDrg=; b=HsA/EQhK9XW9s64XzdQmGIv34oaGlmJRHVPrH1eqvmoKat1Pscxy74Pu ypnL2aHZdcd+8aovIbJsFtGqIbrD8dLgFS5nZMi5naQGaM2gxAfWc1/uo 2aApVH/VtJ+DBIBD1c/yACV4XNXqmyARcuTwvljjPwa4V7+mNRsCDdCke xyqKAFfNrLn4d63tetRRxCbcoTHgKz49vmXfXuwj4EOsgcpf1Y6QsFqxF gHccwZBuCxB08X+Cf7vrqmw12a6hxl4wId9NVcTsCVmIaiT75P+0OBgTj PrgYAM0F3r0BXlIz+f0PDxg5T+Yxa5ralZ8s6Ko6hcQ6EXauC+4YSY4WE g==; IronPort-SDR: JwhbqzhZt55m0O+W4gvXqlgL5wIl8O2M7n3D/nevSJQ89EhPZk4NEDd+rcACbfteRJ66nxI9Bn Nd0ckDUNb1n5UFt2NT5aBxtsANwSzyRNOcZzfyjaEgmbKAv5ilg0pgFjjibHIW891k8Axgb0VA U4QlufibQpXCR1TdgSpyVl91lcYCp67kZ+iul+CqbRwgW9FwrsI8Nf2XBOrseUxMnvndlnXbxf 9qneyjFvYBZh/XuYVue9qpD4Ok5E+EVdONiBaFOaETSXwHlBASAyj8hXd00e6ePi2c+h6K3+/Z uEE= X-IronPort-AV: E=Sophos;i="5.81,168,1610434800"; d="scan'208";a="108712449" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 10 Feb 2021 07:24:32 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 10 Feb 2021 07:24:31 -0700 Received: from soft-dev10.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 10 Feb 2021 07:24:29 -0700 References: <20210210132751.1422386-1-geert+renesas@glider.be> <87mtwcujd0.fsf@microchip.com> <20210210141728.GO351084@piout.net> User-agent: mu4e 1.2.0; emacs 26.3 From: Lars Povlsen To: Geert Uytterhoeven Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII In-Reply-To: Date: Wed, 10 Feb 2021 15:24:28 +0100 Message-ID: <87lfbwuhk3.fsf@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210210_092435_074728_0FBE43B3 X-CRM114-Status: GOOD ( 25.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Linux Kernel Mailing List , Steen Hegelund , "open list:BROADCOM NVRAM DRIVER" , Microchip Linux Driver Support , "open list:GPIO SUBSYSTEM" , Linux ARM , Linus Walleij , Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Geert Uytterhoeven writes: > Hi Alexandre, > > On Wed, Feb 10, 2021 at 3:17 PM Alexandre Belloni > wrote: >> On 10/02/2021 14:53:01+0100, Geert Uytterhoeven wrote: >> > On Wed, Feb 10, 2021 at 2:45 PM Lars Povlsen wrote: >> > > Geert Uytterhoeven writes: >> > > > the Microsemi/Microchip Serial GPIO device is present only Microsemi >> > > > VCore III and Microchip Sparx5 SoCs. Hence add a dependency on >> > > > ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this >> > > > driver when configuring a kernel without support for these SoCs. >> > > > >> > > > Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") >> > > > Signed-off-by: Geert Uytterhoeven >> > > > --- >> > > > drivers/pinctrl/Kconfig | 4 ++-- >> > > > 1 file changed, 2 insertions(+), 2 deletions(-) >> > > > >> > > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >> > > > index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644 >> > > > --- a/drivers/pinctrl/Kconfig >> > > > +++ b/drivers/pinctrl/Kconfig >> > > > @@ -353,8 +353,8 @@ config PINCTRL_OCELOT >> > > > >> > > > config PINCTRL_MICROCHIP_SGPIO >> > > > bool "Pinctrl driver for Microsemi/Microchip Serial GPIO" >> > > > - depends on OF >> > > > - depends on HAS_IOMEM >> > > > + depends on OF && HAS_IOMEM >> > > > + depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST >> > > > select GPIOLIB >> > > > select GPIOLIB_IRQCHIP >> > > > select GENERIC_PINCONF >> > > >> > > Thank you for your patch. Unfortunately, it makes it impossible to use >> > > the driver across PCIe - which is a specifically desired configuration. >> > > >> > > Could you add CONFIG_PCI to the || chain? >> > >> > Sure. >> > >> > Is PCIe the only other transport over which the register can be accessed? >> > Or can this also be done over e.g. SPI, like on Ocelot[1]? >> > >> > [1] https://lore.kernel.org/linux-gpio/20200511145329.GV34497@piout.net/ >> > >> >> Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) >> so this is also available over SPI. > > Hence would you consider > > depends on ARCH_SPARX5 || SOC_VCOREIII || PCI || SPI || COMPILE_TEST > > acceptable? Or would that be futile, as must systems have PCI and/or > SPI enabled anyway? > > Gr{oetje,eeting}s, > > Geert Yes, that would be fine, but as you say - not have a lot of impact. Up to you... ---Lars -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel