From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: YueHaibing <yuehaibing@huawei.com>,
jason@lakedaemon.net, andrew@lunn.ch,
sebastian.hesselbarth@gmail.com, linus.walleij@linaro.org
Cc: linux-gpio@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon
Date: Fri, 25 Oct 2019 11:31:41 +0200 [thread overview]
Message-ID: <87lft9p3wi.fsf@FE-laptop> (raw)
In-Reply-To: <20191025092233.25108-1-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> writes:
> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
I am against this patch, I don't see any value of this change. It will
only make backporting future fix more difficult and will obscurate the
git blame.
I could see the interest of scripts/coccinelle/misc/semicolon.cocci
when submitting new code, but not for existing code.
Gregory
> ---
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> index 9df4277..fd32989 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> @@ -733,7 +733,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev,
> ret = 0;
> break;
> }
> - };
> + }
> if (ret) {
> dev_err(dev, "no gpio-controller child node\n");
> return ret;
> @@ -800,7 +800,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev,
> ret = 0;
> break;
> }
> - };
> + }
> if (ret)
> return ret;
>
> --
> 2.7.4
>
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-25 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 9:22 [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon YueHaibing
2019-10-25 9:31 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lft9p3wi.fsf@FE-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).