From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E840CA9EA0 for ; Fri, 25 Oct 2019 09:31:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3406721D7B for ; Fri, 25 Oct 2019 09:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WRZWVaVO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3406721D7B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sY7Sggi8xFW7gsu/O6OPVIaXCB4hWlq00cKPvxhs4vs=; b=WRZWVaVOJi2BU0 84eMAIjaB7j9SFwA2DWx38Heif+6T9aukLM0L6V9lYB7qT+zjax26C0brJ+SQGXgSR4qpNtCorOIM S3e8hFsSjmYyCIqFQ/TtG2xK/XCRzD18Laro9uNmOBRNB/xJ4ZPcBfWYnGHo1TtApU72DbskGseTP r5wfAboLMQM9g4J1HyP+zhONZZJ8zvGcjrQTYQj1o1kVQ9iJOwTIa0aaiL5IQtkdEIThmpTPUWSYk c1OTAca/drGKHT5QGVu5xPbKL/zQhSF2Cfz0IvTBDvFvk4gf8RYyXmdRX/aifuTIt+f0UI/JuXYKe Dcf4Z8HUTPx6NLZw0r1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNvwh-000407-RH; Fri, 25 Oct 2019 09:31:47 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNvwe-0003z4-VZ for linux-arm-kernel@lists.infradead.org; Fri, 25 Oct 2019 09:31:46 +0000 X-Originating-IP: 92.137.17.54 Received: from localhost (alyon-657-1-975-54.w92-137.abo.wanadoo.fr [92.137.17.54]) (Authenticated sender: gregory.clement@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E7C3160004; Fri, 25 Oct 2019 09:31:41 +0000 (UTC) From: Gregory CLEMENT To: YueHaibing , jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, linus.walleij@linaro.org Subject: Re: [PATCH -next] pinctrl: armada-37xx: remove unneeded semicolon In-Reply-To: <20191025092233.25108-1-yuehaibing@huawei.com> References: <20191025092233.25108-1-yuehaibing@huawei.com> Date: Fri, 25 Oct 2019 11:31:41 +0200 Message-ID: <87lft9p3wi.fsf@FE-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191025_023145_151979_B70636F8 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, YueHaibing , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org YueHaibing writes: > Remove unneeded semicolon. > This is detected by coccinelle. > > Signed-off-by: YueHaibing I am against this patch, I don't see any value of this change. It will only make backporting future fix more difficult and will obscurate the git blame. I could see the interest of scripts/coccinelle/misc/semicolon.cocci when submitting new code, but not for existing code. Gregory > --- > drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > index 9df4277..fd32989 100644 > --- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > +++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c > @@ -733,7 +733,7 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, > ret = 0; > break; > } > - }; > + } > if (ret) { > dev_err(dev, "no gpio-controller child node\n"); > return ret; > @@ -800,7 +800,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev, > ret = 0; > break; > } > - }; > + } > if (ret) > return ret; > > -- > 2.7.4 > > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel