From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BF97C4345F for ; Wed, 24 Apr 2024 17:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u0Bjfx1o1DZzkAB2IfE311wkTAj7Qad9tFtyfITMQR8=; b=eraT1z1d2hrwLL D6o+5Awc0Mk1oyFncrJomyQI1ySS+Cuwowu9jJqObEkPdhFM+g+sCw90sNKby23ZjDQJtMAItXrPY u8YB44tKipMMtO++eIQXbL1OJEuUTt4zJ0JBxykGZM3mBkuCvM5G8IHG14gSajz3SGX50FSG8HXT0 j8JtwuiNfGk4IceIXYX8l96YcuCv7piQyjYpa/cD9Uv/MuFYrYEQavympHloce3oyWkoIxZJQalO4 /sEH9Z4iQbCRQil9Avz48OxBLrUrd0XhoLGQmIC49GHhSklsiLY1a8dO3MymagGv9ZE9iLczVtbgw rGvl1EP+TlZcdtpv0VuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzgHg-000000055b9-1cpR; Wed, 24 Apr 2024 17:19:52 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzgHZ-000000055YG-3xta for linux-arm-kernel@lists.infradead.org; Wed, 24 Apr 2024 17:19:50 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1713979182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OIgX8hYJKedlWpKZHCISbN03B7+KCkzESKI9X941yRc=; b=hUc+bY7XdaUe4i2b4TqKGtx9lDylLSmzldzEvAn8mQPtvdDYs0v5kWtB3Nm+Vu8JpW93Vg gGUat+XkI/WTRN1zIU/3ouPh047NwBu6a8uufa1eNllk7BZumEazzM5tJEfP08+VOaHHk0 b2pSU387zODGqcMMv+7Dzzsy9CkqGTdg/QXNNJZ0r0tSUv6IdVSQgc3oN4/3hciLoDZi0C Tjl1UwBQWMlIEHh4VniIZaHY/kzWdUoQUHfQMoPpnK8rB7LOemzTxp5tYcpR4cqsvg3387 6OY2gH33HcmtgCgw4jQZYeYWASq0HYq41H11rgELbVTmshv6Wz04FMkdsyZcng== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1713979182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OIgX8hYJKedlWpKZHCISbN03B7+KCkzESKI9X941yRc=; b=cq0zlA4jo7geFavqDooN7ZB8M5yDubfi1Jxg4xvuyaqXGVTXw2TP9zlz2YlfTN80nG7xIi w1fmOJpSR2WXIxDg== To: Florian Fainelli , Florian Fainelli , linux-kernel@vger.kernel.org Cc: opendmb@gmail.com, Tim Ross , Broadcom internal kernel review list , "open list:BROADCOM BMIPS MIPS ARCHITECTURE" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" Subject: Re: [PATCH] irqchip/irq-brcmstb-l2: Avoid saving mask on shutdown In-Reply-To: References: <20240416194343.469318-1-florian.fainelli@broadcom.com> <87le55ulw5.ffs@tglx> <958c27b1-26d7-4927-976b-4502f33f31f7@gmail.com> <87il09ufl4.ffs@tglx> Date: Wed, 24 Apr 2024 19:19:18 +0200 Message-ID: <87mspiu19l.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240424_101946_173226_41EFED8D X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 24 2024 at 09:50, Florian Fainelli wrote: > On 4/22/24 16:45, Thomas Gleixner wrote: >> On Mon, Apr 22 2024 at 15:26, Florian Fainelli wrote: >>> On 4/22/24 14:29, Thomas Gleixner wrote: >>>>> + if (save) >>>>> + b->saved_mask = irq_reg_readl(gc, ct->regs.mask); >>>> >>>> what's the conditional actually buying you except more complex code? >>> >>> Not much this is an optimization that is simple to carry out. There can >>> be dozens of such L2 interrupt controllers in a given system and the >>> MMIO accesses start adding up eventually. >> >> I'm impressed by saving ~12 microseconds per one dozen of interrupt >> controllers on system shutdown :) > > I know, right? More seriously are you willing to take that patch, should > I write a better justification? I don't have real objections other than rolling my eyes, but a better justification would be useful. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel