From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D912BC197A0 for ; Thu, 16 Nov 2023 11:35:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3PV2ciUq/dn1oCvn+f/v975cNp8+v/lS7g2FMIcNC9M=; b=eCK82Qa3i7MGD6 9/62ke2LICFw6CWgure/gHvF2p4uJ6iYdSZv3QSL86Ux59SIRTMqY0rFpn3GpOLLpxI+9ATrIpOLK 4joqMvlPHmlY6hCx9I93L7r+qA/3+054EGlCye6HB7KbojD+/YRXirprKlLyTaFNaEmYDUQSZ+/oD BjJH5XZmc8gjjVa3gSotpCzeiiDCMrRcyzYLjo40BthRS6+hS8oFyZA0+q9R0YJDN5LISAXxNDvL5 GdzbwxPP52yNWGgNHspeKFp52odFRhCE+3oG3aNV8UCplmmhekLzij04EbJ1OKnV0n1dEFfRGS+vO Yz9XDuTE8oGuXcOdutwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3aek-003FgA-0D; Thu, 16 Nov 2023 11:35:34 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3aee-003Fep-0R for linux-arm-kernel@lists.infradead.org; Thu, 16 Nov 2023 11:35:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700134526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vHuYUuizMOXdym2WVrnt+tzD4LF9VF0OJSRnj/ZZhrU=; b=bxlhwr3x3s1YkP9mPJf6/9pyfLt6x+1TbMy6t9BuNvfx/hddGTw7ze3K6nU7KWOh0BZTP+ Kp92J5vK7KQ8+b1Te5M6mgSbBI/2QWOd7JpQbbSv5739KqCJ4XryYrGBUAG0U9NCr2wSLu 11CB9X6tUm6a2hKe51DW/yiKNtiycgc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-s4hDh2J0MjqYKLKbRejMCA-1; Thu, 16 Nov 2023 06:35:23 -0500 X-MC-Unique: s4hDh2J0MjqYKLKbRejMCA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40855a91314so3233035e9.1 for ; Thu, 16 Nov 2023 03:35:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700134522; x=1700739322; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vHuYUuizMOXdym2WVrnt+tzD4LF9VF0OJSRnj/ZZhrU=; b=oz5P8K8LuaU+JgPWWfiwRhYiXtND5Plgbm7wXDRjGltryyVIZ/B49nmF64T40B7FXP zCo2cIxHAZfRLl3Goxnc699IZPvf8ML9eafry4rjBQ/qgx0pu6eDeyEAjiFtHjYO+Q0o BevlEaRVF7kBdEamiz8+SoWSbheNctZHsV9i/vWgsxPIXSUIV1vR2TuIck82KXfz86UF 4lA2F89I/uXzkDZZiP+RA0AeaYRqKCzxqoDjL1l2dQvcdJWm7UMTFtzPeN7vjE21Misi UvW/2IavyuIt6keW1iS/GnFkjTVuVGYUBxDsHTr4woLdABt2VScIAtb5hPS641NNqSRW sgAw== X-Gm-Message-State: AOJu0YzA5tSAFS0oG9kC4raZBni3ZOvxAHFXdibGZeCxrat15NkgKlUM ezMuWh1ulshloJMmAY9hNOEvc3f1OmX9ZL+DOrWaZJ9fFbswdux32X0gAeMmFzV/ffDrTDthx4W vjDOoHhUK6E8iigDhq6Vbxqlat4kvi+HHWYA= X-Received: by 2002:a05:600c:1f0e:b0:403:aced:f7f4 with SMTP id bd14-20020a05600c1f0e00b00403acedf7f4mr1397092wmb.12.1700134522815; Thu, 16 Nov 2023 03:35:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXquGc9BBVzhA3pQ5y5VxKkb1ntqSX7uzGlTp88oTbLAi3A8LRxdPbW7vrN8FyN7RKFdG9Uw== X-Received: by 2002:a05:600c:1f0e:b0:403:aced:f7f4 with SMTP id bd14-20020a05600c1f0e00b00403acedf7f4mr1397075wmb.12.1700134522532; Thu, 16 Nov 2023 03:35:22 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id v5-20020a05600c470500b0040a5290dceesm3348135wmo.0.2023.11.16.03.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Nov 2023 03:35:22 -0800 (PST) From: Javier Martinez Canillas To: Thomas Zimmermann , deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 24/32] fbdev/cyber2000fb: Initialize fb_ops with fbdev macros In-Reply-To: <20231115102954.7102-25-tzimmermann@suse.de> References: <20231115102954.7102-1-tzimmermann@suse.de> <20231115102954.7102-25-tzimmermann@suse.de> Date: Thu, 16 Nov 2023 12:35:21 +0100 Message-ID: <87msve2ao6.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231116_033528_269651_1BEF3277 X-CRM114-Status: GOOD ( 11.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Initialize the instance of struct fb_ops with fbdev initializer > macros for framebuffers in I/O address space. Set the read/write, > draw and mmap callbacks to the correct implementation and avoid > implicit defaults. Also select the necessary helpers in Kconfig. > > Fbdev drivers sometimes rely on the callbacks being NULL for a > default I/O-memory-based implementation to be invoked; hence > requiring the I/O helpers to be built in any case. Setting all > callbacks in all drivers explicitly will allow to make the I/O > helpers optional. This benefits systems that do not use these > functions. > > Signed-off-by: Thomas Zimmermann > Cc: Russell King > Cc: linux-arm-kernel@lists.infradead.org > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel