From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED3CACD54A9 for ; Tue, 19 Sep 2023 09:55:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74JH5jXKi89IWh5jE8gtiNsbR6Q4elm8b7KzjqIahEY=; b=3EpQUfRPOumT2F bNI3CHw7tkDvqLfZprLcAQI8nyrTqB1jTnvwlMQeduAme+xO0dDZU5YRvSfWiwsmwjdYxT/CUpog6 RsfSMEhCp/W5Wcs3VO90Q729yGfUcC8Du23BzNY/NvmjT3WVZwyLLon8GMmOClrHBJfmTJ7XT7Cns VtXNTvVtOeKSOAf4obtoFAk+rukmfNcpSesjTyGHfhnZPuP3XjhZMGj4luWtx26h8d45vv7XTvdPi sNmi/A3Wr1OVE/HTePY+N79viq0WOcjvImLcWz5ja/bLGUjULWXnqgDUDzCUzKkOZIWGoH/87kvyb /S6qcH9rRy9k+dK5D8Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qiXRm-00HZ0n-0E; Tue, 19 Sep 2023 09:55:10 +0000 Received: from mgamail.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qiXRj-00HYzJ-0d; Tue, 19 Sep 2023 09:55:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695117307; x=1726653307; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=VE2rjU6vKS7B5FcRe/RnrC2e6YXvyOnWP8lQUDgIgR0=; b=X4jp3l+ZruwwgOtci38Y+IJVj4C02uZF9CNMeYViHYxwpkjJ7iMBUhSR b7kyolBTwDQtsCf8bhENfTfd+XyMtAuFX0HxYlRs9jZotw1RIxMoP684T II5B3/MzXXfOpXNO3jTMgV/DBajFnEY2ZeBblOwpZilSsNJw6URxiKXj6 iRoJ/6aysKELBfWZmyWKHMDPW63xpNcppNYuNSd8PPdhVeMgrjEhhk8qe nbMQyOtciGZl0qbC406f03F+vQP9KdMYezd0NSHvUgvCIi5FplU6PfKap 4aNW8fbeZ+nnv+POPjtu1JzQg8Vb+6ooQkr+JBL8HSj20bZprvRhxhpSq Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="382651757" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="382651757" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 02:55:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10837"; a="695850188" X-IronPort-AV: E=Sophos;i="6.02,159,1688454000"; d="scan'208";a="695850188" Received: from tjquresh-mobl.ger.corp.intel.com (HELO localhost) ([10.252.37.227]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Sep 2023 02:55:00 -0700 From: Jani Nikula To: neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org Cc: Neil Armstrong , Sam Ravnborg , Martin Blumenstingl , Kevin Hilman , Jerome Brunet , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] drm/meson: fix memory leak on ->hpd_notify callback In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20230914131015.2472029-1-jani.nikula@intel.com> Date: Tue, 19 Sep 2023 12:54:58 +0300 Message-ID: <87msxitrm5.fsf@intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230919_025507_293151_8F3B4CF7 X-CRM114-Status: GOOD ( 11.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 15 Sep 2023, Neil Armstrong wrote: > On 14/09/2023 15:10, Jani Nikula wrote: >> The EDID returned by drm_bridge_get_edid() needs to be freed. >> >> Fixes: 0af5e0b41110 ("drm/meson: encoder_hdmi: switch to bridge DRM_BRIDGE_ATTACH_NO_CONNECTOR") >> Cc: Neil Armstrong >> Cc: Sam Ravnborg >> Cc: Martin Blumenstingl >> Cc: Neil Armstrong >> Cc: Kevin Hilman >> Cc: Jerome Brunet >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-amlogic@lists.infradead.org >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: # v5.17+ >> Signed-off-by: Jani Nikula >> >> --- >> >> UNTESTED >> --- >> drivers/gpu/drm/meson/meson_encoder_hdmi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/meson/meson_encoder_hdmi.c b/drivers/gpu/drm/meson/meson_encoder_hdmi.c >> index 9913971fa5d2..25ea76558690 100644 >> --- a/drivers/gpu/drm/meson/meson_encoder_hdmi.c >> +++ b/drivers/gpu/drm/meson/meson_encoder_hdmi.c >> @@ -334,6 +334,8 @@ static void meson_encoder_hdmi_hpd_notify(struct drm_bridge *bridge, >> return; >> >> cec_notifier_set_phys_addr_from_edid(encoder_hdmi->cec_notifier, edid); >> + >> + kfree(edid); >> } else >> cec_notifier_phys_addr_invalidate(encoder_hdmi->cec_notifier); >> } > > Reviewed-by: Neil Armstrong Thanks. I don't seem to have a toolchain to get this to build... would you mind applying this, please? BR, Jani. -- Jani Nikula, Intel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel