From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F2AEECAAD8 for ; Tue, 30 Aug 2022 07:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YTsnHygyABcY45aVcK+YTPos0zAGEVRvgVew+aYO2Hg=; b=IBDXJTLjYGYG1r 6fm109GVmkxeplTxv7mxSHjPnroQ6CDrsFyl3ZROYpvN3T/L/6LfmXShtbSF3Gbg9QSi8SrIK0McC 3hIrkxb4U7V2IVpEXWVWSrNAQ7roEL6FENB5N1bHwLzx9jzCNxGe9b6mpI3ZYjUqBVvL5ypWfjzOq Y4ZNuocoZ5tn75++8H4ayNR6EdFUzvt+hrahzSOHd/yn90dXqKmDOpQT77Sf4zRUt4J7kDVyLs5Oy qYIvw/3L/woMC6tpsh3qFMDYrkyCO1i7dtsxL7lEuX3x33y6Wlux33Vxtdp+sbCEFBArB/IBONUmn jEqNOs3AIy4rHP09adfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSvzD-00Eu7Z-Ae; Tue, 30 Aug 2022 07:48:40 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oSvsv-00EqrZ-9K for linux-arm-kernel@lists.infradead.org; Tue, 30 Aug 2022 07:42:11 +0000 Received: (Authenticated sender: gregory.clement@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 90C381C000B; Tue, 30 Aug 2022 07:42:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661845322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OlJsykSuKUj404P3HmaG9eK2FUUXIkKuT4JtjowBQZQ=; b=kb3YuCStxdgM8c7BnX9v8sq2Dq25KzFhRtYTBt14EnoPA4vS5/Ydpz2SXeC1kR3lmzHVK0 PMyzQbQsYhwnCIpApS2jY0zpjSOosSNlI51XjqxgxiWi+89q48hrEAczm1LN0mEyIbtASk 80VsTFVPGwpKhBXz4z/mRAt9vSk5gGGvB0+InLwVH+u5lOj96WudzIT/M95aegn6MVnTa3 l1gN+u+hCD1ExxftigI+eU9iJL0Kd6tQFyuN7eJz38ZYKWxGU9uWTQ4kY/Rm6u30XUOGll mxJ9oVorjw4+CRw16xMf2/8bPbUzu3suARsCxdHONwJ2qvDOLvS02MHGWXdtyg== From: Gregory CLEMENT To: Robert Marko , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, kostap@marvell.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: Re: [PATCH v4 10/10] arm64: dts: marvell: add support for Methode eDPU In-Reply-To: References: <20220516124828.45144-1-robert.marko@sartura.hr> <20220516124828.45144-10-robert.marko@sartura.hr> Date: Tue, 30 Aug 2022 09:42:00 +0200 Message-ID: <87mtbm5gaf.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220830_004209_662940_F5011639 X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Robert Marko writes: > On Mon, May 16, 2022 at 2:48 PM Robert Marko wrote: >> >> Methode eDPU is an Armada 3720 powered board based on the Methode uDPU. >> >> They feature the same CPU, RAM, and storage as well as the form factor. >> >> However, eDPU only has one SFP slot plus a copper G.hn port. >> >> Signed-off-by: Robert Marko >> Reviewed-by: Krzysztof Kozlowski >> --- >> Changes in v2: >> * Make the DTS split a separate commit >> --- >> arch/arm64/boot/dts/marvell/Makefile | 1 + >> arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts | 14 ++++++++++++++ >> 2 files changed, 15 insertions(+) >> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> >> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile >> index 1c794cdcb8e6..104d7d7e8215 100644 >> --- a/arch/arm64/boot/dts/marvell/Makefile >> +++ b/arch/arm64/boot/dts/marvell/Makefile >> @@ -1,6 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0 >> # Mvebu SoC Family >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-db.dtb >> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-eDPU.dtb >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin.dtb >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb >> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> new file mode 100644 >> index 000000000000..57fc698e55d0 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/marvell/armada-3720-eDPU.dts >> @@ -0,0 +1,14 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> + >> +/dts-v1/; >> + >> +#include "armada-3720-uDPU.dtsi" >> + >> +/ { >> + model = "Methode eDPU Board"; >> + compatible = "methode,edpu", "marvell,armada3720", "marvell,armada3710"; >> +}; >> + >> +ð0 { >> + phy-mode = "2500base-x"; >> +}; >> -- >> 2.36.1 >> > > Hi Gregory, Hello Roberto, > Is there something else that I can improve in the series? Sorry for having missed this series. At first view it seems OK, I am going to have a closer look this week. Gregory > > Regards, > Robert > > -- > Robert Marko > Staff Embedded Linux Engineer > Sartura Ltd. > Lendavska ulica 16a > 10000 Zagreb, Croatia > Email: robert.marko@sartura.hr > Web: www.sartura.hr -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel