From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBC4C433DB for ; Fri, 12 Feb 2021 00:00:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B52D564DEA for ; Fri, 12 Feb 2021 00:00:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B52D564DEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-reply-to:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xwA4cYFFEMgijtd3RZUxWXaD5QLWiAafbhvZzGY5Dw4=; b=Ia+ITMhnXeH8c/LTb5JY2YkX4 qHOHvXNMNkFFtSJg5Nbt/aeVMHfjH+CckbN92HO2BXV2CzTtjEmKGBFUVwh/rfPOzy+5OdxJ6NeWA RiCecMJo73aRte0HdzL5oLGUFCJY49PjvwdSKacr1JeCHQhHu1+ExtTd/ilFHm0/UHYdIYagvZ7Jy ysyKunt4q7TimJIIQNt6jtAviFUvk5ylNtxizojtqjOpvR2BMaEQ4yw8suz4C39lfFwYdkKBTfKsP mMjyO5PJy059LzvCQPCkGQaIoYyuuc4loz9Ea2xZ4R5iK3WHRYG8wiRlV72PGiUu1axVlRiwF01Fh sXrtWH2TA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lALrk-0000jM-Lu; Thu, 11 Feb 2021 23:59:20 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lALrh-0000iu-VL for linux-arm-kernel@lists.infradead.org; Thu, 11 Feb 2021 23:59:19 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 11BNtv5I061406; Thu, 11 Feb 2021 18:59:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : mime-version : content-type; s=pp1; bh=6tuxnpSv368pdOo0WjwpdsaB791gBkRKI6kVA07oHWU=; b=Bop3BphWAkbIWVK/HYGTx96aeJJV3FcTW4+92F2Afr5wsR6cALLm7jXCS7y1WJubeLRW WFDY4zA0ISjV0MQcmjjIPXfAX/fsEFrYgtU7uj9Ix9oZk+75cOE3TyMNf+amwqNTM+oO 4udZ9v0sksJ+rYql6jEBVIKxpKbqV58Odo5NjyBZDullujR5ZYxEjRKGiHibRq0pOJ4A dm0TLBviLoF6xfSKsDCwfErsTNhA+q1TcQb8Dow3n25Gedvh7Fez54vND70G7QZGR8Uu CQT1kOv/dGPOhGOOmIwQRdFAX21zuqLjk1QaZ8NlCoSlJ9rIrnWg/T5efhdwNQWKKkb3 8A== Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 36nepfr1as-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 18:59:14 -0500 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 11BNvZiV017261; Thu, 11 Feb 2021 23:59:13 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma04dal.us.ibm.com with ESMTP id 36hjra3m2n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 11 Feb 2021 23:59:13 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 11BNxC9v24707454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Feb 2021 23:59:12 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8463DBE04F; Thu, 11 Feb 2021 23:59:12 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C05E3BE056; Thu, 11 Feb 2021 23:59:10 +0000 (GMT) Received: from manicouagan.localdomain (unknown [9.85.204.73]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Thu, 11 Feb 2021 23:59:10 +0000 (GMT) References: <202102120032.Bv0MoYv7-lkp@intel.com> <40fd1869-dcb4-36ae-e997-b8486dd4846c@linux.microsoft.com> User-agent: mu4e 1.4.10; emacs 27.1 From: Thiago Jung Bauermann To: Lakshmi Ramasubramanian Subject: Re: Fwd: Re: [PATCH v17 02/10] of: Add a common kexec FDT setup function In-reply-to: Date: Thu, 11 Feb 2021 20:59:08 -0300 Message-ID: <87mtwap35f.fsf@manicouagan.localdomain> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369, 18.0.737 definitions=2021-02-11_07:2021-02-11, 2021-02-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 mlxscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102110182 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210211_185918_407171_C397864C X-CRM114-Status: GOOD ( 19.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , linux-integrity@vger.kernel.org, linuxppc-dev , linux-arm-kernel , Mimi Zohar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Lakshmi Ramasubramanian writes: > On 2/11/21 9:42 AM, Lakshmi Ramasubramanian wrote: >> Hi Rob, >> [PATCH] powerpc: Rename kexec elfcorehdr_addr to elf_headers_mem >> This change causes build problem for x86_64 architecture (please see the >> mail from kernel test bot below) since arch/x86/include/asm/kexec.h uses >> "elf_load_addr" for the ELF header buffer address and not >> "elf_headers_mem". >> struct kimage_arch { >> ... >> /* Core ELF header buffer */ >> void *elf_headers; >> unsigned long elf_headers_sz; >> unsigned long elf_load_addr; >> }; >> I am thinking of limiting of_kexec_alloc_and_setup_fdt() to ARM64 and >> PPC64 since they are the only ones using this function now. >> #if defined(CONFIG_ARM64) && defined(CONFIG_PPC64) > Sorry - I meant to say > #if defined(CONFIG_ARM64) || defined(CONFIG_PPC64) > Does it build correctly if you rename elf_headers_mem to elf_load_addr? Or the other way around, renaming x86's elf_load_addr to elf_headers_mem. I don't really have a preference. That would be better than adding an #if condition. >> void *of_kexec_alloc_and_setup_fdt(const struct kimage *image, >> unsigned long initrd_load_addr, >> unsigned long initrd_len, >> const char *cmdline) >> { >> ... >> } >> #endif /* defined(CONFIG_ARM64) && defined(CONFIG_PPC64) */ >> Please let me know if you have any concerns. >> thanks, >> -lakshmi -- Thiago Jung Bauermann IBM Linux Technology Center _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel