From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, benh@kernel.crashing.org,
bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com,
paulus@samba.org, vincenzo.frascino@arm.com,
frowand.list@gmail.com, sashal@kernel.org,
Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
mpe@ellerman.id.au, masahiroy@kernel.org, jmorris@namei.org,
takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org,
catalin.marinas@arm.com, serge@hallyn.com,
devicetree@vger.kernel.org, pasha.tatashin@soleen.com,
will@kernel.org, prsriva@linux.microsoft.com,
hsinyi@chromium.org, allison@lohutok.net,
christophe.leroy@c-s.fr, mbrugger@suse.com,
balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com,
linux-kernel@vger.kernel.org, james.morse@arm.com,
linux-integrity@vger.kernel.org
Subject: Re: [RFC PATCH 2/4] of: Add a common kexec FDT setup function
Date: Tue, 22 Dec 2020 18:48:14 -0300 [thread overview]
Message-ID: <87mty5ldgh.fsf@manicouagan.localdomain> (raw)
In-Reply-To: <20201211221006.1052453-3-robh@kernel.org>
Rob Herring <robh@kernel.org> writes:
> Both arm64 and powerpc do essentially the same FDT /chosen setup for
> kexec. We can simply combine everything each arch does. The differences
> are either omissions that arm64 should have or additional properties
> that will be ignored.
>
> The differences relative to the arm64 version:
> - If /chosen doesn't exist, it will be created (should never happen).
> - Any old dtb and initrd reserved memory will be released.
> - The new initrd and elfcorehdr are marked reserved.
> - "linux,booted-from-kexec" is set.
>
> The differences relative to the powerpc version:
> - "kaslr-seed" and "rng-seed" may be set.
> - "linux,elfcorehdr" is set.
I especially like the elfcorehdr property. It always bothered me that we
pass it on the kernel command line, since it's not something that could
or should be set by an admin.
> - Any existing "linux,usable-memory-range" is removed.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> This could be taken a step further and do the allocation of the new
> FDT. The difference is arm64 uses vmalloc and powerpc uses kmalloc. The
> arm64 version also retries with a bigger allocation. That seems
> unnecessary.
> ---
> drivers/of/Makefile | 1 +
> drivers/of/kexec.c | 228 ++++++++++++++++++++++++++++++++++++++++++++
> include/linux/of.h | 5 +
> 3 files changed, 234 insertions(+)
> create mode 100644 drivers/of/kexec.c
Reviewed-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
--
Thiago Jung Bauermann
IBM Linux Technology Center
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-22 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 22:10 [RFC PATCH 0/4] Kexec FDT setup consolidation Rob Herring
2020-12-11 22:10 ` [RFC PATCH 1/4] powerpc: Rename kexec elfcorehdr_addr to elf_headers_mem Rob Herring
2020-12-12 0:54 ` Lakshmi Ramasubramanian
2020-12-22 21:42 ` Thiago Jung Bauermann
2020-12-11 22:10 ` [RFC PATCH 2/4] of: Add a common kexec FDT setup function Rob Herring
2020-12-12 1:18 ` Lakshmi Ramasubramanian
2020-12-12 2:17 ` Thiago Jung Bauermann
2020-12-12 5:46 ` Lakshmi Ramasubramanian
2020-12-22 21:48 ` Thiago Jung Bauermann [this message]
2020-12-11 22:10 ` [RFC PATCH 3/4] arm64: Use common of_kexec_setup_new_fdt() Rob Herring
2020-12-12 15:20 ` Lakshmi Ramasubramanian
2020-12-22 21:49 ` Thiago Jung Bauermann
2021-01-12 14:02 ` Will Deacon
2020-12-11 22:10 ` [RFC PATCH 4/4] powerpc: " Rob Herring
2020-12-12 15:22 ` Lakshmi Ramasubramanian
2020-12-22 21:55 ` Thiago Jung Bauermann
2020-12-22 23:33 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mty5ldgh.fsf@manicouagan.localdomain \
--to=bauerman@linux.ibm.com \
--cc=allison@lohutok.net \
--cc=balajib@linux.microsoft.com \
--cc=benh@kernel.crashing.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hsinyi@chromium.org \
--cc=james.morse@arm.com \
--cc=jmorris@namei.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mbrugger@suse.com \
--cc=mpe@ellerman.id.au \
--cc=nramas@linux.microsoft.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulus@samba.org \
--cc=prsriva@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=sashal@kernel.org \
--cc=serge@hallyn.com \
--cc=takahiro.akashi@linaro.org \
--cc=tao.li@vivo.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox