From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50D9C43461 for ; Sun, 13 Sep 2020 15:35:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27B5620770 for ; Sun, 13 Sep 2020 15:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jKScU2k4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0Wtk1MMY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27B5620770 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q1ssouI0a41GwshJu4UnxoadHTqH71T2VU4+ykHtsUI=; b=jKScU2k4a4ua5kAx7uo1cAd7P cNza56D+qfab61nIqmBJpg9iY0PKebHhyk8mjFXH4lxdMQDQCccC75l9TD/BLQLOR35hsLDyzAOiS nt5ogc026n/KrvtVKArV/tVE9Oqm4nwLRDBpAyxH7z00HJQSYToH4dh3P1mcikVRTtQvJIJOlyFC5 EgzATb/PCAuXGStJSHY0WeMmGhXUeA3rqfmlHf7dgqz6+SaL66dn1DhTO8HEOsp+0sE3B/tQk2mfT ir7mRmKEA50SvzxQNKkpiPzIwgdf1Wl+h1jTAbYewQj5yrxgReP9u2LJZit3iggIQ/c1qdB/QmQbq cx64UGpkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHU16-0002Na-SK; Sun, 13 Sep 2020 15:34:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHU14-0002ND-3L for linux-arm-kernel@lists.infradead.org; Sun, 13 Sep 2020 15:34:10 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5D6EF2078D; Sun, 13 Sep 2020 15:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600011248; bh=U7j8lScFgpuEW/6fVOIsPgZrSsqPIYFR9iMMpABDa4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0Wtk1MMYl2QoNCwq4dh2Ew5BgyQLdcbHQF5C59Ra2Guz9bP1QpQO2MYOZP+IsmbMk L5p0JedGxSNbbxu3WUzHqsI0gFpP/+cYUFo4a+DCzg93Pt7ScX76ZHJ3bz6w24olTZ ihF2F3PjHpCDytx6DdNfi5pHknqd53YMkAcZtNbw= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHU10-00BSHc-8H; Sun, 13 Sep 2020 16:34:06 +0100 Date: Sun, 13 Sep 2020 16:34:05 +0100 Message-ID: <87mu1tr8r6.wl-maz@kernel.org> From: Marc Zyngier To: Krzysztof Kozlowski Subject: Re: [PATCH 2/2] irqchip/ti-sci-inta: Fix kerneldoc In-Reply-To: <20200902174615.24695-2-krzk@kernel.org> References: <20200902174615.24695-1-krzk@kernel.org> <20200902174615.24695-2-krzk@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: krzk@kernel.org, nm@ti.com, t-kristo@ti.com, ssantosh@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_113410_217613_CBBAEAF1 X-CRM114-Status: GOOD ( 22.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Jason Cooper , linux-kernel@vger.kernel.org, Tero Kristo , Santosh Shilimkar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 02 Sep 2020 18:46:15 +0100, Krzysztof Kozlowski wrote: > > Fix kerneldoc W=1 warnings: > > drivers/irqchip/irq-ti-sci-inta.c:144: warning: Function parameter or member 'vint_id' not described in 'ti_sci_inta_xlate_irq' > drivers/irqchip/irq-ti-sci-inta.c:144: warning: Excess function parameter 'irq' description in 'ti_sci_inta_xlate_irq' > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/irqchip/irq-ti-sci-inta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c > index bc863ef7998d..84929f3e2003 100644 > --- a/drivers/irqchip/irq-ti-sci-inta.c > +++ b/drivers/irqchip/irq-ti-sci-inta.c > @@ -134,7 +134,7 @@ static void ti_sci_inta_irq_handler(struct irq_desc *desc) > /** > * ti_sci_inta_xlate_irq() - Translate hwirq to parent's hwirq. > * @inta: IRQ domain corresponding to Interrupt Aggregator > - * @irq: Hardware irq corresponding to the above irq domain > + * @vint_id: TISCI vint ID I'm not sure that replacing a flaky variable name with something that is essentially unintelligible is a huge improvement. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel