linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe_unused
@ 2020-03-06 12:56 Vincenzo Frascino
  2020-03-13 20:45 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Vincenzo Frascino @ 2020-03-06 12:56 UTC (permalink / raw)
  To: linux-arm-kernel, linux-kernel
  Cc: Andrew Lunn, Jason Cooper, Gregory Clement, Russell King,
	Vincenzo Frascino, Sebastian Hesselbarth

Without this, we get the warnings below when CONFIG_MMU is disabled:

linux/arch/arm/mach-dove/common.c:51:24: warning: ‘dove_io_desc’ defined
but not used [-Wunused-variable]
static struct map_desc dove_io_desc[] __initdata = {
                       ^~~~~~~~~~~~

Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Gregory Clement <gregory.clement@bootlin.com>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 arch/arm/mach-dove/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
index 01b830afcea9..dbe970e37895 100644
--- a/arch/arm/mach-dove/common.c
+++ b/arch/arm/mach-dove/common.c
@@ -48,7 +48,7 @@
 /*****************************************************************************
  * I/O Address Mapping
  ****************************************************************************/
-static struct map_desc dove_io_desc[] __initdata = {
+static struct map_desc __maybe_unused dove_io_desc[] __initdata = {
 	{
 		.virtual	= (unsigned long) DOVE_SB_REGS_VIRT_BASE,
 		.pfn		= __phys_to_pfn(DOVE_SB_REGS_PHYS_BASE),
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe_unused
  2020-03-06 12:56 [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe_unused Vincenzo Frascino
@ 2020-03-13 20:45 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2020-03-13 20:45 UTC (permalink / raw)
  To: Vincenzo Frascino, linux-arm-kernel, linux-kernel
  Cc: Russell King, Andrew Lunn, Vincenzo Frascino, Jason Cooper,
	Sebastian Hesselbarth

Vincenzo Frascino <vincenzo.frascino@arm.com> writes:

> Without this, we get the warnings below when CONFIG_MMU is disabled:
>
> linux/arch/arm/mach-dove/common.c:51:24: warning: ‘dove_io_desc’ defined
> but not used [-Wunused-variable]
> static struct map_desc dove_io_desc[] __initdata = {
>                        ^~~~~~~~~~~~
>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: Gregory Clement <gregory.clement@bootlin.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Applied on mvebu/arm

Thanks,

Gregory
> ---
>  arch/arm/mach-dove/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index 01b830afcea9..dbe970e37895 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -48,7 +48,7 @@
>  /*****************************************************************************
>   * I/O Address Mapping
>   ****************************************************************************/
> -static struct map_desc dove_io_desc[] __initdata = {
> +static struct map_desc __maybe_unused dove_io_desc[] __initdata = {
>  	{
>  		.virtual	= (unsigned long) DOVE_SB_REGS_VIRT_BASE,
>  		.pfn		= __phys_to_pfn(DOVE_SB_REGS_PHYS_BASE),
> -- 
> 2.25.1
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-13 20:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-06 12:56 [PATCH] arm: mach-dove: Mark dove_io_desc as __maybe_unused Vincenzo Frascino
2020-03-13 20:45 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).