From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A46DC43381 for ; Thu, 14 Mar 2019 02:36:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E27F020651 for ; Thu, 14 Mar 2019 02:36:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b/gQQovq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E27F020651 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brown.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:References:In-Reply-To:Subject:Date:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oh3/kuNNcjYelKyEFTeLTi/e9QqVV4pxTiIM43rEUzo=; b=b/gQQovqJ9oZ3O51hmzXfj4Jj h+SppDtl7EixsPB+1yNTx6Nygy6vv012qpDMayQH9u3hzbpfl66Yo0+aa4QcAbXLertPyBe6IMZNP Y7IXqZ6NzxUUilGIZjxvxchEdOFcRlP87uo42arkBeU88iNBGLf8hjMNH9ZXT0lNSCcJhXoqb1VlQ kEr/2ezW3qBRaT3BsETf7hFqn+BRhLIQmUlvzzCZJLajE8LYgWSxcY90mbf40UNvuouXGuGhlxjUm KFcWMFWstoOdg3sPhu3h/CxzqfMxGvm0SM/M1e9sWVaYnRCZ0y22v8sV+PEfITBr5EbBg+7Q4SAwY Rv7pOO+MA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4GES-0008Cf-FJ; Thu, 14 Mar 2019 02:36:32 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4GEP-0008CI-BO; Thu, 14 Mar 2019 02:36:31 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 89D00AF58; Thu, 14 Mar 2019 02:36:26 +0000 (UTC) From: NeilBrown To: Chuanhong Guo Date: Thu, 14 Mar 2019 13:36:11 +1100 Subject: Re: [PATCH] spi: mediatek: Attempt to address style issues in spi-mt7621.c In-Reply-To: References: <20190313122403.248873-1-armax@google.com> <4789d739-d2b5-357b-b9d8-bfaf587d33fc@gmail.com> <4172ce05-8dfc-c956-6af0-47c8367c215e@denx.de> <87y35ipgkt.fsf@notabene.neil.brown.name> Message-ID: <87mulyp4h0.fsf@notabene.neil.brown.name> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_193629_540540_6119D1EE X-CRM114-Status: UNSURE ( 9.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sankalpnegi2310@gmail.com, devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Armando Miraglia , Armando Miraglia , linux-mediatek@lists.infradead.org, John Crispin , Matthias Brugger , Stefan Roese , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0596382163828623937==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0596382163828623937== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Thu, Mar 14 2019, Chuanhong Guo wrote: > Hi! > On Thu, Mar 14, 2019 at 6:14 AM NeilBrown wrote: >> >> [...] >> My only small concern is that this driver was backported to openwrt >> (4.14 based) and then reverted >> >> https://github.com/openwrt/openwrt/commit/749a29f76ca780d8df70a5163d43bbdc6f13ba3f >> >> "This breaks some mt7621 devices." >> >> Possibly it was backported badly, or possibly there is a problem. > Last time I backported the version with broken SPI modes so it got > broken SPI CS1 support. There is one mt7621 router using SPI CS1 in > OpenWrt and the backported driver broke it. > It has been fixed by my two "drop broken spi modes" patches. Ahh, thanks for the clarification. Good to know all known problems are fixed. Thanks, NeilBrown >> >> John: do you have any more details of the problem other than what is in >> the commit message? >> >> Thanks, >> NeilBrown > > Regards, > Chuanhong Guo --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEG8Yp69OQ2HB7X0l6Oeye3VZigbkFAlyJvhwACgkQOeye3VZi gbnSyg/6A4cJK3Y6QVKHque374sHdHn+JkGuuP2+lNs/SQMknyXuHJiOQVWuJFh3 YthVDHhRodQM87ilVji48sJQEZoXkwC2mvglabGxL9ior1qGUYE01R3qp5OTcvZ9 UrMOJNILFKvfRh/u0ZcjntPj7DodjvkBFbJaWP96/PZQrrAMvjFlkYOVw/Bpnz8O sZR8dkp7jytaX10hnEgLM/vvE98j0igoY8dOXIgd45ZY28tHpRfRxVFvUZfeOtfD OcyaqtICFJaMcQOC1Ehfl/haems1rxNCaiJnQ/7ZJRpzz/pY16H7I9V1JxdS6oti zwLbhp7qQHtyRxYAdlAUE6H4krLYC/EsJVIgOdMZyVTKEIdF5FAmTnibnoz5LMOW RHVXRa93tgpKiANfM1suxjIA04HnpfSBwaCz/xmYOWjhRc5tkwYO57AaEdZA3AsQ b1vD68vQCqMTrP5KtbQNFGih0upuQG+7xHUVHLHBgTy4zMgzHofEodSHjSxaiY2U XLwcba3M92hO7z023P3vtLlgUhtOGsyJ1SFw/SxBaTUiv91kgQ5Kpg2FI5rxywXi LYO7k+u2p1Y9MD5iOFUHSMabselNGPIZ3hGSRUehtK0tlowelR1UU6sc2r0Nw+JM 3Mttp/kKuoYjC5l57kHzUWo8hjoOniCPFBn49O6tm5EI8wgOSww= =HXHg -----END PGP SIGNATURE----- --=-=-=-- --===============0596382163828623937== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0596382163828623937==--