From: jacmet@sunsite.dk (Peter Korsgaard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information
Date: Sun, 27 Jan 2013 15:11:14 +0100 [thread overview]
Message-ID: <87mwvubtrx.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1358999112-31192-5-git-send-email-rachna@ti.com> (Rachna Patil's message of "Thu, 24 Jan 2013 09:15:08 +0530")
>>>>> "P" == Patil, Rachna <rachna@ti.com> writes:
Hi,
P> From: "Patil, Rachna" <rachna@ti.com>
P> Signed-off-by: Patil, Rachna <rachna@ti.com>
P> ---
P> Changes in v4:
P> Subnodes and their properties documentation added.
P> Non-standard properties prefixed with vendor name.
P> .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 52 ++++++++++++++++++++
P> 1 file changed, 52 insertions(+)
P> create mode 100644 Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
P> diff --git a/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt b/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
P> new file mode 100644
P> index 0000000..0100771
P> --- /dev/null
P> +++ b/Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt
P> @@ -0,0 +1,52 @@
P> +Texas Instruments - TSC / ADC multi-functional device
P> +
P> +ti_tscadc is a multi-function device with touchscreen and ADC on chip.
P> +This document describes the binding for mfd device.
P> +
P> +Required properties:
P> +- compatible: "ti,ti-tscadc"
That's a very generic name (and double ti). How about ti,am3352-tsadc
instead?
No pinmux?
P> +Sub-node device required properties:
P> +tsc:
P> +- ti,wires: 4/5/8 wire touchscreen support on the platform.
P> +- ti,x-plate-resistance: X plate resistance.
In what kind of units?
P> +- ti,steps-to-configure: A step is configured to read a single co-ordinate value,
P> + can be applied more number of times for better results.
So it is some kind of averaging? Doesn't tslib do that for you already?
Is there any limit to how many steps you can/will handle?
P> +- ti,wire-config: Order for connecting wires on touchscreen.
ti,wires seems redundant given ti,wire-config (E.G. number of elements
in array). It is not clear to me what the magic values in wire-config
mean?
P> +
P> +adc:
P> +- ti,adc-channels: Number of ADC channels used.
Is there ever any use case for this being something else than 8 -
ti,wires?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2013-01-27 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 3:45 [PATCH v4 0/8] MFD: ti_am335x_tscadc: DT support and TSC features addition Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 1/8] input: ti_am335x_tsc: Step enable bits made configurable Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 2/8] input: ti_am335x_tsc: Order of TSC wires, " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 3/8] input: touchscreen: ti_tsc: remove unwanted fifo flush Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information Patil, Rachna
2013-01-27 14:11 ` Peter Korsgaard [this message]
2013-01-24 3:45 ` [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support Patil, Rachna
2013-01-30 10:40 ` Koen Kooi
2013-01-31 4:11 ` Patil, Rachna
2013-01-31 5:02 ` Hiremath, Vaibhav
2013-01-31 12:25 ` Patil, Rachna
2013-02-06 11:17 ` Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 6/8] input: ti_am335x_tsc: " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 7/8] IIO: ti_am335x_adc: " Patil, Rachna
2013-01-24 3:45 ` [PATCH v4 8/8] arm/dts: AM335x-evm: Add TSC/ADC MFD device support Patil, Rachna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwvubtrx.fsf@dell.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox