From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Thu, 17 May 2012 09:37:42 -0700 Subject: [PATCHv2 04/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode In-Reply-To: (Santosh Shilimkar's message of "Thu, 17 May 2012 14:22:52 +0530") References: <1336990730-26892-1-git-send-email-t-kristo@ti.com> <1336990730-26892-5-git-send-email-t-kristo@ti.com> <87d363928g.fsf@ti.com> Message-ID: <87mx56227d.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "Shilimkar, Santosh" writes: > On Thu, May 17, 2012 at 12:34 PM, Shilimkar, Santosh > wrote: >> On Thu, May 17, 2012 at 4:12 AM, Kevin Hilman wrote: >>> Tero Kristo writes: >>> >>>> From: Rajendra Nayak >>>> >>>> SAR/ROM code restores only CORE DPLL to its original state >>>> post wakeup from OFF mode. >>>> The rest of the DPLL's in OMAP4 platform (MPU/IVA/ABE/USB/PER) >>>> are saved and restored here during an OFF transition. >>>> >>>> [nm at ti.com: minor cleanups] >>>> Signed-off-by: Nishanth Menon >>>> Signed-off-by: Rajendra Nayak >>>> Signed-off-by: Santosh Shilimkar >>>> Signed-off-by: Tero Kristo >>> >>> Some general comments: >>> >>> - the register dump/print doesn't belong here. ?If needed, should be a >>> ?debug feature if needed. >>> >>> - Rather than hooking into omap4_enter_lowpower(), should use >>> ?the cluster PM enter/exit notifier chain. >>> >> This is again specific to device OFF only and not related to CPU >> cluster state as such. So I don't think notifiers should be used here. >> >> O.w even when we attempt just MPU OSWR C-state, all these functions will >> get called in notifier chain. >> > Just a thought, we can have a separate notifier chain for device OFF. It can > allow use to get rid of 'enable_off_mode" kind of flags and can be > used by many drivers too. Yes, I like this idea. It allows a much cleaner collection of all the activities needed for device off. Kevin