From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDA11C369C2 for ; Tue, 22 Apr 2025 21:21:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PnyFEj/s2sq/vR7wNkCzRRN7OhPe4Z9DMt070c1470Y=; b=G8acjM48rCS4psl4vRBWmRKV4i ucKUyYYxOLTCvlrZV1yjvgT9DAu+fX+HkNBnH/8m1OvkcmeARN080HQ+1bvQVL9bU5bUohy6qRUZi X3oOMCMNkpAjmIN9SemdTLafewMB4vhwFLgxL3MtfMEPfp5D6vXt29kIP+2eLpJxVj7HEYllUyEXI YdOSu1YYqJJqiZxnOKEhN+otEQ8oZuJD4JRacgHjom19wb15ngHm/1VwWHkVZLeTgkH6nGLYs8y1F KNB/l9zkNJkDoaA0gNhSPFZe+eLAd9h9bslW1l0/o8KNIZmghVcJuCKXhhsWux3PB1/ICK24lxwYk c2iWc6UA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7L3k-00000008ZV0-2yUu; Tue, 22 Apr 2025 21:21:40 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u7L1r-00000008ZHY-1vGX for linux-arm-kernel@lists.infradead.org; Tue, 22 Apr 2025 21:19:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 6CA9849E15; Tue, 22 Apr 2025 21:19:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B67ABC4CEE9; Tue, 22 Apr 2025 21:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745356782; bh=AeYw6rL1CJRFcnx2f29yVZ0cLCF3+3DhfJ5qUM0giNg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TzxMRdSLfuMubi7I8I9iHCx8D1lTR9Oxf8mPE/zZSYP8rycKMKVj74905WXVxRq5H +DAEEvqVX1Q2UIeQ9afLo2pZuG60EYPdcjbUeKGrVo+A4aGITPR4tNbMyl/2RV72Cx tgmu97uK34cJKDv33/PsvoO3CH6q2s+ckiqVaSQEC6UOdfQBC937JcEcP9ceWl7/dk /DazA+5OJ0/WGL1YNgWPxeljUS/sj5TpupXqVttSP65TJ3eYYRPfTG82dr6Sf9mAKK y3co5RjbAltTvyiVtB6xyP2NFmaHNwdTiRwvjd1hCcibb/k8OCXtU6SXF+Ba8nVBxY Sy4aVYBM96paA== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1u7L1o-007mKs-Dl; Tue, 22 Apr 2025 22:19:40 +0100 Date: Tue, 22 Apr 2025 22:19:48 +0100 Message-ID: <87o6wnyjuz.wl-maz@kernel.org> From: Marc Zyngier To: D Scott Phillips Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH 2/3] KVM: arm64: Teach address translation about access faults In-Reply-To: <86frhzyl19.fsf@scott-ph-mail.amperecomputing.com> References: <20250422122612.2675672-1-maz@kernel.org> <20250422122612.2675672-3-maz@kernel.org> <86frhzyl19.fsf@scott-ph-mail.amperecomputing.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: scott@os.amperecomputing.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250422_141943_523621_09C1E450 X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 22 Apr 2025 21:54:26 +0100, D Scott Phillips wrote: > > Marc Zyngier writes: > > > It appears that our S1 PTW is completely oblivious of access faults. > > Teach the S1 translation code about it. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/at.c | 26 +++++++++++++++++++++----- > > 1 file changed, 21 insertions(+), 5 deletions(-) > > > > diff --git a/arch/arm64/kvm/at.c b/arch/arm64/kvm/at.c > > index 3a4568e2de910..c40583edebc4f 100644 > > --- a/arch/arm64/kvm/at.c > > +++ b/arch/arm64/kvm/at.c > > @@ -456,6 +456,11 @@ static int walk_s1(struct kvm_vcpu *vcpu, struct s1_walk_info *wi, > > if (check_output_size(desc & GENMASK(47, va_bottom), wi)) > > goto addrsz; > > > > + if (!(desc & PTE_AF)) { > > Shouldn't this depend on TCR_ELx.HA == 0? Which is so far the only supported configuration for a guest under NV. M. -- Jazz isn't dead. It just smells funny.