* [PATCH] arm64: kvm: ptdump: Initialize .owner fields of kvm_*_operations
@ 2025-02-23 15:08 Salah Triki
2025-02-23 18:21 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2025-02-23 15:08 UTC (permalink / raw)
To: Marc Zyngier, Oliver Upton, Joey Gouly, Suzuki K Poulose,
Zenghui Yu, Catalin Marinas, Will Deacon, linux-arm-kernel,
kvmarm, linux-kernel
Cc: Salah Triki
Initialize .owner fields of kvm_ptdump_guest_fops,
kvm_pgtable_range_fops and kvm_pgtable_levels_fops to THIS_MODULE in
order to prevent unloading the module while these operations are still
in use.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
arch/arm64/kvm/ptdump.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/kvm/ptdump.c b/arch/arm64/kvm/ptdump.c
index e4a342e903e2..50f7d39333d6 100644
--- a/arch/arm64/kvm/ptdump.c
+++ b/arch/arm64/kvm/ptdump.c
@@ -185,6 +185,7 @@ static int kvm_ptdump_guest_close(struct inode *m, struct file *file)
}
static const struct file_operations kvm_ptdump_guest_fops = {
+ .owner = THIS_MODULE,
.open = kvm_ptdump_guest_open,
.read = seq_read,
.llseek = seq_lseek,
@@ -244,6 +245,7 @@ static int kvm_pgtable_debugfs_close(struct inode *m, struct file *file)
}
static const struct file_operations kvm_pgtable_range_fops = {
+ .owner = THIS_MODULE,
.open = kvm_pgtable_range_open,
.read = seq_read,
.llseek = seq_lseek,
@@ -251,6 +253,7 @@ static const struct file_operations kvm_pgtable_range_fops = {
};
static const struct file_operations kvm_pgtable_levels_fops = {
+ .owner = THIS_MODULE,
.open = kvm_pgtable_levels_open,
.read = seq_read,
.llseek = seq_lseek,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: kvm: ptdump: Initialize .owner fields of kvm_*_operations
2025-02-23 15:08 [PATCH] arm64: kvm: ptdump: Initialize .owner fields of kvm_*_operations Salah Triki
@ 2025-02-23 18:21 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2025-02-23 18:21 UTC (permalink / raw)
To: Salah Triki
Cc: Oliver Upton, Joey Gouly, Suzuki K Poulose, Zenghui Yu,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm,
linux-kernel
On Sun, 23 Feb 2025 15:08:44 +0000,
Salah Triki <salah.triki@gmail.com> wrote:
>
> Initialize .owner fields of kvm_ptdump_guest_fops,
> kvm_pgtable_range_fops and kvm_pgtable_levels_fops to THIS_MODULE in
> order to prevent unloading the module while these operations are still
> in use.
Colour me curious, but what module are we talking about here?
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-23 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-23 15:08 [PATCH] arm64: kvm: ptdump: Initialize .owner fields of kvm_*_operations Salah Triki
2025-02-23 18:21 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).