From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96155C47DD9 for ; Fri, 22 Mar 2024 13:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Df1ypDbBgmohZBEmANrxSja0Vy2bzpuMIlsDW2PdaPs=; b=gb55e7T4DDsYrl n9z53U0wKO6jbb8Dc6/hJo+uXWlfcPQZsPpiRs+Un4ncfLs6BhiJhUdn6X9oUM7pgQAcULhSlGHqm TseOS1gI10CBbHyoeFzV+RkWjT/iXxKnfv99vS17oy967FD1vcYPxVq4j2JsjbdWSCMxn+KXyTCKK VB2Y1oxuMy8Tvr5OvvQdxPhh1g/cxOTOrKQdui3fCal8OkzKgLO3dCbAnKh5uq2o/1M0VtaOMXyOL kMgxhh5IHzgXRn8/02zm9cacLR2bpDv58PswBDKp2h9ZUAeSW76eyE8rsxL3f7e/zn8A3BN5dqTJm uZhzaXZCTPVizo+zhXCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnf4e-00000007MIm-3Hdm; Fri, 22 Mar 2024 13:36:45 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnf4a-00000007MEc-035Q; Fri, 22 Mar 2024 13:36:42 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id C978C1C0005; Fri, 22 Mar 2024 13:36:29 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1rnf4P-005ytU-0d; Fri, 22 Mar 2024 14:36:29 +0100 From: Peter Korsgaard To: Arnd Bergmann Cc: Vinod Koul , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Nathan Chancellor , Arnd Bergmann , Nick Desaulniers , Bill Wendling , Justin Stitt , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Randy Dunlap , Rob Herring , Zhang Jianhua , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] dmaengine: owl: fix register access functions References: <20240322132116.906475-1-arnd@kernel.org> Date: Fri, 22 Mar 2024 14:36:29 +0100 In-Reply-To: <20240322132116.906475-1-arnd@kernel.org> (Arnd Bergmann's message of "Fri, 22 Mar 2024 14:21:07 +0100") Message-ID: <87o7b62xsy.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-GND-Sasl: peter@korsgaard.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_063640_252829_392EC2A3 X-CRM114-Status: UNSURE ( 9.46 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>>>> "Arnd" == Arnd Bergmann writes: > From: Arnd Bergmann > When building with 'make W=1', clang notices that the computed register > values are never actually written back but instead the wrong variable > is set: > drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 244 | u32 regval; > | ^ > drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable] > 268 | u32 regval; > | ^ > Change these to what was most likely intended. > Fixes: 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver") > Signed-off-by: Arnd Bergmann Good catch! Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel