From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6924EB64DA for ; Wed, 5 Jul 2023 09:04:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VLgrlx1BjJfzzNtkl8t8a+uv/bMzjUM7P+ePGCN7bYM=; b=292n32AXCS2A0m AzOSrj3MlFg/4c0iXKqMktHXKhJ+tE0bmoI8dksb9JMmExqGWobrVKI+NZBNhfcAgWH/u0pG5J7aY 7KtSDhxTDl4DBQ9qfmSfSohq6/H/pXk2E1idNLNarpZ07fUw4phqzIGiqqueWwyJqA/ObyJ4G+/IH np9pXnE+Ta9eH+W+BdsSqyS0tcTkD1ke4JTrIlhVSYhRdNV2VsiVgus7/dlJHiTGuvk9xb3v+9qIA DZXSV+4GHGBkugjjqDShIizlYeXBkCo+RTm9o3YS5/xZrtYusi80T6JaHIzJKW5te5XPe4sPRhhTN IT513XZUY6j4WUbzQBvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGyQ9-00FIel-26; Wed, 05 Jul 2023 09:03:33 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGyQ6-00FIck-2F for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 09:03:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688547806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rSX7qOujOrm27lX5ys/0lBz1p5bJBCSZMCXRlfpyvEg=; b=SmT7tqIpuSEK+ZvkAidlYZ5xLxYMZugQ1LVCsYbAx/ULgD7zNCXS+9Pz9ZItk7vlMCftgM 29xBxrL2N0wgGvXdPgLENWVw2/fxNKzNjhPMotshD8MXT3S1F5/xClSK1+33e49c4JrsXo ydicBW4mqyzQt1nmqwrThQiS95SU0tg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-mv3FoNouPJe_yXqkiZtuLQ-1; Wed, 05 Jul 2023 05:03:23 -0400 X-MC-Unique: mv3FoNouPJe_yXqkiZtuLQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbab56aac7so40434575e9.1 for ; Wed, 05 Jul 2023 02:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688547802; x=1691139802; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rSX7qOujOrm27lX5ys/0lBz1p5bJBCSZMCXRlfpyvEg=; b=XykbvRbvrHKx9uFSvG2u5XqCUtuk3gCwqmAU7i+QklznOjJO4NTlsdPxrM4sDhVD8X sBaATwIp4O8j83AZRBUW2srK87dZwYtZpM7eksckZDQDUdOsbjoENpV7/TGUJ7AyKjkd gXhwhSd3w/lwvZc2gJUAy02wWoBlaK8Hu7wxeaMMXujfymQUmLhjKWU5yEgKlmg9rY/2 rLXyU+61iye2xZv3h3NkfRb9KXl+l0rvKKHl+57x5kl9mleebcODD6Mj0Is3Sbo9HwDe nE0uHNiBNkaGgMdl7DOInFRrBtceV67CnypEqdwKd3QN81VYmMNP8se21+A1bIl2oEh7 tuSA== X-Gm-Message-State: AC+VfDxs1D3ivL2iwJGf+Iq8E8JPuNEAZhqTB0xRQJdeS6Uk84clSTAu yYlwqTOJUnIrZ9W9xUufQvXrGajBBCm9ChsJKfo1u0itU+8JKsQMYv/QhyWCFSojcmIyeKa4hCi AL1PVDLK4fe1jEgBqAhh5jDfJLKcxA254uD4= X-Received: by 2002:a1c:f314:0:b0:3fb:adc0:609b with SMTP id q20-20020a1cf314000000b003fbadc0609bmr14653348wmq.13.1688547802464; Wed, 05 Jul 2023 02:03:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4D75aEjUYAXwEsqp9EVXq6EMXjhrEVDhsSnE0141Cb1WbjzG1CyfPykxapyYpYnd68hWU11g== X-Received: by 2002:a1c:f314:0:b0:3fb:adc0:609b with SMTP id q20-20020a1cf314000000b003fbadc0609bmr14653330wmq.13.1688547802102; Wed, 05 Jul 2023 02:03:22 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id m11-20020a7bce0b000000b003f90b9b2c31sm1507833wmc.28.2023.07.05.02.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 02:03:21 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH 07/10] drm/omapdrm: Set VM flags in GEM-object mmap function In-Reply-To: <20230704160133.20261-8-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-8-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 11:03:21 +0200 Message-ID: <87o7kqraqu.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_020330_808518_29069DB8 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Use the mmap callback in struct drm_gem_object_funcs to set the > VM flags. Replace a number of mmap helpers in omapdrm with their > GEM helper counterparts. Generate DRM's file-operations instance > with GEM's DEFINE_DRM_GEM_FOPS. > > Signed-off-by: Thomas Zimmermann > Cc: Tomi Valkeinen > --- > +static int omap_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma) > { > struct omap_gem_object *omap_obj = to_omap_bo(obj); > > - vm_flags_mod(vma, VM_MIXEDMAP, VM_PFNMAP); > + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP | VM_IO | VM_MIXEDMAP); > > if (omap_obj->flags & OMAP_BO_WC) { > vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); > @@ -563,12 +548,14 @@ int omap_gem_mmap_obj(struct drm_gem_object *obj, > * address_space (so unmap_mapping_range does what we want, > * in particular in the case of mmap'd dmabufs) > */ > - vma->vm_pgoff = 0; > + vma->vm_pgoff -= drm_vma_node_start(&obj->vma_node); > vma_set_file(vma, obj->filp); > > vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); > } > > + vma->vm_page_prot = pgprot_decrypted(vma->vm_page_prot); > + > return 0; > } > I think this rework deserves a more elaborated commit message. Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel