* [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks
2022-06-14 20:28 [PATCH V2 0/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
@ 2022-06-14 20:28 ` Stefan Wahren
2022-06-25 23:04 ` Linus Walleij
2022-06-14 20:28 ` [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
2022-06-15 6:04 ` [PATCH V2 0/2] " Marc Zyngier
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2022-06-14 20:28 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Florian Fainelli, Ray Jui,
Scott Branden, Marc Zyngier
Cc: Maxime Ripard, Phil Elwell, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, Stefan Wahren
The commit b8a19382ac62 ("pinctrl: bcm2835: Fix support for threaded level
triggered IRQs") assigned the irq_mask/unmask callbacks with the
already existing functions for irq_enable/disable. The wasn't completely
the right way (tm) to fix the issue, because these callbacks shouldn't
be identical. So fix this by rename the functions to represent their
intension and drop the unnecessary irq_enable/disable assigment.
Suggested-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index dad453054776..807824bc9a10 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -507,7 +507,7 @@ static void bcm2835_gpio_irq_config(struct bcm2835_pinctrl *pc,
}
}
-static void bcm2835_gpio_irq_enable(struct irq_data *data)
+static void bcm2835_gpio_irq_unmask(struct irq_data *data)
{
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
struct bcm2835_pinctrl *pc = gpiochip_get_data(chip);
@@ -522,7 +522,7 @@ static void bcm2835_gpio_irq_enable(struct irq_data *data)
raw_spin_unlock_irqrestore(&pc->irq_lock[bank], flags);
}
-static void bcm2835_gpio_irq_disable(struct irq_data *data)
+static void bcm2835_gpio_irq_mask(struct irq_data *data)
{
struct gpio_chip *chip = irq_data_get_irq_chip_data(data);
struct bcm2835_pinctrl *pc = gpiochip_get_data(chip);
@@ -695,12 +695,10 @@ static int bcm2835_gpio_irq_set_wake(struct irq_data *data, unsigned int on)
static struct irq_chip bcm2835_gpio_irq_chip = {
.name = MODULE_NAME,
- .irq_enable = bcm2835_gpio_irq_enable,
- .irq_disable = bcm2835_gpio_irq_disable,
.irq_set_type = bcm2835_gpio_irq_set_type,
.irq_ack = bcm2835_gpio_irq_ack,
- .irq_mask = bcm2835_gpio_irq_disable,
- .irq_unmask = bcm2835_gpio_irq_enable,
+ .irq_mask = bcm2835_gpio_irq_mask,
+ .irq_unmask = bcm2835_gpio_irq_unmask,
.irq_set_wake = bcm2835_gpio_irq_set_wake,
.flags = IRQCHIP_MASK_ON_SUSPEND,
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks
2022-06-14 20:28 ` [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks Stefan Wahren
@ 2022-06-25 23:04 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-06-25 23:04 UTC (permalink / raw)
To: Stefan Wahren
Cc: Bartosz Golaszewski, Florian Fainelli, Ray Jui, Scott Branden,
Marc Zyngier, Maxime Ripard, Phil Elwell,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel
On Tue, Jun 14, 2022 at 10:29 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The commit b8a19382ac62 ("pinctrl: bcm2835: Fix support for threaded level
> triggered IRQs") assigned the irq_mask/unmask callbacks with the
> already existing functions for irq_enable/disable. The wasn't completely
> the right way (tm) to fix the issue, because these callbacks shouldn't
> be identical. So fix this by rename the functions to represent their
> intension and drop the unnecessary irq_enable/disable assigment.
>
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable
2022-06-14 20:28 [PATCH V2 0/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
2022-06-14 20:28 ` [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks Stefan Wahren
@ 2022-06-14 20:28 ` Stefan Wahren
2022-06-25 23:05 ` Linus Walleij
2022-06-15 6:04 ` [PATCH V2 0/2] " Marc Zyngier
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2022-06-14 20:28 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Florian Fainelli, Ray Jui,
Scott Branden, Marc Zyngier
Cc: Maxime Ripard, Phil Elwell, bcm-kernel-feedback-list, linux-gpio,
linux-arm-kernel, Stefan Wahren
Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as
immutable") added a warning to indicate if the gpiolib is altering the
internals of irqchips. The bcm2835 pinctrl is also affected by this
warning.
Fix this by making the irqchip in the bcm2835 pinctrl driver immutable.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 807824bc9a10..7857e612a100 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -516,6 +516,8 @@ static void bcm2835_gpio_irq_unmask(struct irq_data *data)
unsigned bank = GPIO_REG_OFFSET(gpio);
unsigned long flags;
+ gpiochip_enable_irq(chip, gpio);
+
raw_spin_lock_irqsave(&pc->irq_lock[bank], flags);
set_bit(offset, &pc->enabled_irq_map[bank]);
bcm2835_gpio_irq_config(pc, gpio, true);
@@ -537,6 +539,8 @@ static void bcm2835_gpio_irq_mask(struct irq_data *data)
bcm2835_gpio_set_bit(pc, GPEDS0, gpio);
clear_bit(offset, &pc->enabled_irq_map[bank]);
raw_spin_unlock_irqrestore(&pc->irq_lock[bank], flags);
+
+ gpiochip_disable_irq(chip, gpio);
}
static int __bcm2835_gpio_irq_set_type_disabled(struct bcm2835_pinctrl *pc,
@@ -693,14 +697,15 @@ static int bcm2835_gpio_irq_set_wake(struct irq_data *data, unsigned int on)
return ret;
}
-static struct irq_chip bcm2835_gpio_irq_chip = {
+static const struct irq_chip bcm2835_gpio_irq_chip = {
.name = MODULE_NAME,
.irq_set_type = bcm2835_gpio_irq_set_type,
.irq_ack = bcm2835_gpio_irq_ack,
.irq_mask = bcm2835_gpio_irq_mask,
.irq_unmask = bcm2835_gpio_irq_unmask,
.irq_set_wake = bcm2835_gpio_irq_set_wake,
- .flags = IRQCHIP_MASK_ON_SUSPEND,
+ .flags = (IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE),
+ GPIOCHIP_IRQ_RESOURCE_HELPERS,
};
static int bcm2835_pctl_get_groups_count(struct pinctrl_dev *pctldev)
@@ -1278,7 +1283,7 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev)
pinctrl_add_gpio_range(pc->pctl_dev, &pc->gpio_range);
girq = &pc->gpio_chip.irq;
- girq->chip = &bcm2835_gpio_irq_chip;
+ gpio_irq_chip_set_chip(girq, &bcm2835_gpio_irq_chip);
girq->parent_handler = bcm2835_gpio_irq_handler;
girq->num_parents = BCM2835_NUM_IRQS;
girq->parents = devm_kcalloc(dev, BCM2835_NUM_IRQS,
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable
2022-06-14 20:28 ` [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
@ 2022-06-25 23:05 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2022-06-25 23:05 UTC (permalink / raw)
To: Stefan Wahren
Cc: Bartosz Golaszewski, Florian Fainelli, Ray Jui, Scott Branden,
Marc Zyngier, Maxime Ripard, Phil Elwell,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel
On Tue, Jun 14, 2022 at 10:29 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Commit 6c846d026d49 ("gpio: Don't fiddle with irqchips marked as
> immutable") added a warning to indicate if the gpiolib is altering the
> internals of irqchips. The bcm2835 pinctrl is also affected by this
> warning.
>
> Fix this by making the irqchip in the bcm2835 pinctrl driver immutable.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Patch applied.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 0/2] pinctrl: bcm2835: Make the irqchip immutable
2022-06-14 20:28 [PATCH V2 0/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
2022-06-14 20:28 ` [PATCH V2 1/2] pinctrl: bcm2835: drop irq_enable/disable callbacks Stefan Wahren
2022-06-14 20:28 ` [PATCH V2 2/2] pinctrl: bcm2835: Make the irqchip immutable Stefan Wahren
@ 2022-06-15 6:04 ` Marc Zyngier
2 siblings, 0 replies; 6+ messages in thread
From: Marc Zyngier @ 2022-06-15 6:04 UTC (permalink / raw)
To: Stefan Wahren
Cc: Linus Walleij, Bartosz Golaszewski, Florian Fainelli, Ray Jui,
Scott Branden, Maxime Ripard, Phil Elwell,
bcm-kernel-feedback-list, linux-gpio, linux-arm-kernel
On Tue, 14 Jun 2022 21:28:29 +0100,
Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
> This small series makes the irqchip in the bcm2835 pinctrl driver immutable.
>
> Changes in V2:
> - add patch to drop irq_enable/disable callbacks as suggested by Marc
> - add missing GPIOCHIP_IRQ_RESOURCE_HELPERS found by Marc
>
> Stefan Wahren (2):
> pinctrl: bcm2835: drop irq_enable/disable callbacks
> pinctrl: bcm2835: Make the irqchip immutable
>
> drivers/pinctrl/bcm/pinctrl-bcm2835.c | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
For the series:
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread