From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5841EC433F5 for ; Tue, 12 Apr 2022 10:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qZp42lPFCJHiE3HgzIhSsfgl9F3eJrdKwBkuVqayY4E=; b=FHtB+fGXRIwaG/ jyyWkG1XyN2pTaKOeI37JwDWzPD6P/4er0AtTGNiUu5btLhXfabOmWbeTJrgUslrHhoPTkv9eLiTr cBCr2s8mGxPngnYWwTZonerBr6B/cV2tXk/8KKNcYS4BRgosU0QnFBszlJ4Ocpma5Ma3cVuShH/W1 fXN6Ca4BejjO94kYM+Y0ZeOa7dgNENgTtsjklSjOhnMGHpzagXX/yNh3E3tqiE/qFaI7e53LuZLrz houBLhueCrTfBwm8dp8eRU56tQIDGeOMOwF/rDSAj6YS20VRK4ViM1I3jXPTiFl6BTaWABCVJVvZF v6bv4VjkJ5K4xJEBuxTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDtV-00DLLi-EJ; Tue, 12 Apr 2022 10:37:09 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neDtR-00DLJU-D5; Tue, 12 Apr 2022 10:37:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D173BB81CA1; Tue, 12 Apr 2022 10:37:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0CB0C385A9; Tue, 12 Apr 2022 10:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1649759822; bh=aW4x6amHzum00rDQPT0FUG+ggRroUKbynU3+mFAMVMs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=qA+nHcZTf76+eD7wAm4dguMty2X7Md0r/KunP1VnoFC53/YPOSJyFrJRjRb1C6Os/ i77YGzYijefmhXDTFLslXAKRS7T2NiScf7dO4p60+AswhP8uWewlnKa/Up6uG3pNq+ dnOGUKfms80yp8RYw5UlMXDllY8DOMX7hUiEW6kESVrVdaJNe61vTUNQubYMBQ9H5+ a9+jCxp3Pa7OqtWH+p8q87XlwbsgDcoN+RiYFKb/SeB4wqrph9EZl15pKyxMalpeND BaS9myYIVHQQfIzqcrUIWj3I1U3qRBz2Qi4XFNlbIRp3hOIYZkm+qEsoLy6gpgDpGV IYMdLHZ7etrSA== From: Kalle Valo To: Thorsten Leemhuis Cc: Philippe Schenker , linux-wireless@vger.kernel.org, Felix Fietkau , "David S. Miller" , Deren Wu , Jakub Kicinski , Lorenzo Bianconi , Matthias Brugger , Paolo Abeni , Ryder Lee , Sean Wang , Shayne Chen , YN Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, "regressions\@lists.linux.dev" Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default" References: <20220412090415.17541-1-dev@pschenker.ch> <87y20aod5d.fsf@kernel.org> <7aa0bbd0-5498-ba74-ad6d-6dacbade8a3d@leemhuis.info> Date: Tue, 12 Apr 2022 13:36:52 +0300 In-Reply-To: <7aa0bbd0-5498-ba74-ad6d-6dacbade8a3d@leemhuis.info> (Thorsten Leemhuis's message of "Tue, 12 Apr 2022 11:55:13 +0200") Message-ID: <87o816oaez.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_033705_778986_4B58D26C X-CRM114-Status: GOOD ( 19.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thorsten Leemhuis writes: > On 12.04.22 11:37, Kalle Valo wrote: >> Philippe Schenker writes: >> >>> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8. >>> >>> This commit introduces a regression on some systems where the kernel is >>> crashing in different locations after a reboot was issued. >>> >>> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware. >>> >>> Link: >>> https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/ >>> Signed-off-by: Philippe Schenker >> >> Can I take this to wireless tree? Felix, ack? >> >> I'll also add: >> >> Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default") > > Sorry, stupid questions from the regression tracker: wouldn't this cause > a regression for users of kernel versions post-bf3747ae2e25, as the > power consumption is likely to increase for them? Without having dug > into the backstory much: would disabling ASPM for this particular > machine using a quirk be the better approach? Or are we assuming a lot > of machines are affected? > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of > reports on my table. I can only look briefly into most of them and lack > knowledge about most of the areas they concern. I thus unfortunately > will sometimes get things wrong or miss something important. I hope > that's not the case here; if you think it is, don't hesitate to tell me > in a public reply, it's in everyone's interest to set the public record > straight. BTW, maybe you could add that boilerplace text after P.S. into the signature (ie. under "-- " line)? That way your mails would more readable and make it more clear that you didn't write the boilerplate text specifically for this mail. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel