From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E39C433B4 for ; Tue, 18 May 2021 11:59:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA93761042 for ; Tue, 18 May 2021 11:59:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA93761042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YcLEt6fmzHOk+5DTIb9tXLNBqVw2qKwh9kH3v+uIMlY=; b=TG4k4fBvj3JR65gRrqOziMosV dBvt348Wr9zoehfvKnc+0W0W1IxPBNdYHymAmRg9VqmBAsKECnxloN1hcmlfaS+tHC3QwVche19nc Qku4T8VqcVG9oIRelacI0Zy1UMS5xAgKzpelGW/wKgQJis3bfNxx60NlwZj2RPvE2QoAbSrDbUNAu 3/Nj6AvaM2O7WvqKEoVSMoCVGNiFl4KnzmrFUL2VoZKoBYDH0b3XH3m+gRfSusiiJ6rMNr6QCuwPN xcAIXvTEk5Pf51h9PiwNIBpgSVMzK8Pl/lO+P8rydUs94jj+HGSnPUEVBwDex2Ohh1iDlqBeIwOFo aN44Zx6/Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liyMB-000gZS-VX; Tue, 18 May 2021 11:57:52 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liyLn-000gUP-RA for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 11:57:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e15OfA/KUgF3TfsvcQVeFqTF1bdikrYyZYvCJFX8AI4=; b=xjQsaqUlof1XaT8yEd4DEkaW5V cAK3oVQT1FEVgXq1VAdB6XaKl0v0qfVsIsQlvEW8wcAQOus58ExIlpTpTvmToFoaJEi/+yxEyGbOe N4yWUP7FrlPN5pyV5S+j3CyPAnceK6D2dc1OwBFi69uiSsmkOqXapPulw4Wx+EcAnW9DTObvt5Fl6 N0P44yet2jxS4p76hgY9ulPu4RFOLRrLg4ZhHZEb0UyFXnIKayUVoJfE0fh8jyMoyyM5+TX8iDGJF NWUHgT4xz9a1HQe4XEsBx9yoLQ350UcgV5Sa1PRRcgrPQjaCHe6UAJytgaeV4ZUhHws004tNdEcHk fkkvPv2A==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liyLl-00EcrI-9E for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 11:57:26 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0296161042; Tue, 18 May 2021 11:57:25 +0000 (UTC) Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1liyLi-00241E-SN; Tue, 18 May 2021 12:57:23 +0100 Date: Tue, 18 May 2021 12:57:20 +0100 Message-ID: <87o8d8tftr.wl-maz@kernel.org> From: Marc Zyngier To: Auger Eric Cc: Paolo Bonzini , Alexander Graf , Alexandru Elisei , Andrew Scull , Catalin Marinas , Christoffer Dall , David Brazdil , Gavin Shan , James Morse , Mark Rutland , Peng Hao , Quentin Perret , Will Deacon , Julien Thierry , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 15/56] KVM: arm64: Add build rules for separate VHE/nVHE object files In-Reply-To: <5d1853ed-3474-edbc-545a-1f88f2a4e5ca@redhat.com> References: <20200805175700.62775-1-maz@kernel.org> <20200805175700.62775-16-maz@kernel.org> <2ff3a1cb-a310-7963-4171-bd1e7d08e39b@redhat.com> <5d1853ed-3474-edbc-545a-1f88f2a4e5ca@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: eric.auger@redhat.com, pbonzini@redhat.com, graf@amazon.com, alexandru.elisei@arm.com, ascull@google.com, catalin.marinas@arm.com, christoffer.dall@arm.com, dbrazdil@google.com, gshan@redhat.com, james.morse@arm.com, mark.rutland@arm.com, richard.peng@oppo.com, qperret@google.com, will@kernel.org, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_045725_381032_8FE46C5D X-CRM114-Status: GOOD ( 20.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eric, On Tue, 18 May 2021 12:48:41 +0100, Auger Eric wrote: > > Hi David, Marc, > [...] > >> --- a/scripts/kallsyms.c > >> +++ b/scripts/kallsyms.c > >> @@ -109,6 +109,7 @@ static bool is_ignored_symbol(const char *name, char type) > >> ".LASANPC", /* s390 kasan local symbols */ > >> "__crc_", /* modversions */ > >> "__efistub_", /* arm64 EFI stub namespace */ > >> + "__kvm_nvhe_", /* arm64 non-VHE KVM namespace */ > > The addition of this line seems to have introduced errors on the > > 'vmlinux symtab matches kallsyms' perf test (perf test -v 1) which fails > > on aarch64 for all __kvm_nvhe_ prefixed symbols, like > > > > ERR : : __kvm_nvhe___invalid not on kallsyms > > ERR : : __kvm_nvhe___do_hyp_init not on kallsyms > > ERR : : __kvm_nvhe___kvm_handle_stub_hvc not on kallsyms > > ERR : : __kvm_nvhe_reset not on kallsyms > > ../.. > > > > I understand we willingly hided those symbols from /proc/kallsyms. Do > > you confirm the right fix is to upgrade the perf test suite accordingly? > > Were you eventually able to reproduce? Unfortunately not, I always end-up with the test failing even if I add the symbols back. I must be doing something wrong... M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel