From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C09DDC32750 for ; Tue, 13 Aug 2019 21:21:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 935CA2084D for ; Tue, 13 Aug 2019 21:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GLFMv0Qb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 935CA2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V1xv9oFM2mpLHhFFQxfIoQL+OywtKhnyjs5aq8RiJsc=; b=GLFMv0Qbp/dFHR z6PghCJeo4FBi1x4Sbwq7JyTQZ7SxzTzpVTNC2/4krAbKIv01JX+xtE4iDMuqqXIEq4zPAP21K39B MLw/OMhnABEEFNDgbnaiO060C6TFVW/xpQJDXvEFizrnlnUrPmgNWbj8suSgBibSJ8a8sDrLfNuYK hNm2Ou8eELpmqYTn39nbQmZBqXFVuMjL/rcxI4jVCQmNSYIPqRyQnHst13jZAD1S+e0CadIUlbEaQ CMdJBmGqJ1Fg5k5PLmV59PPC6kN0UFfd0n3uqn3P0Jl55MMuUnnCD0pmZZTAydsESGNaPfMwY+jy5 BRLY4uNAmOYWB8fZDHmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxeEF-00051X-J5; Tue, 13 Aug 2019 21:21:15 +0000 Received: from smtp04.smtpout.orange.fr ([80.12.242.126] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxeEC-00050I-1l for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 21:21:13 +0000 Received: from belgarion ([90.76.53.202]) by mwinf5d80 with ME id olM4200044MlyVm03lM4ry; Tue, 13 Aug 2019 23:21:07 +0200 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Tue, 13 Aug 2019 23:21:07 +0200 X-ME-IP: 90.76.53.202 From: Robert Jarzmik To: Greg Kroah-Hartman Subject: Re: [PATCH 4/6] dma: pxa_dma: no need to check return value of debugfs_create functions References: <20190612122557.24158-1-gregkh@linuxfoundation.org> <20190612122557.24158-4-gregkh@linuxfoundation.org> <87tvaorfc1.fsf@belgarion.home> <20190811070350.GA28202@kroah.com> X-URL: http://belgarath.falguerolles.org/ Date: Tue, 13 Aug 2019 23:21:04 +0200 In-Reply-To: <20190811070350.GA28202@kroah.com> (Greg Kroah-Hartman's message of "Sun, 11 Aug 2019 09:03:50 +0200") Message-ID: <87o90srccf.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_142112_389102_22628A34 X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Haojian Zhuang , vkoul@kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Greg Kroah-Hartman writes: > On Sat, Aug 10, 2019 at 09:27:26PM +0200, Robert Jarzmik wrote: >> Greg Kroah-Hartman writes: >> >> This is not strictly equivalent. >> Imagine that the debugfs_create_dir() fails and returns NULL : > How can that happen? Well in v5.0-rc1 that could happen ... unfortunately that's also the code I checked ... >> - in the former case, neither "state", "descriptors" nor "requesters" would be >> created >> - in the new code, "state", "descriptors" nor "requesters" will be created in >> the debugfs root directory > > I agree, but debugfs_create_dir() does not return a NULL on an error > since many kernel releases. Neither can debugfs_create_file() so really > this test is not working at all as-is :) Ah yes, you're right, I wasn't aware of the debugfs changes ... But checking a bit further, your original mail is 2 monthes old, and this patch was already merged in v5.2. I probably fell in a time-space anomaly, as I received this mail only a couple of days ago. Have a nice day. -- Robert _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel