[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Baruch Siach]

The SolidRun Armada 388 SOM has the SPI flash populated by default
unless the customer explicitly asks otherwise. Enable support by
default.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
index 2d1cea131e71..c990d502d9a4 100644
--- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
+++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
@@ -99,7 +99,6 @@
 		compatible = "w25q32", "jedec,spi-nor";
 		reg = <0>; /* Chip select 0 */
 		spi-max-frequency = <3000000>;
-		status = "disabled";
 	};
 };
 
-- 
2.18.0

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Baruch Siach]

The current device-tree description of the SolidRun Armada 38x platforms
has been successfully tested with production systems.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/armada-388-clearfog-base.dts      | 5 -----
 arch/arm/boot/dts/armada-388-clearfog-pro.dts       | 5 -----
 arch/arm/boot/dts/armada-388-clearfog.dts           | 5 -----
 arch/arm/boot/dts/armada-388-clearfog.dtsi          | 5 -----
 arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 5 -----
 5 files changed, 25 deletions(-)

diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts
index 50ed4ae5c621..53b4bd35522a 100644
--- a/arch/arm/boot/dts/armada-388-clearfog-base.dts
+++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Base revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 /dts-v1/;
diff --git a/arch/arm/boot/dts/armada-388-clearfog-pro.dts b/arch/arm/boot/dts/armada-388-clearfog-pro.dts
index 24e4b5a509be..ff890c09c3ed 100644
--- a/arch/arm/boot/dts/armada-388-clearfog-pro.dts
+++ b/arch/arm/boot/dts/armada-388-clearfog-pro.dts
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 #include "armada-388-clearfog.dts"
 
diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
index 5fd0f6f61e77..32b1e09b8293 100644
--- a/arch/arm/boot/dts/armada-388-clearfog.dts
+++ b/arch/arm/boot/dts/armada-388-clearfog.dts
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 /dts-v1/;
diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
index 0d9dfdfe977e..1da40bdfcef1 100644
--- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
+++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
@@ -3,11 +3,6 @@
  * Device Tree include file for SolidRun Clearfog 88F6828 based boards
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 #include "armada-388.dtsi"
diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
index c990d502d9a4..3a7f9c1ac346 100644
--- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
+++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Armada 38x Microsom
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/gpio/gpio.h>
-- 
2.18.0

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Andrew Lunn]

On Thu, Jun 28, 2018 at 10:13:36AM +0300, Baruch Siach wrote:
> The current device-tree description of the SolidRun Armada 38x platforms
> has been successfully tested with production systems.

Hi Baruch

For a change link this, we should have an acknowledgement from
SolidRun, or maybe Russell King.

	  Andrew

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Jon Nettleton]

On Thu, Jun 28, 2018 at 11:23 AM Andrew Lunn <andrew@lunn.ch> wrote:
>
> On Thu, Jun 28, 2018 at 10:13:36AM +0300, Baruch Siach wrote:
> > The current device-tree description of the SolidRun Armada 38x platforms
> > has been successfully tested with production systems.
>
> Hi Baruch
>
> For a change link this, we should have an acknowledgement from
> SolidRun, or maybe Russell King.
>
>           Andrew

Acked-by: Jon Nettleton <jon@solid-run.com>

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Andrew Lunn]

On Thu, Jun 28, 2018 at 11:33:48AM +0300, Jon Nettleton wrote:
> On Thu, Jun 28, 2018 at 11:23 AM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Thu, Jun 28, 2018 at 10:13:36AM +0300, Baruch Siach wrote:
> > > The current device-tree description of the SolidRun Armada 38x platforms
> > > has been successfully tested with production systems.
> >
> > Hi Baruch
> >
> > For a change link this, we should have an acknowledgement from
> > SolidRun, or maybe Russell King.
> >
> >           Andrew
> 
> Acked-by: Jon Nettleton <jon@solid-run.com>

:-)

Thanks 

       Andrew

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Andrew Lunn]

On Thu, Jun 28, 2018 at 10:13:36AM +0300, Baruch Siach wrote:
> The current device-tree description of the SolidRun Armada 38x platforms
> has been successfully tested with production systems.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Gregory CLEMENT]

Hi Baruch,
 
 On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> The SolidRun Armada 388 SOM has the SPI flash populated by default
> unless the customer explicitly asks otherwise. Enable support by
> default.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> index 2d1cea131e71..c990d502d9a4 100644
> --- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> +++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> @@ -99,7 +99,6 @@
>  		compatible = "w25q32", "jedec,spi-nor";
>  		reg = <0>; /* Chip select 0 */
>  		spi-max-frequency = <3000000>;
> -		status = "disabled";
>  	};
>  };
>  
> -- 
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer

[Gregory CLEMENT]

Hi Baruch,
 
 On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> The current device-tree description of the SolidRun Armada 38x platforms
> has been successfully tested with production systems.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied on mvebu/dt with the tags from Jon and Andrew

Thanks,

Gregory

> ---
>  arch/arm/boot/dts/armada-388-clearfog-base.dts      | 5 -----
>  arch/arm/boot/dts/armada-388-clearfog-pro.dts       | 5 -----
>  arch/arm/boot/dts/armada-388-clearfog.dts           | 5 -----
>  arch/arm/boot/dts/armada-388-clearfog.dtsi          | 5 -----
>  arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 5 -----
>  5 files changed, 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-388-clearfog-base.dts b/arch/arm/boot/dts/armada-388-clearfog-base.dts
> index 50ed4ae5c621..53b4bd35522a 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog-base.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog-base.dts
> @@ -3,11 +3,6 @@
>   * Device Tree file for SolidRun Clearfog Base revision A1 rev 2.0 (88F6828)
>   *
>   *  Copyright (C) 2015 Russell King
> - *
> - * This board is in development; the contents of this file work with
> - * the A1 rev 2.0 of the board, which does not represent final
> - * production board.  Things will change, don't expect this file to
> - * remain compatible info the future.
>   */
>  
>  /dts-v1/;
> diff --git a/arch/arm/boot/dts/armada-388-clearfog-pro.dts b/arch/arm/boot/dts/armada-388-clearfog-pro.dts
> index 24e4b5a509be..ff890c09c3ed 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog-pro.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog-pro.dts
> @@ -3,11 +3,6 @@
>   * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
>   *
>   *  Copyright (C) 2015 Russell King
> - *
> - * This board is in development; the contents of this file work with
> - * the A1 rev 2.0 of the board, which does not represent final
> - * production board.  Things will change, don't expect this file to
> - * remain compatible info the future.
>   */
>  #include "armada-388-clearfog.dts"
>  
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts
> index 5fd0f6f61e77..32b1e09b8293 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dts
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dts
> @@ -3,11 +3,6 @@
>   * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
>   *
>   *  Copyright (C) 2015 Russell King
> - *
> - * This board is in development; the contents of this file work with
> - * the A1 rev 2.0 of the board, which does not represent final
> - * production board.  Things will change, don't expect this file to
> - * remain compatible info the future.
>   */
>  
>  /dts-v1/;
> diff --git a/arch/arm/boot/dts/armada-388-clearfog.dtsi b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> index 0d9dfdfe977e..1da40bdfcef1 100644
> --- a/arch/arm/boot/dts/armada-388-clearfog.dtsi
> +++ b/arch/arm/boot/dts/armada-388-clearfog.dtsi
> @@ -3,11 +3,6 @@
>   * Device Tree include file for SolidRun Clearfog 88F6828 based boards
>   *
>   *  Copyright (C) 2015 Russell King
> - *
> - * This board is in development; the contents of this file work with
> - * the A1 rev 2.0 of the board, which does not represent final
> - * production board.  Things will change, don't expect this file to
> - * remain compatible info the future.
>   */
>  
>  #include "armada-388.dtsi"
> diff --git a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> index c990d502d9a4..3a7f9c1ac346 100644
> --- a/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> +++ b/arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi
> @@ -3,11 +3,6 @@
>   * Device Tree file for SolidRun Armada 38x Microsom
>   *
>   *  Copyright (C) 2015 Russell King
> - *
> - * This board is in development; the contents of this file work with
> - * the A1 rev 2.0 of the board, which does not represent final
> - * production board.  Things will change, don't expect this file to
> - * remain compatible info the future.
>   */
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/gpio/gpio.h>
> -- 
> 2.18.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Russell King - ARM Linux]

On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> The SolidRun Armada 388 SOM has the SPI flash populated by default
> unless the customer explicitly asks otherwise. Enable support by
> default.

Are you sure about that - at least some of my boards do not have the
SPI flash populated.

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */
...
&spi1 {
        /*
         * Add SPI CS pins for clearfog:
         * CS0: W25Q32 (not populated on uSOM)
         * CS1: PIC microcontroller (Pro models)
         * CS2: mikrobus
         */

I wouldn't have written "not populated on uSOM" without having first
taken the uSOM off and physically checked.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Russell King - ARM Linux]

On Thu, Jun 28, 2018 at 11:31:26AM +0200, Gregory CLEMENT wrote:
> Hi Baruch,
>  
>  On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > unless the customer explicitly asks otherwise. Enable support by
> > default.
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Applied on mvebu/dt

It would be nice if you waited for acks or review before picking up
patches.  Only patch 2 has been acked and reviewed.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Gregory CLEMENT]

Hi Russell King,
 
 On jeu., juin 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:

> On Thu, Jun 28, 2018 at 11:31:26AM +0200, Gregory CLEMENT wrote:
>> Hi Baruch,
>>  
>>  On jeu., juin 28 2018, Baruch Siach <baruch@tkos.co.il> wrote:
>> 
>> > The SolidRun Armada 388 SOM has the SPI flash populated by default
>> > unless the customer explicitly asks otherwise. Enable support by
>> > default.
>> >
>> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> 
>> Applied on mvebu/dt
>
> It would be nice if you waited for acks or review before picking up
> patches.  Only patch 2 has been acked and reviewed.

The mvebu branches can still be modified, they become immutably only
when we do PR, and usually it is around rc5 or rc6. So it's not too late
to make some remarks on them.

Gregory

>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
> According to speedtest.net: 8.21Mbps down 510kbps up

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Baruch Siach]

Hi Russell,

Thanks for reviewing.

On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > unless the customer explicitly asks otherwise. Enable support by
> > default.
> 
> Are you sure about that - at least some of my boards do not have the
> SPI flash populated.
> 
> &spi1 {
>         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> ...
> &spi1 {
>         /*
>          * Add SPI CS pins for clearfog:
>          * CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

>          * CS1: PIC microcontroller (Pro models)
>          * CS2: mikrobus
>          */
> 
> I wouldn't have written "not populated on uSOM" without having first
> taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

Ilya Viten from the SolidRun commercial department told me that all production 
SOMs that were shipped to customers have the SPI flash populated.

This is just the default value for the common case.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Russell King - ARM Linux]

On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> Hi Russell,
> 
> Thanks for reviewing.
> 
> On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > unless the customer explicitly asks otherwise. Enable support by
> > > default.
> > 
> > Are you sure about that - at least some of my boards do not have the
> > SPI flash populated.
> > 
> > &spi1 {
> >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > ...
> > &spi1 {
> >         /*
> >          * Add SPI CS pins for clearfog:
> >          * CS0: W25Q32 (not populated on uSOM)
> 
> I should update this line as well, I guess.
> 
> >          * CS1: PIC microcontroller (Pro models)
> >          * CS2: mikrobus
> >          */
> > 
> > I wouldn't have written "not populated on uSOM" without having first
> > taken the uSOM off and physically checked.
> 
> Are these production SOMs or development/engineering samples?

I don't remember.

> Ilya Viten from the SolidRun commercial department told me that all production 
> SOMs that were shipped to customers have the SPI flash populated.

Yes, Jon confirms that.

> This is just the default value for the common case.

Has it been tested with boards that don't have the SPI flash populated?
That needs to happen to make sure that this doesn't cause a regression.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Baruch Siach]

Hi Russell,

On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> > Thanks for reviewing.
> > 
> > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > > unless the customer explicitly asks otherwise. Enable support by
> > > > default.
> > > 
> > > Are you sure about that - at least some of my boards do not have the
> > > SPI flash populated.
> > > 
> > > &spi1 {
> > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > > ...
> > > &spi1 {
> > >         /*
> > >          * Add SPI CS pins for clearfog:
> > >          * CS0: W25Q32 (not populated on uSOM)
> > 
> > I should update this line as well, I guess.
> > 
> > >          * CS1: PIC microcontroller (Pro models)
> > >          * CS2: mikrobus
> > >          */
> > > 
> > > I wouldn't have written "not populated on uSOM" without having first
> > > taken the uSOM off and physically checked.
> > 
> > Are these production SOMs or development/engineering samples?
> 
> I don't remember.
> 
> > Ilya Viten from the SolidRun commercial department told me that all production 
> > SOMs that were shipped to customers have the SPI flash populated.
> 
> Yes, Jon confirms that.
> 
> > This is just the default value for the common case.
> 
> Has it been tested with boards that don't have the SPI flash populated?
> That needs to happen to make sure that this doesn't cause a regression.

I don't have such a SOM handy. I can try to "produce" one next week.

I tested a modified DT with the 'reg' property set to 1 to simulate an 
unpopulated SPI flash. The driver probe seems to fail gracefully:

  m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff

Is this test sufficient to ensure the safety of this patch?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Russell King - ARM Linux]

On Thu, Jun 28, 2018 at 01:47:30PM +0300, Baruch Siach wrote:
> Hi Russell,
> 
> On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
> > On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
> > > Thanks for reviewing.
> > > 
> > > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> > > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > > > > unless the customer explicitly asks otherwise. Enable support by
> > > > > default.
> > > > 
> > > > Are you sure about that - at least some of my boards do not have the
> > > > SPI flash populated.
> > > > 
> > > > &spi1 {
> > > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> > > > ...
> > > > &spi1 {
> > > >         /*
> > > >          * Add SPI CS pins for clearfog:
> > > >          * CS0: W25Q32 (not populated on uSOM)
> > > 
> > > I should update this line as well, I guess.
> > > 
> > > >          * CS1: PIC microcontroller (Pro models)
> > > >          * CS2: mikrobus
> > > >          */
> > > > 
> > > > I wouldn't have written "not populated on uSOM" without having first
> > > > taken the uSOM off and physically checked.
> > > 
> > > Are these production SOMs or development/engineering samples?
> > 
> > I don't remember.
> > 
> > > Ilya Viten from the SolidRun commercial department told me that all production 
> > > SOMs that were shipped to customers have the SPI flash populated.
> > 
> > Yes, Jon confirms that.
> > 
> > > This is just the default value for the common case.
> > 
> > Has it been tested with boards that don't have the SPI flash populated?
> > That needs to happen to make sure that this doesn't cause a regression.
> 
> I don't have such a SOM handy. I can try to "produce" one next week.
> 
> I tested a modified DT with the 'reg' property set to 1 to simulate an 
> unpopulated SPI flash. The driver probe seems to fail gracefully:
> 
>   m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff
> 
> Is this test sufficient to ensure the safety of this patch?

Yes, that's fine, thanks for checking.

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Gregory, please add my acked-by to your hasty commit, thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

[PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash

[Gregory CLEMENT]

Hi Russell King,
 
 On jeu., juin 28 2018, Russell King - ARM Linux <linux@armlinux.org.uk> wrote:

> On Thu, Jun 28, 2018 at 01:47:30PM +0300, Baruch Siach wrote:
>> Hi Russell,
>> 
>> On Thu, Jun 28, 2018 at 11:33:20AM +0100, Russell King - ARM Linux wrote:
>> > On Thu, Jun 28, 2018 at 01:07:59PM +0300, Baruch Siach wrote:
>> > > Thanks for reviewing.
>> > > 
>> > > On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
>> > > > On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
>> > > > > The SolidRun Armada 388 SOM has the SPI flash populated by default
>> > > > > unless the customer explicitly asks otherwise. Enable support by
>> > > > > default.
>> > > > 
>> > > > Are you sure about that - at least some of my boards do not have the
>> > > > SPI flash populated.
>> > > > 
>> > > > &spi1 {
>> > > >         /* The microsom has an optional W25Q32 on board, connected to CS0 */
>> > > > ...
>> > > > &spi1 {
>> > > >         /*
>> > > >          * Add SPI CS pins for clearfog:
>> > > >          * CS0: W25Q32 (not populated on uSOM)
>> > > 
>> > > I should update this line as well, I guess.
>> > > 
>> > > >          * CS1: PIC microcontroller (Pro models)
>> > > >          * CS2: mikrobus
>> > > >          */
>> > > > 
>> > > > I wouldn't have written "not populated on uSOM" without having first
>> > > > taken the uSOM off and physically checked.
>> > > 
>> > > Are these production SOMs or development/engineering samples?
>> > 
>> > I don't remember.
>> > 
>> > > Ilya Viten from the SolidRun commercial department told me that all production 
>> > > SOMs that were shipped to customers have the SPI flash populated.
>> > 
>> > Yes, Jon confirms that.
>> > 
>> > > This is just the default value for the common case.
>> > 
>> > Has it been tested with boards that don't have the SPI flash populated?
>> > That needs to happen to make sure that this doesn't cause a regression.
>> 
>> I don't have such a SOM handy. I can try to "produce" one next week.
>> 
>> I tested a modified DT with the 'reg' property set to 1 to simulate an 
>> unpopulated SPI flash. The driver probe seems to fail gracefully:
>> 
>>   m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff
>> 
>> Is this test sufficient to ensure the safety of this patch?
>
> Yes, that's fine, thanks for checking.
>
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Gregory, please add my acked-by to your hasty commit, thanks.

Done!

Thanks,

Gregory

>
> -- 
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
> According to speedtest.net: 8.21Mbps down 510kbps up

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com