* [PATCH] clkdev: clk_add_alias don't put origin clock
@ 2015-03-01 7:43 Yoshinori Sato
2015-03-01 14:51 ` Russell King - ARM Linux
0 siblings, 1 reply; 3+ messages in thread
From: Yoshinori Sato @ 2015-03-01 7:43 UTC (permalink / raw)
To: linux-arm-kernel
Refer to 'r' later.
So don't put in clk_add_alias.
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
drivers/clk/clkdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 043fd36..fddb999 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -318,7 +318,6 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
return PTR_ERR(r);
l = clkdev_alloc(r, alias, alias_dev_name);
- clk_put(r);
if (!l)
return -ENODEV;
clkdev_add(l);
@@ -334,6 +333,7 @@ void clkdev_drop(struct clk_lookup *cl)
mutex_lock(&clocks_mutex);
list_del(&cl->node);
mutex_unlock(&clocks_mutex);
+ clk_put(cl->clk);
kfree(cl);
}
EXPORT_SYMBOL(clkdev_drop);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] clkdev: clk_add_alias don't put origin clock
2015-03-01 7:43 [PATCH] clkdev: clk_add_alias don't put origin clock Yoshinori Sato
@ 2015-03-01 14:51 ` Russell King - ARM Linux
2015-03-03 6:40 ` Yoshinori Sato
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux @ 2015-03-01 14:51 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Mar 01, 2015 at 04:43:35PM +0900, Yoshinori Sato wrote:
> Refer to 'r' later.
> So don't put in clk_add_alias.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
This isn't how I want to solve this. I'd much rather we converted clkdev
to use struct clk_hw internally instead. This is something I'm looking
into at the moment.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] clkdev: clk_add_alias don't put origin clock
2015-03-01 14:51 ` Russell King - ARM Linux
@ 2015-03-03 6:40 ` Yoshinori Sato
0 siblings, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2015-03-03 6:40 UTC (permalink / raw)
To: linux-arm-kernel
At Sun, 1 Mar 2015 14:51:57 +0000,
Russell King - ARM Linux wrote:
>
> On Sun, Mar 01, 2015 at 04:43:35PM +0900, Yoshinori Sato wrote:
> > Refer to 'r' later.
> > So don't put in clk_add_alias.
> >
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
>
> This isn't how I want to solve this. I'd much rather we converted clkdev
> to use struct clk_hw internally instead. This is something I'm looking
> into at the moment.
>
OK.
It's checked a little more.
Thanks.
> --
> FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
> according to speedtest.net.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-03 6:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-01 7:43 [PATCH] clkdev: clk_add_alias don't put origin clock Yoshinori Sato
2015-03-01 14:51 ` Russell King - ARM Linux
2015-03-03 6:40 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).