* [PATCH] ARM: dove: Drop a write-only variable
@ 2024-07-08 9:23 Uwe Kleine-König
2024-07-08 13:37 ` Andrew Lunn
2024-09-02 14:19 ` Gregory CLEMENT
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2024-07-08 9:23 UTC (permalink / raw)
To: Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Jason Cooper
Cc: linux-arm-kernel
This fixes a W=1 build error:
arch/arm/mach-dove/common.c: In function ‘dove_clk_init’:
arch/arm/mach-dove/common.c:85:40: error: variable ‘gephy’ set but not used [-Werror=unused-but-set-variable]
85 | struct clk *xor0, *xor1, *ge, *gephy;
| ^~~~~
Fixes: 521674718af0 ("ARM: dove: add clock gating control")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
arch/arm/mach-dove/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
index 3aea90bbb41a..35e978514591 100644
--- a/arch/arm/mach-dove/common.c
+++ b/arch/arm/mach-dove/common.c
@@ -82,7 +82,7 @@ static void __init dove_clk_init(void)
{
struct clk *usb0, *usb1, *sata, *pex0, *pex1, *sdio0, *sdio1;
struct clk *nand, *camera, *i2s0, *i2s1, *crypto, *ac97, *pdma;
- struct clk *xor0, *xor1, *ge, *gephy;
+ struct clk *xor0, *xor1, *ge;
tclk = clk_register_fixed_rate(NULL, "tclk", NULL, 0, dove_tclk);
@@ -102,7 +102,7 @@ static void __init dove_clk_init(void)
pdma = dove_register_gate("pdma", "tclk", CLOCK_GATING_BIT_PDMA);
xor0 = dove_register_gate("xor0", "tclk", CLOCK_GATING_BIT_XOR0);
xor1 = dove_register_gate("xor1", "tclk", CLOCK_GATING_BIT_XOR1);
- gephy = dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
+ dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
ge = dove_register_gate("ge", "gephy", CLOCK_GATING_BIT_GBE);
orion_clkdev_add(NULL, "orion_spi.0", tclk);
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dove: Drop a write-only variable
2024-07-08 9:23 [PATCH] ARM: dove: Drop a write-only variable Uwe Kleine-König
@ 2024-07-08 13:37 ` Andrew Lunn
2024-09-02 14:19 ` Gregory CLEMENT
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2024-07-08 13:37 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Sebastian Hesselbarth, Gregory Clement, Jason Cooper,
linux-arm-kernel
On Mon, Jul 08, 2024 at 11:23:49AM +0200, Uwe Kleine-König wrote:
> This fixes a W=1 build error:
>
> arch/arm/mach-dove/common.c: In function ‘dove_clk_init’:
> arch/arm/mach-dove/common.c:85:40: error: variable ‘gephy’ set but not used [-Werror=unused-but-set-variable]
> 85 | struct clk *xor0, *xor1, *ge, *gephy;
> | ^~~~~
>
> Fixes: 521674718af0 ("ARM: dove: add clock gating control")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dove: Drop a write-only variable
2024-07-08 9:23 [PATCH] ARM: dove: Drop a write-only variable Uwe Kleine-König
2024-07-08 13:37 ` Andrew Lunn
@ 2024-09-02 14:19 ` Gregory CLEMENT
1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2024-09-02 14:19 UTC (permalink / raw)
To: Uwe Kleine-König, Andrew Lunn, Sebastian Hesselbarth,
Jason Cooper
Cc: linux-arm-kernel
Hi Uwe ,
> This fixes a W=1 build error:
>
> arch/arm/mach-dove/common.c: In function ‘dove_clk_init’:
> arch/arm/mach-dove/common.c:85:40: error: variable ‘gephy’ set but not used [-Werror=unused-but-set-variable]
> 85 | struct clk *xor0, *xor1, *ge, *gephy;
> | ^~~~~
>
> Fixes: 521674718af0 ("ARM: dove: add clock gating control")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Applied on mvebu/arm
Thanks,
Gregory
> ---
> arch/arm/mach-dove/common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index 3aea90bbb41a..35e978514591 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -82,7 +82,7 @@ static void __init dove_clk_init(void)
> {
> struct clk *usb0, *usb1, *sata, *pex0, *pex1, *sdio0, *sdio1;
> struct clk *nand, *camera, *i2s0, *i2s1, *crypto, *ac97, *pdma;
> - struct clk *xor0, *xor1, *ge, *gephy;
> + struct clk *xor0, *xor1, *ge;
>
> tclk = clk_register_fixed_rate(NULL, "tclk", NULL, 0, dove_tclk);
>
> @@ -102,7 +102,7 @@ static void __init dove_clk_init(void)
> pdma = dove_register_gate("pdma", "tclk", CLOCK_GATING_BIT_PDMA);
> xor0 = dove_register_gate("xor0", "tclk", CLOCK_GATING_BIT_XOR0);
> xor1 = dove_register_gate("xor1", "tclk", CLOCK_GATING_BIT_XOR1);
> - gephy = dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
> + dove_register_gate("gephy", "tclk", CLOCK_GATING_BIT_GIGA_PHY);
> ge = dove_register_gate("ge", "gephy", CLOCK_GATING_BIT_GBE);
>
> orion_clkdev_add(NULL, "orion_spi.0", tclk);
>
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-02 14:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-08 9:23 [PATCH] ARM: dove: Drop a write-only variable Uwe Kleine-König
2024-07-08 13:37 ` Andrew Lunn
2024-09-02 14:19 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).