From: Thomas Gleixner <tglx@linutronix.de>
To: Marc Zyngier <maz@kernel.org>,
Shivamurthy Shastri <shivamurthy.shastri@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
anna-maria@linutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com,
rdunlap@infradead.org, vidyas@nvidia.com,
ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com,
kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp,
andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org,
rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org,
lorenzo.pieralisi@arm.com, jgg@mellanox.com,
ammarfaizi2@gnuweeb.org, robin.murphy@arm.com,
lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org,
vkoul@kernel.org, okaya@kernel.org, agross@kernel.org,
andersson@kernel.org, mark.rutland@arm.com,
shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com
Subject: Re: [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics
Date: Mon, 17 Jun 2024 14:55:24 +0200 [thread overview]
Message-ID: <87plsfu3sz.ffs@tglx> (raw)
In-Reply-To: <86le36jf0q.wl-maz@kernel.org>
On Sat, Jun 15 2024 at 18:24, Marc Zyngier wrote:
> On Fri, 14 Jun 2024 11:23:53 +0100,
> Shivamurthy Shastri <shivamurthy.shastri@linutronix.de> wrote:
>> static struct msi_domain_info mbi_pmsi_domain_info = {
>> - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
>> - MSI_FLAG_LEVEL_CAPABLE),
>> + .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS),
>> .ops = &mbi_pmsi_ops,
>> .chip = &mbi_pmsi_irq_chip,
>> };
>
> This patch doesn't do what it says. It simply kills any form of level
> MSI support for *endpoints*, and has nothing to do with any sort of
> "wire to MSI".
>
> What replaces it?
Patch 9/24 switches the wire to MSI with level support over. This just
removes the leftovers.
next prev parent reply other threads:[~2024-06-17 12:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:23 [PATCH v3 00/24] genirq, irqchip: Convert ARM MSI handling to Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 01/24] irqdomain: Fix formatting irq_find_matching_fwspec() kerneldoc comment Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 02/24] irqchip/imx-mu-msi: Fix codingstyle in imx_mu_msi_domains_init() Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 03/24] PCI/MSI: Provide MSI_FLAG_PCI_MSI_MASK_PARENT Shivamurthy Shastri
2024-06-14 16:09 ` Bjorn Helgaas
2024-06-17 12:52 ` Thomas Gleixner
2024-06-14 10:23 ` [PATCH v3 04/24] irqchip: Provide irq-msi-lib Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 05/24] irqchip/gic-v3-its: Provide MSI parent infrastructure Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 06/24] irqchip/irq-msi-lib: Prepare for PCI MSI/MSIX Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 07/24] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X] Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 08/24] irqchip/irq-msi-lib: Prepare for DEVICE MSI to replace platform MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 09/24] irqchip/mbigen: Prepare for real per device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 10/24] irqchip/irq-msi-lib: Prepare for DOMAIN_BUS_WIRED_TO_MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 11/24] irqchip/gic-v3-its: Switch platform MSI to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 12/24] irqchip/mbigen: Remove platform_msi_create_device_domain() fallback Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 13/24] genirq/msi: Remove platform_msi_create_device_domain() Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 14/24] genirq/gic-v3-mbi: Remove unused wired MSI mechanics Shivamurthy Shastri
2024-06-15 17:24 ` Marc Zyngier
2024-06-17 12:55 ` Thomas Gleixner [this message]
2024-06-17 13:03 ` Marc Zyngier
2024-06-17 14:02 ` Thomas Gleixner
2024-06-17 14:15 ` Thomas Gleixner
2024-06-21 14:04 ` Thomas Gleixner
2024-06-23 11:26 ` Thomas Gleixner
2024-06-25 7:37 ` Marc Zyngier
2024-06-25 7:47 ` Thomas Gleixner
2024-06-14 10:23 ` [PATCH v3 15/24] genirq/gic-v3-mbi: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 16/24] irqchip/gic-v2m: Switch to device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 17/24] irqchip/imx-mu-msi: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 18/24] irqchip/irq-mvebu-icu: Prepare for real per device MSI Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 19/24] irqchip/mvebu-gicp: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:23 ` [PATCH v3 20/24] irqchip/mvebu-odmi: Switch to parent MSI Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 21/24] irqchip/irq-mvebu-sei: Switch to MSI parent Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 22/24] irqchip/irq-mvebu-icu: Remove platform MSI leftovers Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 23/24] genirq/msi: " Shivamurthy Shastri
2024-06-14 10:24 ` [PATCH v3 24/24] genirq/msi: Move msi_device_data to core Shivamurthy Shastri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plsfu3sz.ffs@tglx \
--to=tglx@linutronix.de \
--cc=agross@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=ammarfaizi2@gnuweeb.org \
--cc=andersson@kernel.org \
--cc=andrew@lunn.ch \
--cc=anna-maria@linutronix.de \
--cc=apatel@ventanamicro.com \
--cc=bhelgaas@google.com \
--cc=den@valinux.co.jp \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jgg@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nipun.gupta@amd.com \
--cc=nm@ti.com \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shawnguo@kernel.org \
--cc=shivamurthy.shastri@linutronix.de \
--cc=vidyas@nvidia.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).