From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A03C4708F for ; Tue, 1 Jun 2021 10:29:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6484C6124B for ; Tue, 1 Jun 2021 10:29:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6484C6124B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4sCXcgvaUVqo7TyYMLKC1TXOv8FowbnL3iVu63ZuR9U=; b=r3Mflh74hiH1lY dTUME5JcgwSYf2YJeM3nmrwCzf4RzCpXObyfjH4itWUVJg+Haf+fwOLbNZQsG9IG21bcG42bgKo4k +Iyn8JvPlpLBhCf6gBewAtYwFKrgM9Jf6Inif+YtK/A1sLR7agV/elCnzDutDieMAu4dC58RTRPSQ pCTTyPbCTRbgu0CVpclUfNjfIiMwJoFDx3/7NC+U/Xfts16e2CLaAOknzaIoYCCHTctSrWz1yHhxA SNOI/CAohRYLsVJujhatC0+BNZgoJWgSao6ja0TrzDxd8FnYFZcUKraSiYuannUysPec3TmD4cDaq Yt54sqSy3ofa2jpE+jqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1cq-00FvQP-FZ; Tue, 01 Jun 2021 10:27:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lo1ao-00FuDd-Sx for linux-arm-kernel@lists.infradead.org; Tue, 01 Jun 2021 10:25:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 44EE511FB; Tue, 1 Jun 2021 03:25:50 -0700 (PDT) Received: from e113632-lin (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 422D63F73D; Tue, 1 Jun 2021 03:25:49 -0700 (PDT) From: Valentin Schneider To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [RFC PATCH v2 09/10] irqchip/gic: Convert to handle_strict_flow_irq() In-Reply-To: <87wnrks6y5.wl-maz@kernel.org> References: <20210525173255.620606-1-valentin.schneider@arm.com> <20210525173255.620606-10-valentin.schneider@arm.com> <87wnrks6y5.wl-maz@kernel.org> Date: Tue, 01 Jun 2021 11:25:46 +0100 Message-ID: <87pmx5g9ud.mognet@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210601_032551_062627_8F3DA3A0 X-CRM114-Status: GOOD ( 15.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/05/21 13:21, Marc Zyngier wrote: > On Tue, 25 May 2021 18:32:54 +0100, > Valentin Schneider wrote: >> @@ -1116,8 +1116,16 @@ static void gic_init_chip(struct gic_chip_data *gic, struct device *dev, >> >> if (use_eoimode1) { >> gic->chip.irq_mask = gic_eoimode1_mask_irq; >> + gic->chip.irq_ack = gic_eoi_irq; >> gic->chip.irq_eoi = gic_eoimode1_eoi_irq; >> gic->chip.irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity; >> + >> + /* >> + * eoimode0 shouldn't expose FLOW_MASK because the priority >> + * drop is undissociable from the deactivation, and we do need >> + * the priority drop to happen within the flow handler. >> + */ >> + gic->chip.flags |= IRQCHIP_AUTOMASKS_FLOW | IRQCHIP_EOI_THREADED; >> } >> >> if (gic == &gic_data[0]) { > > How about GICv2M, GICv3-MBI, and the collection of widget that build a > domain on top of a GIC domain? I'm worried that they now all need > updating one way or another... > Hmph, that's a good point. It's been a while since I've last stared at the v2m, I'll go try to page that back in. > M. > > -- > Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel