From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19E0FC433B4 for ; Tue, 11 May 2021 11:44:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AC2461185 for ; Tue, 11 May 2021 11:44:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AC2461185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jIPIbLk8ON3GFv9ISgRZhqUjXyTLeSPY+xV/+sM/dTI=; b=SC4BZab5Vhyg5ivVR8/+8784D Fk5w4zlYAE2I4BMNJnZyLnHyb1ohAN7TDcF7QZSZ89IzQ/XX3PucSkEhvZd5qJjM581vfDZaA2Ldn qTPwMJsbcreA6nl2n9b4LizdvJZrBepOgLtsf9FQlxlbyztGS1TkE5qC0QWaA0SFCIi7h2UpHrfBR /Mp9IccO25z8Q8iPWM4gdOsy4hRerPbF8C2XW0PRvDIowl5gap76PXkHlGO0F69sH4anmF/05nyHQ odnNPkS/+jnTEPxkon6lvNy7lKkv53IbTwsu2NrmAU2voHpu8aCyNAcXX9/R7lpV4xZ946jdPIQDx 6/ODsnkdA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgQn5-00HBKz-OA; Tue, 11 May 2021 11:43:08 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgMbS-00GUCH-DY for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 07:14:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QQ1ObADll8+Gm4+mKvhssr7TNK+Ew0GXYz9eFCFAvZk=; b=TlQeFYa3DDGDsO73ZPxJ63ayMB Sdq2SSw/IPYbIDQNC1z4t1gUc7+s0PDBPcotLX/bSnjlar6yGl+BFeZXH9ToDpmdR9ar/UB7XejOT FtCy/BtbxoRedtcYwJe86/K5wqpYRakDmveZXLSSbWMtagovPbFO3X0oEzib41UJJ2VcTWaUe+O6X P4blMAlXFOotstwX42JKLlj6tAB4nGTOM4plZgDqTfoqr6dmtn2kO4qFoCj1Wu5ocUH0gSBxaJ/Dj Fo7SOr/aZiGI2zUlazlWsz+tqEiJkZZkMe6ci01gszCTervzK6eEq6Og8u5kTshcIPcKeLzxZR1lK yvs4SV+A==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgMbN-009M8F-9v for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 07:14:46 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA05761926; Tue, 11 May 2021 07:14:44 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lgMbK-000cKz-MU; Tue, 11 May 2021 08:14:42 +0100 Date: Tue, 11 May 2021 08:14:42 +0100 Message-ID: <87pmxxoi71.wl-maz@kernel.org> From: Marc Zyngier To: Zou Wei Cc: , , , , , Jisheng Zhang Subject: Re: [PATCH -next] clocksource/drivers/arm_arch_timer: Make symbol 'arch_timer_rate1' static In-Reply-To: <1620715583-107670-1-git-send-email-zou_wei@huawei.com> References: <1620715583-107670-1-git-send-email-zou_wei@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: zou_wei@huawei.com, mark.rutland@arm.com, daniel.lezcano@linaro.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jisheng.Zhang@synaptics.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_001445_384956_2EC65A92 X-CRM114-Status: GOOD ( 23.33 ) /bin/ln: failed to access 'reaver_cache/texts/20210511_001445_384956_2EC65A92': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_001445_384956_2EC65A92 X-CRM114-Status: GOOD ( 18.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+ Jisheng Zhang] On Tue, 11 May 2021 07:46:23 +0100, Zou Wei wrote: > > The sparse tool complains as follows: > > drivers/clocksource/arm_arch_timer.c:67:5: warning: > symbol 'arch_timer_rate1' was not declared. Should it be static? > > This symbol is not used outside of arm_arch_timer.c, so marks it > static. It is worse than that. This variable is not used *at all*, and has been added by e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add __ro_after_init and __init"). Not sure how we missed that. Please post a patch removing this variable altogether. Thanks, M. > > Reported-by: Hulk Robot > Signed-off-by: Zou Wei > --- > drivers/clocksource/arm_arch_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index fe1a826..800aaa9 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -64,7 +64,7 @@ struct arch_timer { > #define to_arch_timer(e) container_of(e, struct arch_timer, evt) > > static u32 arch_timer_rate __ro_after_init; > -u32 arch_timer_rate1 __ro_after_init; > +static u32 arch_timer_rate1 __ro_after_init; > static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init; > > static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = { > -- > 2.6.2 > > -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel