From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E0FC433C1 for ; Tue, 30 Mar 2021 10:18:31 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CDCB619A9 for ; Tue, 30 Mar 2021 10:18:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CDCB619A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fgbnVQz2q3zjLj0/nYtTZERMiobwdEXM8k06d2ze4io=; b=YGbTZ06abP2DXe91FUsVSpz9R L35t82yNJ9VDrwADnilxzQ4OFizdaHR5zFYUMMRk38y7rqUvWBByYLHh4PWuSF9T4bPzmG3L7qqwM z8MqOpa0GpnEyDjxXhqddTWhkwnAJwqECOeStZKth8V9KeN6g/860DZ7abAOrICbaNr7/G3ywDgAy r4AdbXWOan4+sQmFYz9if0Dn53l+3ov/2vxq3jvElDx6eC6nuRzj26MuSysH4kxaCzpOlnewvje03 attPhP7y9Wc2rEmSbftX0zg0TCryvlXt8dotehLikJg0rugaCwSQI9xndumBDYTEqDxxFv1YmuVdh rgeBN9tRg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRBQa-003Nag-Uv; Tue, 30 Mar 2021 10:16:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRBQV-003NZi-Fp for linux-arm-kernel@lists.infradead.org; Tue, 30 Mar 2021 10:16:49 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED8FA619AA; Tue, 30 Mar 2021 10:16:45 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lRBQR-004eNr-Qv; Tue, 30 Mar 2021 11:16:44 +0100 Date: Tue, 30 Mar 2021 11:16:42 +0100 Message-ID: <87pmzhq73p.wl-maz@kernel.org> From: Marc Zyngier To: Mathieu Poirier Cc: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, Will Deacon , Mark Rutland Subject: Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host In-Reply-To: <20210326165550.GC2009902@xps15> References: <20210323120647.454211-1-suzuki.poulose@arm.com> <20210323120647.454211-8-suzuki.poulose@arm.com> <20210326165550.GC2009902@xps15> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mathieu.poirier@linaro.org, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210330_111647_750827_A003C673 X-CRM114-Status: GOOD ( 23.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On Fri, 26 Mar 2021 16:55:50 +0000, Mathieu Poirier wrote: > > On Tue, Mar 23, 2021 at 12:06:35PM +0000, Suzuki K Poulose wrote: > > For a nvhe host, the EL2 must allow the EL1&0 translation > > regime for TraceBuffer (MDCR_EL2.E2TB == 0b11). This must > > be saved/restored over a trip to the guest. Also, before > > entering the guest, we must flush any trace data if the > > TRBE was enabled. And we must prohibit the generation > > of trace while we are in EL1 by clearing the TRFCR_EL1. > > > > For vhe, the EL2 must prevent the EL1 access to the Trace > > Buffer. > > > > Cc: Will Deacon > > Cc: Catalin Marinas > > Cc: Marc Zyngier > > Cc: Mark Rutland > > Cc: Anshuman Khandual > > Acked-by: Mathieu Poirier > > Signed-off-by: Suzuki K Poulose > > --- > > arch/arm64/include/asm/el2_setup.h | 13 +++++++++ > > arch/arm64/include/asm/kvm_arm.h | 2 ++ > > arch/arm64/include/asm/kvm_host.h | 2 ++ > > arch/arm64/kernel/hyp-stub.S | 3 ++- > > arch/arm64/kvm/debug.c | 6 ++--- > > arch/arm64/kvm/hyp/nvhe/debug-sr.c | 42 ++++++++++++++++++++++++++++++ > > arch/arm64/kvm/hyp/nvhe/switch.c | 1 + > > 7 files changed, 65 insertions(+), 4 deletions(-) > > > > Marc - do you want me to pick up this one? I just went through the KVM patch, and I have a couple of question that Suzuki can hopefully address quickly enough. As for merging it via your tree, I'm worried that it will conflict with other patches that are in flight. We can hopefully set up a stable branch between the two trees. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel