From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 3/3] net: mvneta: Add naive RSS support
Date: Mon, 30 Nov 2015 17:40:05 +0100 [thread overview]
Message-ID: <87poyr4f16.fsf@free-electrons.com> (raw)
In-Reply-To: <CAPv3WKfEJGAHgDvfyeHKZaiJqbsyrV+uKM+E3enbNLVznLY6zA@mail.gmail.com> (Marcin Wojtas's message of "Sat, 28 Nov 2015 17:43:57 +0100")
Hi Marcin,
On sam., nov. 28 2015, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Gregory,
>
>> +
>> + /* update unicast mapping */
>> + mvneta_set_rx_mode(pp->dev);
>
> I know it may be an ultimate level of nitpicking, but can you start a
> comment with capital letter?:)
If I got other review, then I can fix it in the next version. But if you
have a look on the otehr commet not all of them start by capital letter.
Thanks,
Greogry
>
> Best regards,
> Marcin
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-11-30 16:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 14:54 [PATCH net-next 0/3] mvneta: Introduce RSS support Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 1/3] net: mvneta: Make the default queue related for each port Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 2/3] net: mvneta: Associate RX queues with each CPU Gregory CLEMENT
2015-11-25 14:54 ` [PATCH net-next 3/3] net: mvneta: Add naive RSS support Gregory CLEMENT
2015-11-25 16:55 ` Thomas Petazzoni
2015-11-25 17:08 ` Gregory CLEMENT
2015-11-28 16:43 ` Marcin Wojtas
2015-11-30 16:40 ` Gregory CLEMENT [this message]
2015-11-26 19:04 ` [PATCH net-next 0/3] mvneta: Introduce " Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poyr4f16.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).