* [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries
@ 2013-09-13 11:32 Lorenzo Pieralisi
2013-09-13 11:53 ` Gregory CLEMENT
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2013-09-13 11:32 UTC (permalink / raw)
To: linux-arm-kernel
Following the reorganization of CPU idle drivers configurations into an ARM
specific Kconfig, the existing idle drivers Kconfig entries were renamed and
moved to the Kconfig.arm file. Makefile entries were updated accordingly.
This patch renames the entries in Kconfig.arm and makefile to make the newly
added big.LITTLE CPUidle driver compliant with the new naming convention.
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
drivers/cpuidle/Kconfig.arm | 2 +-
drivers/cpuidle/Makefile | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 8e36603..ea0f045 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -27,7 +27,7 @@ config ARM_U8500_CPUIDLE
help
Select this to enable cpuidle for ST-E u8500 processors
-config CPU_IDLE_BIG_LITTLE
+config ARM_BIG_LITTLE_CPUIDLE
bool "Support for ARM big.LITTLE processors"
depends on ARCH_VEXPRESS_TC2_PM
select ARM_CPU_SUSPEND
diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile
index cea5ef5..3c693c2 100644
--- a/drivers/cpuidle/Makefile
+++ b/drivers/cpuidle/Makefile
@@ -11,4 +11,4 @@ obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE) += cpuidle-calxeda.o
obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE) += cpuidle-kirkwood.o
obj-$(CONFIG_ARM_ZYNQ_CPUIDLE) += cpuidle-zynq.o
obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o
-obj-$(CONFIG_CPU_IDLE_BIG_LITTLE) += cpuidle-big_little.o
+obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE) += cpuidle-big_little.o
--
1.8.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries
2013-09-13 11:32 [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries Lorenzo Pieralisi
@ 2013-09-13 11:53 ` Gregory CLEMENT
2013-09-13 14:01 ` Lorenzo Pieralisi
0 siblings, 1 reply; 5+ messages in thread
From: Gregory CLEMENT @ 2013-09-13 11:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Lorenzo,
On 13/09/2013 13:32, Lorenzo Pieralisi wrote:
> Following the reorganization of CPU idle drivers configurations into an ARM
> specific Kconfig, the existing idle drivers Kconfig entries were renamed and
> moved to the Kconfig.arm file. Makefile entries were updated accordingly.
>
> This patch renames the entries in Kconfig.arm and makefile to make the newly
> added big.LITTLE CPUidle driver compliant with the new naming convention.
Do you also consider to reorder the entries in alphabetic order?
It should help to reduce the merge conflict.
Regards,
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
> drivers/cpuidle/Kconfig.arm | 2 +-
> drivers/cpuidle/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 8e36603..ea0f045 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -27,7 +27,7 @@ config ARM_U8500_CPUIDLE
> help
> Select this to enable cpuidle for ST-E u8500 processors
>
> -config CPU_IDLE_BIG_LITTLE
> +config ARM_BIG_LITTLE_CPUIDLE
> bool "Support for ARM big.LITTLE processors"
> depends on ARCH_VEXPRESS_TC2_PM
> select ARM_CPU_SUSPEND
> diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile
> index cea5ef5..3c693c2 100644
> --- a/drivers/cpuidle/Makefile
> +++ b/drivers/cpuidle/Makefile
> @@ -11,4 +11,4 @@ obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE) += cpuidle-calxeda.o
> obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE) += cpuidle-kirkwood.o
> obj-$(CONFIG_ARM_ZYNQ_CPUIDLE) += cpuidle-zynq.o
> obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o
> -obj-$(CONFIG_CPU_IDLE_BIG_LITTLE) += cpuidle-big_little.o
> +obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE) += cpuidle-big_little.o
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries
2013-09-13 11:53 ` Gregory CLEMENT
@ 2013-09-13 14:01 ` Lorenzo Pieralisi
2013-09-13 15:23 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Lorenzo Pieralisi @ 2013-09-13 14:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 13, 2013 at 12:53:56PM +0100, Gregory CLEMENT wrote:
> Hi Lorenzo,
>
> On 13/09/2013 13:32, Lorenzo Pieralisi wrote:
> > Following the reorganization of CPU idle drivers configurations into an ARM
> > specific Kconfig, the existing idle drivers Kconfig entries were renamed and
> > moved to the Kconfig.arm file. Makefile entries were updated accordingly.
> >
> > This patch renames the entries in Kconfig.arm and makefile to make the newly
> > added big.LITTLE CPUidle driver compliant with the new naming convention.
>
> Do you also consider to reorder the entries in alphabetic order?
> It should help to reduce the merge conflict.
Sure, here it is, thanks for pointing that out.
Lorenzo
-- >8 --
Subject: [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and
makefile entries
Following the reorganization of CPU idle drivers configurations into an ARM
specific Kconfig, the existing idle drivers Kconfig entries were renamed and
moved to the Kconfig.arm file. Makefile entries were updated accordingly.
This patch renames the entries in Kconfig.arm and makefile to make the newly
added big.LITTLE CPUidle driver compliant with the new naming convention.
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
---
drivers/cpuidle/Kconfig.arm | 22 +++++++++++-----------
drivers/cpuidle/Makefile | 2 +-
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 8e36603..6a7e6f2 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -2,6 +2,17 @@
# ARM CPU Idle drivers
#
+config ARM_BIG_LITTLE_CPUIDLE
+ bool "Support for ARM big.LITTLE processors"
+ depends on ARCH_VEXPRESS_TC2_PM
+ select ARM_CPU_SUSPEND
+ select CPU_IDLE_MULTIPLE_DRIVERS
+ help
+ Select this option to enable CPU idle driver for big.LITTLE based
+ ARM systems. Driver manages CPUs coordination through MCPM and
+ define different C-states for little and big cores through the
+ multiple CPU idle drivers infrastructure.
+
config ARM_HIGHBANK_CPUIDLE
bool "CPU Idle Driver for Calxeda processors"
depends on ARCH_HIGHBANK
@@ -26,14 +37,3 @@ config ARM_U8500_CPUIDLE
depends on ARCH_U8500
help
Select this to enable cpuidle for ST-E u8500 processors
-
-config CPU_IDLE_BIG_LITTLE
- bool "Support for ARM big.LITTLE processors"
- depends on ARCH_VEXPRESS_TC2_PM
- select ARM_CPU_SUSPEND
- select CPU_IDLE_MULTIPLE_DRIVERS
- help
- Select this option to enable CPU idle driver for big.LITTLE based
- ARM systems. Driver manages CPUs coordination through MCPM and
- define different C-states for little and big cores through the
- multiple CPU idle drivers infrastructure.
diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile
index cea5ef5..d08bd40 100644
--- a/drivers/cpuidle/Makefile
+++ b/drivers/cpuidle/Makefile
@@ -7,8 +7,8 @@ obj-$(CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED) += coupled.o
##################################################################################
# ARM SoC drivers
+obj-$(CONFIG_ARM_BIG_LITTLE_CPUIDLE) += cpuidle-big_little.o
obj-$(CONFIG_ARM_HIGHBANK_CPUIDLE) += cpuidle-calxeda.o
obj-$(CONFIG_ARM_KIRKWOOD_CPUIDLE) += cpuidle-kirkwood.o
obj-$(CONFIG_ARM_ZYNQ_CPUIDLE) += cpuidle-zynq.o
obj-$(CONFIG_ARM_U8500_CPUIDLE) += cpuidle-ux500.o
-obj-$(CONFIG_CPU_IDLE_BIG_LITTLE) += cpuidle-big_little.o
--
1.8.2.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries
2013-09-13 14:01 ` Lorenzo Pieralisi
@ 2013-09-13 15:23 ` Kevin Hilman
2013-09-13 17:22 ` Lorenzo Pieralisi
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2013-09-13 15:23 UTC (permalink / raw)
To: linux-arm-kernel
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> writes:
> On Fri, Sep 13, 2013 at 12:53:56PM +0100, Gregory CLEMENT wrote:
>> Hi Lorenzo,
>>
>> On 13/09/2013 13:32, Lorenzo Pieralisi wrote:
>> > Following the reorganization of CPU idle drivers configurations into an ARM
>> > specific Kconfig, the existing idle drivers Kconfig entries were renamed and
>> > moved to the Kconfig.arm file. Makefile entries were updated accordingly.
>> >
>> > This patch renames the entries in Kconfig.arm and makefile to make the newly
>> > added big.LITTLE CPUidle driver compliant with the new naming convention.
>>
>> Do you also consider to reorder the entries in alphabetic order?
>> It should help to reduce the merge conflict.
>
> Sure, here it is, thanks for pointing that out.
FYI, updated patches deep inside threads are very likely to be missed.
I saw this because I was looking for it, but would've easily been
missed.
Could you resend a v2 with my ack so Daniel can pick up and get it
merged for v3.12-rc? Thanks
Acked-by: Kevin Hilman <khilman@linaro.org>
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries
2013-09-13 15:23 ` Kevin Hilman
@ 2013-09-13 17:22 ` Lorenzo Pieralisi
0 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2013-09-13 17:22 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 13, 2013 at 04:23:44PM +0100, Kevin Hilman wrote:
> Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> writes:
>
> > On Fri, Sep 13, 2013 at 12:53:56PM +0100, Gregory CLEMENT wrote:
> >> Hi Lorenzo,
> >>
> >> On 13/09/2013 13:32, Lorenzo Pieralisi wrote:
> >> > Following the reorganization of CPU idle drivers configurations into an ARM
> >> > specific Kconfig, the existing idle drivers Kconfig entries were renamed and
> >> > moved to the Kconfig.arm file. Makefile entries were updated accordingly.
> >> >
> >> > This patch renames the entries in Kconfig.arm and makefile to make the newly
> >> > added big.LITTLE CPUidle driver compliant with the new naming convention.
> >>
> >> Do you also consider to reorder the entries in alphabetic order?
> >> It should help to reduce the merge conflict.
> >
> > Sure, here it is, thanks for pointing that out.
>
> FYI, updated patches deep inside threads are very likely to be missed.
> I saw this because I was looking for it, but would've easily been
> missed.
Got it, thanks for that.
> Could you resend a v2 with my ack so Daniel can pick up and get it
> merged for v3.12-rc? Thanks
Done.
Thank you,
Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-13 17:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-13 11:32 [PATCH] drivers: cpuidle: rename ARM big.LITTLE driver config and makefile entries Lorenzo Pieralisi
2013-09-13 11:53 ` Gregory CLEMENT
2013-09-13 14:01 ` Lorenzo Pieralisi
2013-09-13 15:23 ` Kevin Hilman
2013-09-13 17:22 ` Lorenzo Pieralisi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).