From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9102FC46CD2 for ; Tue, 30 Jan 2024 12:12:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kiEPdjVdweVY8DVLOuhuS2g1MWeo9uU2ISKSz9EcGzA=; b=WluVxVb5GewtOJ wCwD1W1IZH12z5j4j5vInZlUyKj1g+jeBHleFvgF4pt/klBpgwF9uxQYsfkpYElEUhgbL+LXWBddV rTVOYfeDZFiXOxeM6OdSDO0mzvXv+OdqbNJDNgDfxxa3czeJU9qMi7bDAX2//bfnXJXW+dz5Ezxyr 4/VdVpJnfLOqxbF6yFy/GcFkmaqEzFZPehIswzqRLPc8UujObIutW/CMOPj550NricVTHV5O0Zsr8 Ppgb11lshgX2VCZ6FunaAuKk2KOAgSojxlXfL7QV2Jyvmg2aVnLatS/i9Pgh5aL1tyQE4XsRfCgOG D2VWoFBumw9e9/uqpCbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmyj-0000000GcrA-33Sm; Tue, 30 Jan 2024 12:12:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUmyh-0000000GcpY-0WbU for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 12:12:36 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 20C5B60AC9; Tue, 30 Jan 2024 12:12:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8A53C433C7; Tue, 30 Jan 2024 12:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706616752; bh=qtKz5PUT9mkDsa8isUg58tbqJCm6B3Touj9jntprnT4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NrqOuS07Jp2W7AUAgmBUQS096hW0Wbl+CnPwYM84PTwAZdzKD8I1rbgt+6OAUApYi X++8FSbNCtMxVh5DGwzItWhRNGutrz5Ot/qZ5zb8TEveu8nLCvHVvYXMUkFifN2ecQ J0fDpcEE8xAzh28C4zzhLhOnHgogvrVB5sa6WXK9QPs8tokxVY37yffWeoKqtJ34u3 Rz9RHyEcx9lQNHU4KEt1OQPyVyxI73NN1Rpbgr0XcGQ4NWiIAld+IKAa3J4NYTrw4E w93sGxxfkPW81wwZEsjtpTpDpOavvv2DFxd2KnYAD/fPgacxWMMKnD9Wvg+LsPg9hU wX1pLKyPSAhvQ== Received: from [12.161.88.66] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rUmyc-00GFWy-Cu; Tue, 30 Jan 2024 12:12:30 +0000 Date: Tue, 30 Jan 2024 12:12:26 +0000 Message-ID: <87r0hzvx3p.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Joey Gouly , Mark Brown Subject: Re: [PATCH 02/25] KVM: arm64: Add feature checking helpers In-Reply-To: References: <20240122201852.262057-1-maz@kernel.org> <20240122201852.262057-3-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 12.161.88.66 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, broonie@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_041235_238474_2AF51A2D X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 26 Jan 2024 19:05:47 +0000, Oliver Upton wrote: > > On Mon, Jan 22, 2024 at 08:18:29PM +0000, Marc Zyngier wrote: > > In order to make it easier to check whether a particular feature > > is exposed to a guest, add a new set of helpers, with kvm_has_feat() > > being the most useful. > > > > Follow-up work will make heavy use of these. > > > > Signed-off-by: Marc Zyngier > > I very much like the way these helpers appear to work. However, I > noticed there are still a few places where we are doing explicit feature > checks against register values instead of using the macros, did you want > to address these? Eventually, yes. It is just that there is a lot to do and I wanted to focus on the VM runtime configuration. > > Using kvm_has_feat() consistently in KVM will hopefully drive the point > home that this is the way we want to see things done going forward. Absolutely. I'll add these to the series. Thanks! M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel