From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03332EB64DA for ; Wed, 5 Jul 2023 08:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rX6F9zBXerXPUtNGYCvmUx5nsjLMi/pxJo956RCDeLg=; b=uxGPHEHD5ozCEQ tzpVWivjTVGjfc8KHMxNJdF/9KF7yw7jjCDH7E7rLZcP8JkccPhr1w1c/y6NE5/JgPN9DyyDYOSR3 8+HDiOiz4rbEVFMc2labkvR3HowqQP+u9DNp91Zxs3pb/98dbGQlq7oQzgRGkO2h/yCir8LeY52uz +e8to8qUqGjx9fsUOB2eyfTQ+V+kT5Uj2YUetV/pFySaKFmH0ryNh8FoN4B2dPBboexJnwpzpjD1f qkKhWUbmOOyh+oLSEF1I0MrSdEyR9rrJaU6B5J+QdZG2TR0pfXoEShjju3VajvdgdGw59J51WL975 S4fgoabKdBwlVFQ9jH9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGyCr-00FGQe-10; Wed, 05 Jul 2023 08:49:49 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGyCo-00FGQ3-3D for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 08:49:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688546986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mygE2eC1+1F6RcP4Lm9OLsM0G/twLQqV8R8dIF6r2eA=; b=M5AOvAXIoOFW9AkdhVwN+s4aEV6tnHZY0yevlb69QaoTsNa8mUmvHIury4ZCQbu9qOj4fz yiH3nFLROT+staoE3Omd2eBm9kqT4/rKZUCSv+PkVTaoS3XpClMiDVIJpoTPKjwD/AWScG hqHNHsvFLog8JAY5kIalamsMrQBDWJI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-FsRJS8RqOU6keRLGMFmk-g-1; Wed, 05 Jul 2023 04:49:43 -0400 X-MC-Unique: FsRJS8RqOU6keRLGMFmk-g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-30e4943ca7fso3304944f8f.3 for ; Wed, 05 Jul 2023 01:49:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688546982; x=1691138982; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mygE2eC1+1F6RcP4Lm9OLsM0G/twLQqV8R8dIF6r2eA=; b=V+7nM+zqxHguWTSZH8mZ22kEFRw1qfyciVVfY61KrdPE0paGD8SBLEauGYGyq6Z4VT FLjCB57d0vfBBBFPMhb0qDDkcZHZOdSK0jzR+QwMUhabodEKuf7bEpeDVLctuaubpf9t fxNTFDOkIYzAM452hwzvb/yArFAEV0mMLIHZEVUxlvI+wAr5RW5lWFmQhXAIjfgKtm5b QMuMnmAk5+xj0k2zGmGkPVK7X/l//knLTyIfCa9c2nHYQrzm+DdvrFPTtDO+RO92wOdW 4aGdhSpsIzF16AIKTK6jK4LS/uvG1k9r2tMs4Em0R7LjRBFRbpfGpzmg1vjQfh3o8Q46 1hpQ== X-Gm-Message-State: ABy/qLb3Z/T5NroFrZ+L/wLAowOwWwDw/dAgO555wexxKMgvG/pSKBKq M7YLKkNdmFG9Idtr3r5PRs2W2X4+pTaszs5rt1+fXhnlWd9KLrWgOlyYBmzJBsoygZmZ6DEYLE9 rtVjaGO05zyqsnImTz3XkiLlHTm3lF6AJQLM= X-Received: by 2002:adf:e44d:0:b0:313:f97c:d87f with SMTP id t13-20020adfe44d000000b00313f97cd87fmr12842672wrm.67.1688546982144; Wed, 05 Jul 2023 01:49:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlHiFHQIX6+LSUFE4lngdNXwrF3KteEAZwZqL0tALqI5G9uCMk9AA+C1J9hJqpvVRrGAzg2C2Q== X-Received: by 2002:adf:e44d:0:b0:313:f97c:d87f with SMTP id t13-20020adfe44d000000b00313f97cd87fmr12842658wrm.67.1688546981884; Wed, 05 Jul 2023 01:49:41 -0700 (PDT) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id x18-20020adff0d2000000b003141e86e751sm14564867wro.5.2023.07.05.01.49.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jul 2023 01:49:41 -0700 (PDT) From: Javier Martinez Canillas To: Thomas Zimmermann , maarten.lankhorst@linux.intel.com, mripard@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-fbdev@vger.kernel.org, Thomas Zimmermann , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Subject: Re: [PATCH 06/10] drm/exynos: Set fbdev flags In-Reply-To: <20230704160133.20261-7-tzimmermann@suse.de> References: <20230704160133.20261-1-tzimmermann@suse.de> <20230704160133.20261-7-tzimmermann@suse.de> Date: Wed, 05 Jul 2023 10:49:40 +0200 Message-ID: <87r0pmrbdn.fsf@minerva.mail-host-address-is-not-set> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_014947_107639_E09DB364 X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thomas Zimmermann writes: > Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_DEFAULT, or did you meand FBINFO_FLAG_DEFAULT (the flag your patch is actually using) ? I just noticed that are the same... and in patch 04/10 you used the former for the tegra driver, but here you are using the latter. Is on purpose or just a mistake ? > FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should > be accessed with the CPU's regular memory ops. > > Signed-off-by: Thomas Zimmermann > Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > --- > drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > index 7ca3424b59ce..28dc398d6e10 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c > @@ -72,6 +72,7 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, > return PTR_ERR(fbi); > } > > + fbi->flags = FBINFO_FLAG_DEFAULT; The #define FBINFO_FLAG_DEFAULT FBINFO_DEFAULT seems to be there since the original v2.6.12-rc2 git import in commit 1da177e4c3f4, so is hard to know why was introduced. FBINFO_DEFAULT is more used, I will just stick to that: $ git grep FBINFO_DEFAULT | wc -l 92 $ git grep FBINFO_FLAG_DEFAULT | wc -l 38 Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel