From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8186C433EF for ; Fri, 29 Apr 2022 16:14:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g1tO6Ys166ZNm/QWmSrVlhIGmcpN1xoiSdyTYuE15w4=; b=NCY1sklMUgTwM/ lSvyNj6xU+8stWUilTy07Yf8QkDYS5e273xFc2WDgi7CmRhpM/gBVPuPKw8gAYpQ2utYWCVfZhLkd m6JWOEvsTSVIu0fsYkrJFfHsskjKHE4pSBtPxIO/ya87VdA6uD4/gBNvzvSRZqq6srHj/NAzNUSrK 2gWhM4zjVki6xDCi0m471AnXp/xtV3U7tvt4ERomjVdCBYqCPRf1aJOMffAxxBkb6PZ5PgWm5JD+h arVJp46u2yjnLTk0IAW50cEPBlRbCMO7a+mTyW7rXiaOhoJ9LY1vstLd6U21r2OmxPjYOSzPN5Rkc wS5jLK5VUWnEH+yrdulQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkTF7-00BudV-MP; Fri, 29 Apr 2022 16:13:17 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkTF3-00Bucn-QY for linux-arm-kernel@lists.infradead.org; Fri, 29 Apr 2022 16:13:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 711AFB835DE; Fri, 29 Apr 2022 16:13:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31454C385A7; Fri, 29 Apr 2022 16:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651248791; bh=BimLbpe+wK8qfg6p3B3bBWmNeFUMwe/JB66xq/FWkU4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JqEDut+BSTi4Ivemy3GACniJZ+J/mbWVlIrJd1GYFMu+2lrbMu+Gqe7HTZZ2MCPHc 3Tj2SAAsrcU3DQn1u7A/jAhTpOj5UO/sN46WpFcbjK5vUjhmlSEoapBCGjUU/QKgWe 8RRPN7IDfsalTjzGskElAgprEb0tfgh8w1IXm/Q0pfoifwlx2C+jHWUd3l00EkhLqQ e76kbj+9qC3Wcb54psrA0dGa3wgCpUdCF8O8f6M0+/j7LwfF+eeNcbPgkebKS0FT4h nU/WyPhdehz+F+Mc3ySrDYNHS/Va4VtqFyuhJlLTaJEGuGAXi88RAKxAYI9LS6gB9f MFmUbW91x6nVA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nkTEx-007z9c-LM; Fri, 29 Apr 2022 17:13:07 +0100 Date: Fri, 29 Apr 2022 17:13:07 +0100 Message-ID: <87r15f98bw.wl-maz@kernel.org> From: Marc Zyngier To: Linu Cherian Cc: , , , , , "kernel test\ robot" Subject: Re: [PATCH] arm64: Declare non global symbols as static In-Reply-To: <20220429075535.10636-1-lcherian@marvell.com> References: <20220429075535.10636-1-lcherian@marvell.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lcherian@marvell.com, catalin.marinas@arm.com, will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuc.decode@gmail.com, lkp@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_091314_222238_7A5481B0 X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Apr 2022 08:55:35 +0100, Linu Cherian wrote: > > Fix below sparse warnings introduced while adding errata. > > arch/arm64/kernel/cpu_errata.c:218:25: sparse: warning: symbol > 'cavium_erratum_23154_cpus' was not declared. Should it be static? > arch/arm64/kernel/cpu_errata.c:233:25: sparse: warning: symbol > 'cavium_erratum_27456_cpus' was not declared. Should it be static? > > Reported-by: kernel test robot > Signed-off-by: Linu Cherian > --- > arch/arm64/kernel/cpu_errata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c > index 4c9b5b4b7a0b..57a39cb6b489 100644 > --- a/arch/arm64/kernel/cpu_errata.c > +++ b/arch/arm64/kernel/cpu_errata.c > @@ -215,7 +215,7 @@ static const struct arm64_cpu_capabilities arm64_repeat_tlbi_list[] = { > #endif > > #ifdef CONFIG_CAVIUM_ERRATUM_23154 > -const struct midr_range cavium_erratum_23154_cpus[] = { > +static const struct midr_range cavium_erratum_23154_cpus[] = { > MIDR_ALL_VERSIONS(MIDR_THUNDERX), > MIDR_ALL_VERSIONS(MIDR_THUNDERX_81XX), > MIDR_ALL_VERSIONS(MIDR_THUNDERX_83XX), > @@ -230,7 +230,7 @@ const struct midr_range cavium_erratum_23154_cpus[] = { > #endif > > #ifdef CONFIG_CAVIUM_ERRATUM_27456 > -const struct midr_range cavium_erratum_27456_cpus[] = { > +static const struct midr_range cavium_erratum_27456_cpus[] = { > /* Cavium ThunderX, T88 pass 1.x - 2.1 */ > MIDR_RANGE(MIDR_THUNDERX, 0, 0, 1, 1), > /* Cavium ThunderX, T81 pass 1.0 */ Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel