From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6360EC433EF for ; Tue, 29 Mar 2022 07:08:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XbkJ7MZ3+bjVaVNGA4wQms5Lvy7rpolkx/tEYTBMksY=; b=ZdOIzKzSDppc1/ fWjUPgI98ao+BRKeBLYgo+ynlrW0g0x6/KvN8xpbnUsJU+ogcodFb7Ai/EWARhsFCf4nbRZ5K++Bx ZEoPue/vLW6Sa/BpJt2T3V5JGOOjQVm5eXDCIoSB77Ww4VJEpbbfS0YUkqIqT1vf+QF/mXHOw26BA J25qRpsHD4YmA35qvcbuPsd5JyaojIEZODsISoFLeIcE7q/Vtf6Hvd9NuIw7tVYJv7z5nWrXMemFS lWQLuiOx/RZZUz8FtXIfMEcmuby0unUNF3namUKvP7hjwApzv3i2lTPbUgCWp+TXtFWIIqzDgSP5/ txb3dinvc8I163i+SKiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5ws-00BGmZ-56; Tue, 29 Mar 2022 07:07:26 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZ5wo-00BGm6-0n for linux-arm-kernel@lists.infradead.org; Tue, 29 Mar 2022 07:07:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F63461529; Tue, 29 Mar 2022 07:07:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CC48C2BBE4; Tue, 29 Mar 2022 07:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648537640; bh=nQUP/FbGXeuylpTH5/b3zyp7BFtDjtEua/L88aOE6cc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LOsDzegZzfHWobPhUSjo+fS0pkmNbYdNkDxNG5AEmOj/qltw5OBAdpLcwyr4crcqx L5NEsAWfpVcS1Zi0Ioy8GKmC8SHSTJVdarhmySpt9QgA87E4X1VnBBGVPIde/MPmID Zrii/Ov86Mcz2jdmJ3lT/ZSrn4spzwjSNgv19jjLFncof4C6ddR3Y6rSrcBuC53M/c uuX0uClv2TgkEAgb66bNcVVpQNkzFsYAfMlWdzTi4jEIMWvVYYHTLjlTK645Ln6ZdE ZeayuFwvK+a1Wpg7w73Ple9E994Yq5CbHmgQUL3puRjtNWiLzkOPPW8URlBs2uzmM8 fh6AhpaJemo9g== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nZ5wj-00HaMS-BO; Tue, 29 Mar 2022 08:07:17 +0100 Date: Tue, 29 Mar 2022 08:07:12 +0100 Message-ID: <87r16li6e7.wl-maz@kernel.org> From: Marc Zyngier To: yuzhe Cc: james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: vgic-debug: remove unnecessary type castings In-Reply-To: <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com> References: <20220328103836.2829-1-yuzhe@nfschina.com> <87h77ifbbd.wl-maz@kernel.org> <0f4cf955-ca2b-626f-867e-5a0ecfe68ca1@nfschina.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: yuzhe@nfschina.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, liqiong@nfschina.com, kernel-janitors@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220329_000722_120837_57FDCE41 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Mar 2022 07:14:16 +0100, yuzhe wrote: > > >> @@ -229,7 +229,7 @@ static void print_irq_state(struct seq_file *s, struct vgic_irq *irq, > >> static int vgic_debug_show(struct seq_file *s, void *v) > >> { > >> - struct kvm *kvm = (struct kvm *)s->private; > >> + struct kvm *kvm = s->private; > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; > > How about you fully get rid of the unnecessary casts then? > > > > M. > > I don't know what you exactly mean. I follow the > kernel-janitors/TODO List to get rid of the unnecessary casts. And > I checked all the code in the arch directory and found these issues. Let me quote the lines again: > >> static int vgic_debug_show(struct seq_file *s, void *v) [...] > >> struct vgic_state_iter *iter = (struct vgic_state_iter *)v; Do you see what I mean? M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel