From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6FD3C433EF for ; Sat, 23 Oct 2021 09:11:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A823D61073 for ; Sat, 23 Oct 2021 09:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A823D61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JZt9qdNYsJ3YS8rrV9WrhU5PB2SkTr25EkCpGMCSfKs=; b=4FOjd3iTgoajAR bK73QZZJNT/37Ist4pscg6okXpaBL9y3HZHJh0SrqRm8TpZ3kI9jGmEaTrKTgz16ttnEfLg9OCKpX 5i05jvlIjR+m0dOk443UmpGAvdyiFRFXX8sqnJoebNxf4QnIL3AXnf5VlVUNULzT5Pfq2O4eksXsb QxmbmFMkvblOhHFxv2E5DvKW55/+uW5403wINDi40ILMQSgNf0tBrmD4AqKxSIXm6l3MimTUrq5tj R/pm96Pb2oCo9iAyJBmxzd06jk2PGqokFQtXjjwLogtDytndzYGfX+12pK4qvVZWBEGE0LVXGIXdN Y11MbdDzj8M4R1nfYcpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meD2a-00CSOR-Pz; Sat, 23 Oct 2021 09:10:12 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1meD2X-00CSO3-V0 for linux-arm-kernel@lists.infradead.org; Sat, 23 Oct 2021 09:10:11 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F7866105A; Sat, 23 Oct 2021 09:10:09 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1meD2V-0013hq-8b; Sat, 23 Oct 2021 10:10:07 +0100 Date: Sat, 23 Oct 2021 10:10:07 +0100 Message-ID: <87r1cct8cw.wl-maz@kernel.org> From: Marc Zyngier To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Thomas Gleixner , Sebastian Andrzej Siewior , Ard Biesheuvel Subject: Re: [PATCH 1/3] irqchip/gic-v3-its: Give the percpu rdist struct its own flags field In-Reply-To: <20211022103307.1711619-2-valentin.schneider@arm.com> References: <20211022103307.1711619-1-valentin.schneider@arm.com> <20211022103307.1711619-2-valentin.schneider@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, will@kernel.org, mark.rutland@arm.com, tglx@linutronix.de, bigeasy@linutronix.de, ardb@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211023_021010_045912_3C780C8B X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 22 Oct 2021 11:33:05 +0100, Valentin Schneider wrote: > > Later patches will require tracking some per-rdist status. Reuse the bytes > "lost" to padding within the __percpu rdist struct as a flags field, and > re-encode ->lpi_enabled within said flags. > > No change in functionality intended. > > Signed-off-by: Valentin Schneider > --- > drivers/irqchip/irq-gic-v3-its.c | 26 ++++++++++++++------------ > include/linux/irqchip/arm-gic-v3.h | 2 +- > 2 files changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index eb0882d15366..a688ed5c21e8 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -43,8 +43,10 @@ > #define ITS_FLAGS_WORKAROUND_CAVIUM_22375 (1ULL << 1) > #define ITS_FLAGS_WORKAROUND_CAVIUM_23144 (1ULL << 2) > > -#define RDIST_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) > -#define RDIST_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) > +#define RDISTS_FLAGS_PROPBASE_NEEDS_FLUSHING (1 << 0) > +#define RDISTS_FLAGS_RD_TABLES_PREALLOCATED (1 << 1) > + > +#define RDIST_FLAGS_LPI_ENABLED BIT(0) Just to reduce the churn and for me not to misread things (because RDIST/RDISTS is pretty confusing), how about leaving the original flags as is, and name the per-RD ones like: #define RD_LOCAL_LPI_ENABLED BIT(0) ? Or something else that'd be adequately different from the original flags? Otherwise looks sensible. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel