Re: [PATCH 10/11] arm64: broadcom: Removed forced select of interrupt controllers

Marc Zyngier
2021-09-25T12:12:01Z

On Fri, 24 Sep 2021 18:05:45 +0100,
Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Now that the various second level interrupt controllers have been moved
> to IRQCHIP_PLATFORM_DRIVER and they do default to ARCH_BRCMSTB and
> ARCH_BCM2835 where relevant, remove their forced selection from the
> machine entry to allow an user to build them as modules.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> arch/arm64/Kconfig.platforms | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index b0ce18d4cc98..2e9440f2da22 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -44,7 +44,6 @@ config ARCH_BCM2835
> select ARM_AMBA
> select ARM_GIC
> select ARM_TIMER_SP804
> - select BRCMSTB_L2_IRQ
> help
> This enables support for the Broadcom BCM2837 and BCM2711 SoC.
> These SoCs are used in the Raspberry Pi 3 and 4 devices.
> @@ -82,8 +81,6 @@ config ARCH_BITMAIN
> config ARCH_BRCMSTB
> bool "Broadcom Set-Top-Box SoCs"
> select ARCH_HAS_RESET_CONTROLLER
> - select BCM7038_L1_IRQ
> - select BRCMSTB_L2_IRQ
> select GENERIC_IRQ_CHIP
> select PINCTRL
> help

How does the user know about that? People will build a kernel
selecting their platform, and find out it doesn't work. This seems
terribly counter-productive to me.

M.

--
Without deviation from the norm, progress is not possible.