From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBDD4C433ED for ; Fri, 23 Apr 2021 11:49:44 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BE82613CB for ; Fri, 23 Apr 2021 11:49:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BE82613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+mL1UuP1DzdAyVTjTfQurhrik9ysrf7YPO/bo2NwRM4=; b=aYofqQXZfJDW0BXQkGqt+YiKq MhvERXh77T2N+7HKhXRXIV9llHFb5FqExflBP0RX+dmvOcAGy1pgWQeWfrcoLhIHkd9+CrCGuQXxy J1vNEjRnJLpnV948oDtNrpylmhGJNDsrJ1y3vMuoXGMnujp/3VFVTnheGX2WjOs49gb4vcvXM1c9v 2GB59gGfKJG38rcOUTvAylfxx2O+BXbsgci9dbqRvEOQ5lQ880BL5QAm3XIRQHYueGIF8c+o/iuMi PqfwcLs7+qrqK4AoCN1XmNpD8gGjX3iJSnncknpBDbG4kBhth8wIuFn7sxLMq5N5wufXJVHlS1Xx6 96ukupkOg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lZuI0-001ODW-Q2; Fri, 23 Apr 2021 11:48:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZuHy-001ODF-Gq for linux-arm-kernel@desiato.infradead.org; Fri, 23 Apr 2021 11:48:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Vj67BFG8M2V3XtirikM28dg6DPD4Ht7oyRTJmvM/ytY=; b=BeYKI7dTEb+VMtK5Cv7zKRk7qh gVfD87pPuRBzfJmdFKfO9/NHZDz8n9Z/4oY2VuFLhIrzNO8e7yOxpxskPgIlFn/30nhjwPt318fEC s3ClSuUskGVjaW+YWOk6WTRxP035iooXzd9Lrxi1S8rXVEdffPwCM8uyf4p97IlBTF0ZheOwvSWDi yrVWJD4uegbAanXmiJ4rtuT5AcT/Cti2ID4G77Ib5jSvlLgZv0amdPittxr+vexOhI8djzlThRC0S QIn48Tgqgq+wPMxgKuvlH7MoiZuJEg+YLH8CjVSzeD9aFbyqMHDef2zZC7J2QN+wEVVcyARDV3LAO JYJvdTGg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lZuHw-00ENBg-0S for linux-arm-kernel@lists.infradead.org; Fri, 23 Apr 2021 11:48:01 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66D05613CB; Fri, 23 Apr 2021 11:47:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZuHs-0093xp-CC; Fri, 23 Apr 2021 12:47:56 +0100 Date: Fri, 23 Apr 2021 12:47:55 +0100 Message-ID: <87r1j1nrx0.wl-maz@kernel.org> From: Marc Zyngier To: Mark Rutland Cc: He Ying , tglx@linutronix.de, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] irqchip/gic-v3: Do not enable irqs when handling spurious interrups In-Reply-To: <20210423105051.GA83097@C02TD0UTHF1T.local> References: <20210423083516.170111-1-heying24@huawei.com> <20210423105051.GA83097@C02TD0UTHF1T.local> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, heying24@huawei.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210423_044800_103903_E00357DA X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 23 Apr 2021 11:50:51 +0100, Mark Rutland wrote: [...] > > Fixes: 17ce302f3117 ("arm64: Fix interrupt tracing in the presence of NMIs") > > Signed-off-by: He Ying > > I'm reckon the fixes tag should probably be either: > > Fixes: f32c926651dcd168 ("irqchip/gic-v3: Handle pseudo-NMIs") > > ... or: > > Fixes: 3f1f3234bc2db1c1 (" irqchip/gic-v3: Switch to PMR masking before calling IRQ handler") > > ... since the underlying issue is that gic_handle_irq() unmasks DAIF.I > and permits unintended nesting, even if that doesn't trigger a BUG() at > that point. I used the latter (see 161917211934.29796.1841651233234902273.tip-bot2@tip-bot2). > Otherwise, this makes sense to me: > > Acked-by: Mark Rutland I'll update the commit to reflect this. Thanks. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel