From: Adrian Ratiu <adrian.ratiu@collabora.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Nathan Chancellor <natechancellor@gmail.com>,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization
Date: Sat, 07 Nov 2020 20:12:39 +0200 [thread overview]
Message-ID: <87r1p5ujc8.fsf@collabora.com> (raw)
In-Reply-To: <20201107102203.GV1551@shell.armlinux.org.uk>
On Sat, 07 Nov 2020, Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
> On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote:
>> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c
>> index e1e76186ec23..84c91c48dfa2 100644 ---
>> a/arch/arm/lib/xor-neon.c +++ b/arch/arm/lib/xor-neon.c @@
>> -18,6 +18,10 @@ MODULE_LICENSE("GPL");
>> * Pull in the reference implementations while instructing GCC
>> (through * -ftree-vectorize) to attempt to exploit implicit
>> parallelism and emit * NEON instructions.
>> +
>
> Please tidy this up before submission; we normally continue the
> "*" for blank lines in comment blocks. Thanks.
Indeed, thank you. I will fix it if I don't replace this patch
entirely with something similar to what Nick suggested.
Perhaps adding a checkpatch test for this is a good idea?
Adrian
>
>> + * On Clang the loop vectorizer is enabled by default, but due to a bug
>> + * (https://bugs.llvm.org/show_bug.cgi?id=40976) vectorization is broke
>> + * so xor-neon is disabled in favor of the default reg implementations.
>> */
>> #ifdef CONFIG_CC_IS_GCC
>> #pragma GCC optimize "tree-vectorize"
>> --
>> 2.29.0
>>
>>
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-07 18:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 5:14 [PATCH 0/2] arm: lib: xor-neon: Remove warn & disble neon vect Adrian Ratiu
2020-11-06 5:14 ` [PATCH 1/2] arm: lib: xor-neon: remove unnecessary GCC < 4.6 warning Adrian Ratiu
2020-11-06 14:46 ` Arnd Bergmann
2020-11-06 18:03 ` Nathan Chancellor
2020-11-06 21:46 ` Arnd Bergmann
2020-11-06 5:14 ` [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization Adrian Ratiu
2020-11-06 10:14 ` Nathan Chancellor
2020-11-06 11:50 ` Adrian Ratiu
2020-11-06 18:01 ` Nathan Chancellor
2020-11-06 19:52 ` Nick Desaulniers
2020-11-07 18:07 ` Adrian Ratiu
2020-11-09 19:53 ` Adrian Ratiu
2020-11-10 21:41 ` Nick Desaulniers
2020-11-10 22:15 ` Arvind Sankar
2020-11-10 22:36 ` Nick Desaulniers
2020-11-10 22:39 ` Nick Desaulniers
2020-11-10 22:39 ` Nick Desaulniers
2020-11-10 22:54 ` Arvind Sankar
2020-11-10 23:56 ` Adrian Ratiu
2020-11-11 0:18 ` Nick Desaulniers
2020-11-11 14:15 ` Adrian Ratiu
2020-11-12 21:50 ` Arvind Sankar
2020-11-12 21:55 ` Nick Desaulniers
2020-11-07 10:22 ` Russell King - ARM Linux admin
2020-11-07 18:12 ` Adrian Ratiu [this message]
2020-11-08 17:40 ` Arvind Sankar
2020-11-08 18:09 ` Arvind Sankar
2020-11-08 20:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1p5ujc8.fsf@collabora.com \
--to=adrian.ratiu@collabora.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).