From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB90BC388F7 for ; Sat, 7 Nov 2020 18:13:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81AF120885 for ; Sat, 7 Nov 2020 18:13:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rxTbSE9/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81AF120885 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ykGoi4OxjZRlmwJdzeySw5jf/trJ5YLn9kHgsfG01PA=; b=rxTbSE9/u1f19I6MlV+lk6qT3 pNFhlACp667nTjhH9fHHqs1dU3g/lU0MBoD7C7tBTvF6l0YYY6JWYuCcMq1q7mMdftZi2RMcnaxNa Q7ilfI35McdKtJ+8WhL0+qwUZSYgI+xmFYT/Y8MXpJZV9lkERnNGhmPfIrlaLMtrZfRveJ/E0+n2X VmsbHJ3j6D0RhL0jmd+TkhjiD46RIvOu0Z5oAMpjrmHlsl/fbl7tO3FKZUob0aiy2q0fBN3MOiSEx eObgvKRBCIVLBDhYDHdolBVFLP5QHjHsio6A/7ych428B0fqpTWs9hlQQs3gBO1ITOSG/+hGxZjea jYiVYpEWA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbShl-0005Uz-3V; Sat, 07 Nov 2020 18:12:49 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbShi-0005Uc-3b for linux-arm-kernel@lists.infradead.org; Sat, 07 Nov 2020 18:12:47 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 5B9641F453A0 From: Adrian Ratiu To: Russell King - ARM Linux admin Subject: Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization In-Reply-To: <20201107102203.GV1551@shell.armlinux.org.uk> References: <20201106051436.2384842-1-adrian.ratiu@collabora.com> <20201106051436.2384842-3-adrian.ratiu@collabora.com> <20201107102203.GV1551@shell.armlinux.org.uk> Date: Sat, 07 Nov 2020 20:12:39 +0200 Message-ID: <87r1p5ujc8.fsf@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201107_131246_243174_08057E6D X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , kernel@collabora.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 07 Nov 2020, Russell King - ARM Linux admin wrote: > On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: >> diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c >> index e1e76186ec23..84c91c48dfa2 100644 --- >> a/arch/arm/lib/xor-neon.c +++ b/arch/arm/lib/xor-neon.c @@ >> -18,6 +18,10 @@ MODULE_LICENSE("GPL"); >> * Pull in the reference implementations while instructing GCC >> (through * -ftree-vectorize) to attempt to exploit implicit >> parallelism and emit * NEON instructions. >> + > > Please tidy this up before submission; we normally continue the > "*" for blank lines in comment blocks. Thanks. Indeed, thank you. I will fix it if I don't replace this patch entirely with something similar to what Nick suggested. Perhaps adding a checkpatch test for this is a good idea? Adrian > >> + * On Clang the loop vectorizer is enabled by default, but due to a bug >> + * (https://bugs.llvm.org/show_bug.cgi?id=40976) vectorization is broke >> + * so xor-neon is disabled in favor of the default reg implementations. >> */ >> #ifdef CONFIG_CC_IS_GCC >> #pragma GCC optimize "tree-vectorize" >> -- >> 2.29.0 >> >> > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel