From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD086C433E0 for ; Thu, 23 Jul 2020 09:23:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95E85206F4 for ; Thu, 23 Jul 2020 09:23:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XKjan8kr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S4AhXuny" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95E85206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DDTHbZxXgv8eoMXKcIaCEkloWJyQ+tQKbvrt/GQCttc=; b=XKjan8krg43xRXegp4GDUhVWI AqBwwoTcrccYkK01P/ZnJBRAJFBXnpZpiNzHaKKkYYkGytcuBLs6+5/IOnwP37mkDdDveAgpbB22u ILOQiXoMebgP3LZ4Fk0AM1FEvbojeSzOKA5jlZoNED5QducEHw3o214dGo1Q4X2y+aGlzm1y9FO0c QD92bCXTFqHfngxUkJPaXD4j1v8YsNBbwafpBLgnFRroSU42d8rAjiHDVLobTTQLyLsiBi94jquVD NDXYzHrTO5xULc7zwRqSzmpXaJ66K+8liQlbaJORnQ4/yTpG5MpcyskOV+PYAxKe6vvXjoV0kr92N wGfVyltPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXQp-0006bl-Ae; Thu, 23 Jul 2020 09:22:27 +0000 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyXQm-0006b1-5Q for linux-arm-kernel@lists.infradead.org; Thu, 23 Jul 2020 09:22:24 +0000 Received: by mail-lf1-x144.google.com with SMTP id k13so2913442lfo.0 for ; Thu, 23 Jul 2020 02:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=XvcKynrAqO64jDpC8rXFTuj/dKk+qiTN+T9dWEvAtxc=; b=S4AhXunyLyzCvttdEP0lHg79NiI8x2rN7v5vr5tZWrBNhnHq8dZqaGGts0UMrYKMZR pdHmEaCvziSeqmM8ClLwcBfgaRB7ZwYo+lU/y6ShCbzUfItxrVlUAw66KmjVW4WCAgNW is6DO6kAXsPA8u0GmhrWGh7KzQnkbvgGAg/MwSQXgt4Umz25XuzvlP0MCz+XSNOI88wF vNT27LmNPB6occfeHKtWA6mpm/GSqhD4qb94f6m2WQ5loOzsvEXhuTVYn4EUfFtkXNtn zKT3L7W6DBBvJ/rdamodnz8iN1QeywLHRnMnDWJ/xnszln22r6PkYqxcd8u3tpQ8FyBD gVBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :date:message-id:mime-version; bh=XvcKynrAqO64jDpC8rXFTuj/dKk+qiTN+T9dWEvAtxc=; b=PYJVOouAOt+xJ939Um+C/R0/zEjvHsPALUR0i2eubQavsADaCs4+UGyH+EvqeK7GU9 orUrlc6V/e+wiNnENBJXWe6Z47TI1bZmvCzOVPvWdPfXV3E3FnlhGipQ41mjLLvRQYHE mPKIT3xBp1PISe1U+6Sia5vsQxsoiUuoIIcoBVKZ1UUvqf/y3rf+nsSLTlAwLYlfD8eS aQxqUmvzydGiK0BTC0kZzlOvNYzxNjt7ew8ZFOEai5otCC7zPF/GVLjXz85SCCiM1fie LAyO1OlEapSk6xgDVQtcE7Jm4j39rTeJplClVRb4mIY7v04VDFiSjyy6sX+nHDr5QwcT 75hA== X-Gm-Message-State: AOAM530VajU0++VGQhgguJDLdt7NuWbCa0Xz3e8Z5JbCzbKsuus9Qiea b+bfIGYYrjI+pz/psgOYz+I= X-Google-Smtp-Source: ABdhPJz/q1d2N92Gvcbi/36LZ3e25H6+JolBjAiy3RzcxRita7lk14lAd0B4uewMO9o4dqee1cz8ug== X-Received: by 2002:a19:654c:: with SMTP id c12mr1860082lfj.132.1595496141134; Thu, 23 Jul 2020 02:22:21 -0700 (PDT) Received: from saruman (91-155-214-58.elisa-laajakaista.fi. [91.155.214.58]) by smtp.gmail.com with ESMTPSA id i5sm359918lfe.5.2020.07.23.02.22.19 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jul 2020 02:22:20 -0700 (PDT) From: Felipe Balbi To: Li Jun , shawnguo@kernel.org, robh+dt@kernel.org Subject: Re: [PATCH v2 1/5] usb: dwc3: add platform data to dwc3 core device to pass data In-Reply-To: <1594028699-1055-2-git-send-email-jun.li@nxp.com> References: <1594028699-1055-1-git-send-email-jun.li@nxp.com> <1594028699-1055-2-git-send-email-jun.li@nxp.com> Date: Thu, 23 Jul 2020 12:22:15 +0300 Message-ID: <87r1t2oabc.fsf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200723_052224_242761_CA6D124E X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, peng.fan@nxp.com, horia.geanta@nxp.com, Anson.Huang@nxp.com, peter.chen@nxp.com, gregkh@linuxfoundation.org, s.hauer@pengutronix.de, linux-usb@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7817596217032576953==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7817596217032576953== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Li Jun writes: > In case dwc3 has SoC specific customizations, dwc3 glue driver can base on > compatible string and pass it via platform data to dwc3 core driver; and > pass xhci private data further to xhci-plat like quirks. > > Signed-off-by: Li Jun > --- > drivers/usb/dwc3/core.h | 5 +++++ > drivers/usb/dwc3/host.c | 9 +++++++++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index 0b8ea8c..3146697 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -29,6 +29,7 @@ > #include >=20=20 > #include > +#include "../host/xhci-plat.h" >=20=20 > #define DWC3_MSG_MAX 500 >=20=20 > @@ -924,6 +925,10 @@ struct dwc3_scratchpad_array { > __le64 dma_adr[DWC3_MAX_HIBER_SCRATCHBUFS]; > }; >=20=20 > +struct dwc3_platform_data { > + struct xhci_plat_priv *xhci_priv; > +}; why? We should rely on properties, no? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl8ZVscACgkQzL64meEa mQZq4w//e21Lo4ff7jZDTYI4GNKwH8wGmrPPmEocHEMLnDb55BHDFolJp0dFTNg5 tj06t+ukHPltpMdJB2NBhAT3hAwTFOuyl3SiTtnWkFAT5Pr/s+juL4qmOwCBrFwb /OSnwtgXr3b3wM88Wil8O6XqolUPe1rCWprGv+PAMnmnmFe6WALjbUoIfts/gvxY WPyGDnKLFyGhCt89CbAhCNpnhsqOzg4Ic1RTLMxARM5s+m8BZrfPSPS0L/5npKq3 +SxdlQgnCnrmOZrUkVbw+w9PF1XbR2elsQOiBnSADYIx7azi6DcBtqe+ClLImb4Q wsfDmCrZ+yp8/BMW7MR+YvcPp8JsTH5scbv6owSu7FF9uZA9wk44kbzSL4aA0La5 yWWmyGdkWiloxzMQCODq7sd+tizcTqZADhKylQ8YKF+7sEtDuyaNowoC6fV50Zk+ /oTqCr6lwGkWiwE2M/FsWeXZo4+DdkXKobQx0OvyJjyqJ/26SQKyOEGoZO+xZVg/ fDkoV/GPbgdBc89tB6HG5FiTyCXLY1oqAuNwWiZcSA03YSbBglCQGwDEh4hvGW16 CTrT8kMATxUvTYlwMnfTwGRQwQtCp+veazjD9ZgEtfk0aB9Bwwl1qlTgok31xDI1 uZlB9d0GbnabH8BceuyeCwgaBjFDexRPuAXVQI9TcB5ON5rZUSY= =yp3d -----END PGP SIGNATURE----- --=-=-=-- --===============7817596217032576953== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7817596217032576953==--