From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACEDFC38A24 for ; Thu, 7 May 2020 17:30:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58C6120663 for ; Thu, 7 May 2020 17:30:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k7wN3SVY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58C6120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u+DkS/MlFv7vb4TjrM+dNKiI08wHZSOb1bgQC2MSdF4=; b=k7wN3SVY5r+QZM /qGYogZx9B5UDpdlk8ozhCvpdE1F6nm9g3l0b6HkEcrNw0SxFPogFrLWRjSJNDSG9k9u/r7hWmx7N rRmKevx1i1/d1RrA8Af46Ih+JDxid2C6InuPIi33MtiRZF1pzZ6DtqOF7U0s5595vlq9+Hwm18dJT 1oeenbwdivNwbDDgmnFIo7FVVIeI+XsZH7mRHuWnrB32goe8RuQZagytKxYmeZSxHGljEEyrNFSmX mDfwNMuBNpVq6fuKbp8LueQxPnB99orNX2zSru7aWNq7PFJEqX4IJ92B4DCU/Zy+GJtbzctI3KfFC WwKYwMIZqBGuJGAAxy+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWkLg-0003HH-2g; Thu, 07 May 2020 17:30:16 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWkLd-0001nO-85 for linux-arm-kernel@lists.infradead.org; Thu, 07 May 2020 17:30:14 +0000 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jWkLW-0001Z4-63; Thu, 07 May 2020 19:30:06 +0200 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 9030A102652; Thu, 7 May 2020 19:30:05 +0200 (CEST) From: Thomas Gleixner To: Marek Vasut , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] [RFC] genirq: Check irq_data_get_irq_chip() return value before use In-Reply-To: <20200507150729.244468-1-marex@denx.de> References: <20200507150729.244468-1-marex@denx.de> Date: Thu, 07 May 2020 19:30:05 +0200 Message-ID: <87r1vvejqa.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200507_103013_440611_AFDF39DD X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Marc Zyngier , Linus Walleij , Stephen Boyd Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Marek Vasut writes: > The irq_data_get_irq_chip() can return NULL. If the kernel accesses > chip->irq_get_irqchip_state without checking whether chip is valid, > we get a crash. Fix this by checking whether chip is not NULL before > using it. > > Fixes: 1b7047edfcfb ("genirq: Allow the irqchip state of an IRQ to be save/restored") > Signed-off-by: Marek Vasut > --- > NOTE: I don't know whether this is a correct fix. Maybe the > irq_data_get_irq_chip() should never return NULL, and > I have some other issue? What's the callchain? Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel