From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Thu, 28 Dec 2017 09:01:55 +0100 Subject: [PATCH] ARM: pxa: ulpi: fix ulpi timeout and slowpath warn In-Reply-To: <20171226133253.11653-1-grinberg@compulab.co.il> (Igor Grinberg's message of "Tue, 26 Dec 2017 15:32:53 +0200") References: <20171226133253.11653-1-grinberg@compulab.co.il> Message-ID: <87r2rf7024.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Igor Grinberg writes: > Both cm-x300 and pxa3xx-ulpi use the plain clk_{en,dis}able() API. > With the new clocking framework this results in warnings of type: > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:714 clk_core_enable+0x90/0x9c > Modules linked in: > CPU: 0 PID: 1 Comm: swapper Not tainted 4.15.0-rc5-cm-x300+ #15 > Hardware name: CM-X300 module > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (__warn+0xd8/0x100) > [] (__warn) from [] (warn_slowpath_null+0x3c/0x48) > [] (warn_slowpath_null) from [] (clk_core_enable+0x90/0x9c) > [] (clk_core_enable) from [] (clk_core_enable_lock+0x18/0x2c) > [] (clk_core_enable_lock) from [] (cm_x300_u2d_init+0x4c/0xe8) > [] (cm_x300_u2d_init) from [] (pxa3xx_u2d_probe+0xe0/0x244) > [] (pxa3xx_u2d_probe) from [] (platform_drv_probe+0x38/0x88) > ... > ------------[ cut here ]------------ > and alike... > > And finally, it results in: > ------------[ cut here ]------------ > pxa310_ulpi_poll: ULPI access timed out! > OTG transceiver init failed > ------------[ cut here ]------------ > > It might be that disabling the warning in kernel config would also do > the job, but IMO a better solution would be to switch to > clk_prepare_enable() and clk_disable_unprepare() APIs. > > Signed-off-by: Igor Grinberg Applied to pxa/for-next, thanks. Cheers. -- Robert