From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Mon, 09 Mar 2015 16:25:58 +0000 Subject: [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs In-Reply-To: References: <1424880159-29348-1-git-send-email-alex.bennee@linaro.org> <1424880159-29348-7-git-send-email-alex.bennee@linaro.org> <20150302172212.GB10137@lvm> <874mq27222.fsf@linaro.org> <20150309125650.GA20559@cbox> Message-ID: <87r3syb0ix.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Peter Maydell writes: > On 9 March 2015 at 21:56, Christoffer Dall wrote: >> this function, however, is not used only when migration, but should >> generally cover the case where you want to synchronize QEMU's state into >> KVM's state, right? So while it may not be harmful in currently >> supported use cases, is there ever a situation where (is_a64(env) && el >> == 0) and env->spsr != banked_spsr[el], and where env->spsr is >> out-of-date? > > If EL == 0 then you can't access any SPSR, so env->spsr is by > definition out of date. Indeed and in v2 the whole thing is wrapped in if (el > 0) > > -- PMM -- Alex Benn?e