From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] OMAP4: PM: Do not assume clkdm supports hw transitions
Date: Tue, 14 Dec 2010 11:52:50 -0800 [thread overview]
Message-ID: <87r5dkrv1p.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1292276969-29733-3-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Mon, 13 Dec 2010 22:49:26 +0100")
Benoit Cousson <b-cousson@ti.com> writes:
> From: Rajendra Nayak <rnayak@ti.com>
>
> omap_set_pwrdm_state today assumes a clkdm supports hw_auto
> transitions and hence leaves some which do not support this
> in sw wkup state preventing low power transitions.
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Acked-by: Benoit Cousson <b-cousson@ti.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/pm.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index dc68044..a2a70e1 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -91,8 +91,7 @@ static void omap2_init_processor_devices(void)
>
> /*
> * This sets pwrdm state (other than mpu & core. Currently only ON &
> - * RET are supported. Function is assuming that clkdm doesn't have
> - * hw_sup mode enabled.
> + * RET are supported.
> */
> int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state)
> {
> @@ -135,7 +134,10 @@ int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state)
> }
>
> if (sleep_switch) {
> - omap2_clkdm_allow_idle(pwrdm->pwrdm_clkdms[0]);
> + if (pwrdm->pwrdm_clkdms[0]->flags & CLKDM_CAN_ENABLE_AUTO)
> + omap2_clkdm_allow_idle(pwrdm->pwrdm_clkdms[0]);
> + else
> + omap2_clkdm_sleep(pwrdm->pwrdm_clkdms[0]);
> pwrdm_wait_transition(pwrdm);
> pwrdm_state_switch(pwrdm);
> }
next prev parent reply other threads:[~2010-12-14 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 21:49 [PATCH 0/5] OMAP3&4: Fixes in setup/suspend/powerdomain Benoit Cousson
2010-12-13 21:49 ` [PATCH 1/5] OMAP4: PM: Use the lowpwrstatechange feature on OMAP4 Benoit Cousson
2010-12-14 19:51 ` Kevin Hilman
2010-12-15 15:17 ` Rajendra Nayak
2010-12-15 23:40 ` Kevin Hilman
2010-12-13 21:49 ` [PATCH 2/5] OMAP4: PM: Do not assume clkdm supports hw transitions Benoit Cousson
2010-12-14 19:52 ` Kevin Hilman [this message]
2010-12-13 21:49 ` [PATCH 3/5] OMAP4: powerdomain: l4per pwrdm does not support OFF Benoit Cousson
2010-12-13 21:49 ` [PATCH 4/5] OMAP4: powerdomain: Remove L3INIT_PD OFF state Benoit Cousson
2010-12-13 21:49 ` [PATCH 5/5] OMAP4: clock data: Keep L3INSTR clock domain modulemode under HW control Benoit Cousson
2010-12-14 6:43 ` [PATCH 0/5] OMAP3&4: Fixes in setup/suspend/powerdomain Paul Walmsley
2010-12-14 19:53 ` Kevin Hilman
2010-12-22 3:43 ` Paul Walmsley
2010-12-22 3:45 ` Paul Walmsley
2010-12-22 3:44 ` Paul Walmsley
2010-12-22 11:42 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5dkrv1p.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).