From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BE8BF99C7D for ; Sat, 18 Apr 2026 09:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XnXa7MkU7569dEttF49fIIVWr4gaS/LvA6I0KRIyGSg=; b=3o/ePnqsoGOlgWOroTY4mBsX3A TK0cpmMgtrpNh3od8CPNtOIhSNZ5dgwVJt8uyjzY2+XeDsMKBw5+pRusL64Uo1m27WT65NKhjF9YF DhqpV30HbWfBnhGB3+WiSCnrgFMPYMaumN62KWN4h6zuenY2oZmisrkOFF4wF9sadzTCF47hUymMz 2DYGNhtTm35+SoDXCoHwvNjD5N0z64m8qgggY/S70PpPyhNl+d8Y+iz0j/Dm6/eQ5J1OlU47BE6MT PkTa1DX4ktUQgdVWmJAesMIYxJOAQbITK4w4mmNgnCs6JzFA1c0ZHDE7966DPQ56ojdsZ6KQgqbfE K0yHbkqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1wE1uQ-00000004sKC-1tBG; Sat, 18 Apr 2026 09:24:14 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1wE1uN-00000004sJh-1ZPi for linux-arm-kernel@lists.infradead.org; Sat, 18 Apr 2026 09:24:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 66259438AA; Sat, 18 Apr 2026 09:24:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EA38C19424; Sat, 18 Apr 2026 09:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776504248; bh=0ov1NsdSXTwZuP0OYLxLpWWdS0BPSYlf16OkCz2Chuo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=psaqB+PyHoKTjVFVeG1nWNLU/sIFLD+gwKXR0ZkpnwTxxDwvh7ea2whG6uFskH68m xX1SlgQtWzY4vHCHRKEuGDpYZ+MWqlGn46DAvyRaKZvUuwZphTshFDZIvywN8XhVtu mfxR1hp2QOdnDjjjQMt2eSZuODCbzU8y5iROWtz4D0eBx462YMAtsp1nd/1Bh6sJq2 JAGi19lsreaard3IcKPmuHzuVjc0fzd5xfPypjSZMupd8Q3iIAgS0JZbuPYLbJZkk8 toAWTtRD2kuh0LJKYQ6rnJo7LODmjg4f+HkC4TEMNrIEKBPw8XjoeCbsDbx0ZU6PiR Eur4BRYWDQLFw== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wE1uH-0000000CeR1-1NIO; Sat, 18 Apr 2026 09:24:05 +0000 Date: Sat, 18 Apr 2026 10:24:04 +0100 Message-ID: <87se8sbozv.wl-maz@kernel.org> From: Marc Zyngier To: Yeoreum Yun Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, zohar@linux.ibm.com, roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, sudeep.holla@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org Subject: Re: [RFC PATCH 4/4] firmware: arm_ffa: check pkvm initailised when initailise ffa driver In-Reply-To: <20260417175759.3191279-5-yeoreum.yun@arm.com> References: <20260417175759.3191279-1-yeoreum.yun@arm.com> <20260417175759.3191279-5-yeoreum.yun@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yeoreum.yun@arm.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, zohar@linux.ibm.com, roberto.sassu@huawei.com, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, sudeep.holla@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260418_022411_473428_F7604D06 X-CRM114-Status: GOOD ( 22.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 17 Apr 2026 18:57:59 +0100, Yeoreum Yun wrote: > > When pKVM is enabled, the FF-A driver must be initialized after pKVM. > Otherwise, pKVM cannot negotiate the FF-A version or > obtain RX/TX buffer information, leading to failures in FF-A calls. > > During FF-A driver initialization, check whether pKVM has been initialized. > If not, defer probing of the FF-A driver. > > Signed-off-by: Yeoreum Yun > --- > arch/arm64/kvm/arm.c | 1 + > drivers/firmware/arm_ffa/driver.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 410ffd41fd73..0f517b1c05cd 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -119,6 +119,7 @@ bool is_kvm_arm_initialised(void) > { > return kvm_arm_initialised; > } > +EXPORT_SYMBOL(is_kvm_arm_initialised); EXPORT_SYMBOL_GPL(), please. > > int kvm_arch_vcpu_should_kick(struct kvm_vcpu *vcpu) > { > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c > index 02c76ac1570b..2647d6554afd 100644 > --- a/drivers/firmware/arm_ffa/driver.c > +++ b/drivers/firmware/arm_ffa/driver.c > @@ -42,6 +42,8 @@ > #include > #include > > +#include > + > #include "common.h" > > #define FFA_DRIVER_VERSION FFA_VERSION_1_2 > @@ -2035,6 +2037,16 @@ static int __init ffa_init(void) > u32 buf_sz; > size_t rxtx_bufsz = SZ_4K; > > + /* > + * When pKVM is enabled, the FF-A driver must be initialized > + * after pKVM initialization. Otherwise, pKVM cannot negotiate > + * the FF-A version or obtain RX/TX buffer information, > + * which leads to failures in FF-A calls. > + */ > + if (IS_ENABLED(CONFIG_KVM) && is_protected_kvm_enabled() && > + !is_kvm_arm_initialised()) > + return -EPROBE_DEFER; > + That's still fundamentally wrong: pkvm is not ready until finalize_pkvm() has finished, and that's not indicated by is_kvm_arm_initialised(). M. -- Jazz isn't dead. It just smells funny.