public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* syscall.tbl refactoring seems to have dropped definition of __NR_newfstatat on arm64 and riscv (64-bit) at least
@ 2024-08-01 11:28 Florian Weimer
  2024-08-01 11:47 ` Andreas Schwab
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2024-08-01 11:28 UTC (permalink / raw)
  To: linux-riscv, linux-arm-kernel, linux-api, linux-kernel
  Cc: Arnd Bergmann, Catalin Marinas

It's been repported that __NR_newfstatat has gone missing from the UAPI
headers.

  [sanitizer] __NR_newfstatat not defined in linux kernel headers in
  aarch64
  <https://github.com/llvm/llvm-project/issues/100098>

  __NR_newfstatat no longer defined on aarch64
  <https://bugzilla.redhat.com/show_bug.cgi?id=2301919>

I suspect that's related to the syscall.tbl refactoring around these
commits:

commit e632bca07c8eef1de9dc50f4e4066c56e9d68b07
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Thu Jul 4 14:33:34 2024 +0200

    arm64: generate 64-bit syscall.tbl

commit 3db80c999debbadd5d627fb30f8b06fee331ffb6
Author: Arnd Bergmann <arnd@arndb.de>
Date:   Wed Apr 24 09:14:39 2024 +0200

    riscv: convert to generic syscall table

Thanks,
Florian



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: syscall.tbl refactoring seems to have dropped definition of __NR_newfstatat on arm64 and riscv (64-bit) at least
  2024-08-01 11:28 syscall.tbl refactoring seems to have dropped definition of __NR_newfstatat on arm64 and riscv (64-bit) at least Florian Weimer
@ 2024-08-01 11:47 ` Andreas Schwab
  2024-08-01 12:20   ` Arnd Bergmann
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Schwab @ 2024-08-01 11:47 UTC (permalink / raw)
  To: Florian Weimer
  Cc: linux-riscv, linux-arm-kernel, linux-api, linux-kernel,
	Arnd Bergmann, Catalin Marinas

On Aug 01 2024, Florian Weimer wrote:

> It's been repported that __NR_newfstatat has gone missing from the UAPI
> headers.

It has actually been wrongly renamed to __NR_fstatat.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: syscall.tbl refactoring seems to have dropped definition of __NR_newfstatat on arm64 and riscv (64-bit) at least
  2024-08-01 11:47 ` Andreas Schwab
@ 2024-08-01 12:20   ` Arnd Bergmann
  0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-08-01 12:20 UTC (permalink / raw)
  To: Andreas Schwab, Florian Weimer
  Cc: linux-riscv, linux-arm-kernel, linux-api, linux-kernel,
	Catalin Marinas

On Thu, Aug 1, 2024, at 13:47, Andreas Schwab wrote:
> On Aug 01 2024, Florian Weimer wrote:
>
>> It's been repported that __NR_newfstatat has gone missing from the UAPI
>> headers.
>
> It has actually been wrongly renamed to __NR_fstatat.

Ah, I see what happened now, this was part of a semi-automated
conversion from the old format and I incorrectly split up the
entries between 32-bit and 64-bit.

There is another bug in the same entry, since in the meantime,
we have also decided to make newfstat/newfstatat unconditional
again for all 64-bit architectures, and this hasn't made it into
the new syscall.tbl format. This one is only important for
loongarch64.

I'll fix up both ASAP, thanks a lot for the report!

      Arnd


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-01 12:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-01 11:28 syscall.tbl refactoring seems to have dropped definition of __NR_newfstatat on arm64 and riscv (64-bit) at least Florian Weimer
2024-08-01 11:47 ` Andreas Schwab
2024-08-01 12:20   ` Arnd Bergmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox