From: Thomas Gleixner <tglx@linutronix.de>
To: "Bjorn Helgaas" <helgaas@kernel.org>, "Marek Behún" <kabel@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Rob Herring" <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Pali Rohár" <pali@kernel.org>, "Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH v2] PCI: mvebu: Dispose INTx IRQs before to removing INTx domain
Date: Sat, 13 Jul 2024 12:33:29 +0200 [thread overview]
Message-ID: <87sewdshs6.ffs@tglx> (raw)
In-Reply-To: <20240712204106.GA336836@bhelgaas>
On Fri, Jul 12 2024 at 15:41, Bjorn Helgaas wrote:
> On Thu, Jul 11, 2024 at 03:25:44PM +0200, Marek Behún wrote:
>> /* Remove IRQ domains. */
>> - if (port->intx_irq_domain)
>> + if (port->intx_irq_domain) {
>> + for (int j = 0; j < PCI_NUM_INTX; j++) {
>> + int virq = irq_find_mapping(port->intx_irq_domain, j);
>> +
>> + if (virq > 0)
>> + irq_dispose_mapping(virq);
>
> I am not an IRQ expert, so all I can really do is compare this to
> usage in other drivers.
>
> There are 20+ drivers in drivers/pci/controller, and I don't see
> irq_dispose_mapping() usage similar to this elsewhere. Does that mean
> most or all of the other drivers have a similar defect?
Right.
But the real question is why is such a mapping not torn down by the
entity (device, bridge, whatever) which set it up in the first place?
Thanks,
tglx
next prev parent reply other threads:[~2024-07-13 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 13:25 [PATCH v2] PCI: mvebu: Dispose INTx IRQs before to removing INTx domain Marek Behún
2024-07-11 14:03 ` Andrew Lunn
2024-07-12 20:41 ` Bjorn Helgaas
2024-07-13 10:33 ` Thomas Gleixner [this message]
2024-07-13 19:32 ` Bjorn Helgaas
2024-07-13 19:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sewdshs6.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=gregory.clement@bootlin.com \
--cc=helgaas@kernel.org \
--cc=kabel@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox