From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 071C4C3DA45 for ; Sat, 13 Jul 2024 10:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PZz21t0XLRVOmJf1C/wt+L4fSHfWkHnEUPmCtKL8PpA=; b=sS22b69MNE4iXL97cFyD2/VQxP 0d/tRMa2Et0O6MMEG0Yl2HKTkLadqqLQLZjLuTGZOTvs/6gxy0kR4gUhTUEwHBTwIv7H/P3klkfc+ HBcE8FG+16kMRcz9zIoeU4KANDcfJNi7XZgUtiXgKvOwXjYPz4MEmi6M42uOFbGjzsWDQ7URdlYYQ yInOLZ5PScCPG85snMDqyjiJqs1w+4cyrTjJWApcHbcB7+Y/N+UIjlOAdoQ7B9TsnZntdTmBbX1vF RcIWbEdlmcdtYBxhqyYYR0It0iftwW7l5fptXfx2v0TI3ITdPznoVGbxAcLDZRHSERvHO/IiLdJqr X51N1Ltw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSa4f-00000002MuY-3aP0; Sat, 13 Jul 2024 10:33:53 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSa4K-00000002Mrj-2vcE for linux-arm-kernel@lists.infradead.org; Sat, 13 Jul 2024 10:33:35 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1720866811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZz21t0XLRVOmJf1C/wt+L4fSHfWkHnEUPmCtKL8PpA=; b=kFf52Hi8NhDlogfXYjuhjpOvWXA+t206AfqmeQX4Hw07oWH1iA8AQTihB49OxRFVMEMaaK zEiKCkRpn47iWeTKn7Xx7wCq+1MmfsekkVB3f7ShdzF1c0ICBZ6DTqiO/8XXzJ2Y/bUgBA C8qEY5iP8NfGf2c9IvNtGQMqc3G0Lu8j/soo4skBdGXJPc2+7xousV+IWjYC/1wnIg73qT lPOLejZKX8kEyk7y84xnPEGz0iRWwac8aWABaSN/kMS6/+1xQsh3IUz03N2fyKogkn01kF MYOQig/YGaavqxwSX+TIto8WicpOtY0ZLPzeeCEN+yroPW7UYZcaLw8s2f0mFg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1720866811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZz21t0XLRVOmJf1C/wt+L4fSHfWkHnEUPmCtKL8PpA=; b=X+gNrFhx0snjnQnJW9TFrHzrSTwdKTo4kwXHt2OOYcjD+8RWTRYU+zkejywQeKFP3Mhs+4 TQVRb2SMHOPMNhAg== To: Bjorn Helgaas , Marek =?utf-8?Q?Beh=C3=BAn?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy?= =?utf-8?Q?=C5=84ski?= , Bjorn Helgaas , Andrew Lunn , Gregory Clement , Thomas Petazzoni , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Manivannan Sadhasivam , Pali =?utf-8?Q?Roh=C3=A1r?= , Marc Zyngier Subject: Re: [PATCH v2] PCI: mvebu: Dispose INTx IRQs before to removing INTx domain In-Reply-To: <20240712204106.GA336836@bhelgaas> References: <20240712204106.GA336836@bhelgaas> Date: Sat, 13 Jul 2024 12:33:29 +0200 Message-ID: <87sewdshs6.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240713_033332_946759_2CF774EF X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 12 2024 at 15:41, Bjorn Helgaas wrote: > On Thu, Jul 11, 2024 at 03:25:44PM +0200, Marek Beh=C3=BAn wrote: >> /* Remove IRQ domains. */ >> - if (port->intx_irq_domain) >> + if (port->intx_irq_domain) { >> + for (int j =3D 0; j < PCI_NUM_INTX; j++) { >> + int virq =3D irq_find_mapping(port->intx_irq_domain, j); >> + >> + if (virq > 0) >> + irq_dispose_mapping(virq); > > I am not an IRQ expert, so all I can really do is compare this to > usage in other drivers. > > There are 20+ drivers in drivers/pci/controller, and I don't see > irq_dispose_mapping() usage similar to this elsewhere. Does that mean > most or all of the other drivers have a similar defect? Right. But the real question is why is such a mapping not torn down by the entity (device, bridge, whatever) which set it up in the first place? Thanks, tglx