From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67761C27C79 for ; Mon, 17 Jun 2024 12:52:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=19qM+3bC9IjzpcT4GLOy0AdQrrp4B3Guy2WZKGWUKCs=; b=y3+vNRR8olrkFOeuWaMSL6n77i 64U07jt0sST//3rklMsft8xmMDFsBQdiWT6VEko/ReoYi/zA8XRnxVlrGuw2BLT+5FJ2vTrTuif1H A0ipU9rpfUDrR3DaHgDdm+bFvj7wo7ltEnpinvrYkdIu5PKoqdgR9sClhg1H/Bgug2Bht/N9++mT7 lX4UuMA08fT5wG6Hermv6DKd5So4Ca3lRuUepDzZgYwirFL8/FhnVfW5DIgPvuiQ4NB5pQnFUDqgS SYRlnB9cMkC/dH9Tzh/Qf8UyPvYTx0RxSJd0D7PpxR9+S5OckCfXiBRKF5Qp2BnqunzXMDiPAkrWr 9iMKkQbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJBqG-0000000Ahre-1ueq; Mon, 17 Jun 2024 12:52:12 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJBqB-0000000Ahpe-35AC for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 12:52:11 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1718628724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=19qM+3bC9IjzpcT4GLOy0AdQrrp4B3Guy2WZKGWUKCs=; b=G6nYcwtt0mhaDuEz7D965JCkNOeu58+rguak4oBaNfg4r7LM/acg2xDVIoVeftI1T4MxpV ACivdbcm/hmN2Yu7wFdvpXLmkI8hnMLM01ES2j/0RrbH1nom1i4f7BffGyzhz+3xyvgMJx dWQNNDWtVj4Q9I2wg8Jr05dqNvp/bXdgmAhR/g5vOqj2g33FST6PjZCqdu/nLaUGxN7FjM jk5mV1+W0EmKHwQjA8+92+ZfvYaTgtDigz0OgNbx6NAco17UBX7HBtz2U62uIusElGjgz3 Y0TdFGM659tpsL8kjYvAD1ugWT8cbzbXLGg2Yz+LKRty2OUa6eOMAUP2zYvbqw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1718628724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=19qM+3bC9IjzpcT4GLOy0AdQrrp4B3Guy2WZKGWUKCs=; b=AlFAfYvCXQ7h+o3wd68KVSlPn6D2rLSUFw7og3Zo8KfDThkMqkCIKNS7FSmiMhSIMav69q GqS6NgOGyXRLA1Ag== To: Bjorn Helgaas , Shivamurthy Shastri Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, maz@kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com Subject: Re: [PATCH v3 03/24] PCI/MSI: Provide MSI_FLAG_PCI_MSI_MASK_PARENT In-Reply-To: <20240614160942.GA1114672@bhelgaas> References: <20240614160942.GA1114672@bhelgaas> Date: Mon, 17 Jun 2024 14:52:03 +0200 Message-ID: <87sexbu3yk.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_055207_963603_A5D3DDC1 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14 2024 at 11:09, Bjorn Helgaas wrote: > On Fri, Jun 14, 2024 at 12:23:42PM +0200, Shivamurthy Shastri wrote: >> Most ARM(64) PCI/MSI domains mask and unmask in the parent domain after or >> before the PCI mask/unmask operation takes place. So there are more than a >> dozen of the same wrapper implementation all over the place. > > Is this an opportunity to clean up all these wrappers? If you could > mention an example or two here, maybe somebody would be motivated to > come back and simplify the existing wrappers to take advantage of this > new flag? The wrappers go away once the relevant MSI implementations are converted over to the new scheme/ See patch 7 for an example: its_[un]mask_msi_irq() are gone. Thanks, tglx